Re: [PATCH] dt-bindings: serial: actions,owl-uart: convert to dtschema

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 21/03/2024 09:43, Kanak Shilledar wrote:
> From: Kanak Shilledar <kanakshilledar111@protonmail.com>
> 
> Convert the Actions Semi Owl UART to newer DT schema.

You are using ProtonMail, so just be aware that it might not be suitable
for public Linux discussions:
https://www.kernel.org/doc/html/next/process/email-clients.html#proton-mail

(no need to resend just for that)

> 
> Signed-off-by: Kanak Shilledar <kanakshilledar111@protonmail.com>
> ---
>  .../bindings/serial/actions,owl-uart.txt      | 16 -------
>  .../bindings/serial/actions,owl-uart.yaml     | 43 +++++++++++++++++++
>  2 files changed, 43 insertions(+), 16 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/serial/actions,owl-uart.txt
>  create mode 100644 Documentation/devicetree/bindings/serial/actions,owl-uart.yaml
> 
> diff --git a/Documentation/devicetree/bindings/serial/actions,owl-uart.txt b/Documentation/devicetree/bindings/serial/actions,owl-uart.txt
> deleted file mode 100644
> index aa873eada02d..000000000000
> --- a/Documentation/devicetree/bindings/serial/actions,owl-uart.txt
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -Actions Semi Owl UART
> -
> -Required properties:
> -- compatible :  "actions,s500-uart", "actions,owl-uart" for S500
> -                "actions,s900-uart", "actions,owl-uart" for S900
> -- reg        :  Offset and length of the register set for the device.
> -- interrupts :  Should contain UART interrupt.
> -
> -
> -Example:
> -
> -		uart3: serial@b0126000 {
> -			compatible = "actions,s500-uart", "actions,owl-uart";
> -			reg = <0xb0126000 0x1000>;
> -			interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> -		};
> diff --git a/Documentation/devicetree/bindings/serial/actions,owl-uart.yaml b/Documentation/devicetree/bindings/serial/actions,owl-uart.yaml
> new file mode 100644
> index 000000000000..ee0e508255b6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/actions,owl-uart.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/serial/actions,owl-uart.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Actions Semi Owl UART
> +
> +maintainers:
> +  - Kanak Shilledar <kanakshilledar111@protonmail.com>
> +
> +allOf:
> +  - $ref: serial.yaml
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - actions,s500-uart
> +          - actions,s900-uart
> +          - actions,owl-uart

That's not what old binding said and you did not explain differences
from conversion in commit msg.


> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    serial@b0126000 {
> +        compatible = "actions,s500-uart";

That's not what was in old binding.

That's not what is being used. It does not look like you tested the DTS
against bindings. Please run `make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).


Best regards,
Krzysztof