From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
Cc: linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Lee Jones <lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] bcm2835: Add Raspberry Pi thermal sensor to the device tree
Date: Tue, 20 Oct 2015 21:03:16 -0600 [thread overview]
Message-ID: <56270074.90501@wwwdotorg.org> (raw)
In-Reply-To: <1444592937-16320-1-git-send-email-lkundrak-NGH9Lh4a5iE@public.gmane.org>
On 10/11/2015 01:48 PM, Lubomir Rintel wrote:
> Driven via the Raspberry Pi VideoCore 4 firmware interface.
> .../bindings/thermal/raspberrypi,bcm2835-thermal.txt | 13 +++++++++++++
> arch/arm/boot/dts/bcm2835-rpi.dtsi | 5 +++++
There should be a separate patch for the DT binding and DT additions,
but they can be in a series. As before, CC at least the DT binding to
the DT binding maintainers.
> diff --git a/Documentation/devicetree/bindings/thermal/raspberrypi,bcm2835-thermal.txt b/Documentation/devicetree/bindings/thermal/raspberrypi,bcm2835-thermal.txt
> +Raspberry Pi Broadcom BCM2835 thermal control
> +
> +Required properties:
This needs some more explanation of what this is intended to represent
and do. For example, what services is this node (the driver instantiated
by this node) expected to implement, and what firmware services is it
expected to rely upon?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-10-21 3:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-11 19:48 [PATCH] bcm2835: Add Raspberry Pi thermal sensor to the device tree Lubomir Rintel
[not found] ` <1444592937-16320-1-git-send-email-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2015-10-21 3:03 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56270074.90501@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org \
--cc=lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=lkundrak-NGH9Lh4a5iE@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).