From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Subject: Re: [PATCH] regulator, dt: add dt support for tps6502x regulator Date: Wed, 21 Oct 2015 14:52:51 +0200 Message-ID: <56278AA3.3060109@denx.de> References: <1445236033-27747-1-git-send-email-hs@denx.de> <20151021121925.GC8232@sirena.org.uk> Reply-To: hs-ynQEQJNshbs@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151021121925.GC8232-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Liam Girdwood List-Id: devicetree@vger.kernel.org Hello Mark, Am 21.10.2015 um 14:19 schrieb Mark Brown: > On Mon, Oct 19, 2015 at 08:27:13AM +0200, Heiko Schocher wrote: > >> --- /dev/null >> +++ b/arch/arm/boot/dts/tps65023.dtsi > > If this file is needed there is something broken, if this file is not > needed then it is just noise since everything in it needs to be > overridden by users anyway. Either way please remove it. Uh, I thought to do it like: arch/arm/boot/dts/tps65217.dtsi but, okay, removed. >> + vldo2_reg: regulator@4 { >> + reg = <4>; >> + regulator-compatible = "vldo2", "regulator-compatible"; > > Modern bindings no longer use regulator-compatible, they just use the > node name - please look at recently added bindings for examples. removed. Thanks for the review! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html