From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH v1 1/2] dt-bindings: Sync the dts to this document Date: Wed, 21 Oct 2015 23:45:13 +0800 Message-ID: <5627B309.9080309@gmail.com> References: <1445395380-5365-1-git-send-email-wxt@rock-chips.com> <1445395380-5365-2-git-send-email-wxt@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-pm-owner@vger.kernel.org To: Rob Herring Cc: Caesar Wang , Mark Rutland , "devicetree@vger.kernel.org" , Ian Campbell , Heiko Stuebner , Pawel Moll , "linux-pm@vger.kernel.org" , Dmitry Torokhov , Doug Anderson , "linux-kernel@vger.kernel.org" , Eduardo Valentin , linux-rockchip@lists.infradead.org, Kumar Gala , Zhang Rui , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org Hi Rob, =E5=9C=A8 2015=E5=B9=B410=E6=9C=8821=E6=97=A5 23:18, Rob Herring =E5=86= =99=E9=81=93: > On Tue, Oct 20, 2015 at 9:42 PM, Caesar Wang wro= te: >> Add the OTP gpio state, we need switch the pin to gpio state >> before the TSADC controller is reset. >> >> Signed-off-by: Caesar Wang >> --- >> >> Changes in v1: >> - As the Doug comments, add the 'init' property to sync document. >> >> Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 5= +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/thermal/rockchip-ther= mal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.tx= t >> index ef802de..28e84f7 100644 >> --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >> @@ -27,8 +27,9 @@ tsadc: tsadc@ff280000 { >> clock-names =3D "tsadc", "apb_pclk"; >> resets =3D <&cru SRST_TSADC>; >> reset-names =3D "tsadc-apb"; >> - pinctrl-names =3D "default"; >> - pinctrl-0 =3D <&otp_out>; >> + pinctrl-names =3D "init", "default"; >> + pinctrl-0 =3D <&otp_gpio>; >> + pinctrl-1 =3D <&otp_out>; > Are these optional or required? They only appear in the example. Yep, These are required for TSADC. I=E2=80=98m assumed that's right, I think we don't need to introduce the pinctrl in this document. > Rob > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip