From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 1/3] dt-bindings: Consolidate SRAM bindings from all vendors Date: Thu, 22 Oct 2015 18:19:31 +0900 Message-ID: <5628AA23.5070608@samsung.com> References: <1445477130-407-1-git-send-email-k.kozlowski@samsung.com> <20151022090529.GV10947@lukather> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20151022090529.GV10947@lukather> Sender: linux-kernel-owner@vger.kernel.org To: Maxime Ripard Cc: Kukjin Kim , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Javier Martinez Canillas , Heiko Stuebner , Chen-Yu Tsai List-Id: devicetree@vger.kernel.org On 22.10.2015 18:05, Maxime Ripard wrote: > Hi, > > On Thu, Oct 22, 2015 at 10:25:28AM +0900, Krzysztof Kozlowski wrote: >> SRAM bindings for various SoCs, using the mmio-sram genalloc >> API, are spread over different places - per SoC vendor. Since all of >> these are quite similar (they depend on mmio-sram) move them to a common >> place. >> >> Signed-off-by: Krzysztof Kozlowski >> Cc: Heiko Stuebner >> Cc: Maxime Ripard >> Cc: Chen-Yu Tsai >> Cc: Kukjin Kim >> Suggested-by: Rob Herring >> >> --- >> >> Changes since v1: >> 1. New patch. Extended suggestion from Rob. >> --- >> .../bindings/{arm/rockchip/pmu-sram.txt => sram/rockchip-pmu-sram.txt} | 0 >> .../bindings/{arm/rockchip/smp-sram.txt => sram/rockchip-smp-sram.txt} | 0 >> .../bindings/{arm/exynos/smp-sysram.txt => sram/samsung-sram.txt} | 0 >> Documentation/devicetree/bindings/{misc => sram}/sram.txt | 0 >> .../devicetree/bindings/{soc/sunxi/sram.txt => sram/sunxi-sram.txt} | 0 >> 5 files changed, 0 insertions(+), 0 deletions(-) >> rename Documentation/devicetree/bindings/{arm/rockchip/pmu-sram.txt => sram/rockchip-pmu-sram.txt} (100%) >> rename Documentation/devicetree/bindings/{arm/rockchip/smp-sram.txt => sram/rockchip-smp-sram.txt} (100%) >> rename Documentation/devicetree/bindings/{arm/exynos/smp-sysram.txt => sram/samsung-sram.txt} (100%) >> rename Documentation/devicetree/bindings/{misc => sram}/sram.txt (100%) >> rename Documentation/devicetree/bindings/{soc/sunxi/sram.txt => sram/sunxi-sram.txt} (100%) > > I'm not sure about that one. The SRAM bindins we have for sunxi is for > an SRAM controller, that maps the SRAM either to the CPU or to the > devices. > > It's not really related to the other users, and wouldn't it be > confusing to have a driver in drivers/soc, and a Documentation in > another sub-directory? I guess the only relation to other users is the "mmio-sram". In the same time this is still similar to e.g. Samsung's sram bindings (where the memory is mapped to CPU only). Being located in drivers/soc is not an issue here - code for other vendors may be moved there as well in the future. Of course I do not insist. Actually Rob's comment was only about moving sram.txt and Samsung's sram to common place. Anyway I will be sending v3 of these because while looking more carefully I found hard-coded paths to bindings/misc/sram.txt. I'll fix it in next version. Best regards, Krzysztof