From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Kuske Subject: Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Date: Thu, 22 Oct 2015 13:30:42 +0200 Message-ID: <5628C8E2.6040703@gmail.com> References: <1445444428-4652-1-git-send-email-jenskuske@gmail.com> <1445444428-4652-2-git-send-email-jenskuske@gmail.com> <20151022080508.GN10947@lukather> <20151022102959.09f0a1f4@OPI2> <20151022084735.GR10947@lukather> <20151022105745.2cc158a3@OPI2> <20151022091410.GW10947@lukather> Reply-To: jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20151022091410.GW10947@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: Jean-Francois Moine , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vishnu Patekar , =?UTF-8?Q?Emilio_L=c3=b3pez?= , Michael Turquette , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Hans de Goede , Chen-Yu Tsai , Rob Herring , Philipp Zabel , Linus Walleij , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 22/10/15 11:14, Maxime Ripard wrote: > On Thu, Oct 22, 2015 at 10:57:45AM +0200, Jean-Francois Moine wrote: >> On Thu, 22 Oct 2015 10:47:35 +0200 >> Maxime Ripard wrote: >> >>> Not really. The uart0 reset is the bit 16, in the reset register 4. >>> >>> 4 * 32 + 16 = 44. >>> >>> Not 112, but still not 208 either. >> >> The registers are numbered 1..5, then >> >> (4 - 1) * 32 + 16 = 112 > > Not on my version, and even then, UARTs are on the last reset > register, which would still make 144. > > Maxime > There are holes between reg2 and reg3 and reg4 for some reason, but even if we would correct that with some of_xlate() function they won't completely line up with the gates. Jens