* [PATCH] ARM: dts: am335x-boneblack: Use pinctrl constants
@ 2015-10-22 16:20 Andrew F. Davis
[not found] ` <1445530847-25217-1-git-send-email-afd-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Andrew F. Davis @ 2015-10-22 16:20 UTC (permalink / raw)
To: Benoît Cousson, Tony Lindgren
Cc: devicetree, linux-omap, linux-kernel, Andrew F. Davis
Using constants for pinctrl allows better readability and removes
redundancy with comments.
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
arch/arm/boot/dts/am335x-boneblack.dts | 44 +++++++++++++++++-----------------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts
index eadbba3..a540a10 100644
--- a/arch/arm/boot/dts/am335x-boneblack.dts
+++ b/arch/arm/boot/dts/am335x-boneblack.dts
@@ -36,32 +36,32 @@
&am33xx_pinmux {
nxp_hdmi_bonelt_pins: nxp_hdmi_bonelt_pins {
pinctrl-single,pins = <
- 0x1b0 0x03 /* xdma_event_intr0, OMAP_MUX_MODE3 | AM33XX_PIN_OUTPUT */
- 0xa0 0x08 /* lcd_data0.lcd_data0, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xa4 0x08 /* lcd_data1.lcd_data1, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xa8 0x08 /* lcd_data2.lcd_data2, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xac 0x08 /* lcd_data3.lcd_data3, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xb0 0x08 /* lcd_data4.lcd_data4, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xb4 0x08 /* lcd_data5.lcd_data5, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xb8 0x08 /* lcd_data6.lcd_data6, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xbc 0x08 /* lcd_data7.lcd_data7, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xc0 0x08 /* lcd_data8.lcd_data8, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xc4 0x08 /* lcd_data9.lcd_data9, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xc8 0x08 /* lcd_data10.lcd_data10, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xcc 0x08 /* lcd_data11.lcd_data11, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xd0 0x08 /* lcd_data12.lcd_data12, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xd4 0x08 /* lcd_data13.lcd_data13, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xd8 0x08 /* lcd_data14.lcd_data14, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xdc 0x08 /* lcd_data15.lcd_data15, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xe0 0x00 /* lcd_vsync.lcd_vsync, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */
- 0xe4 0x00 /* lcd_hsync.lcd_hsync, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */
- 0xe8 0x00 /* lcd_pclk.lcd_pclk, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */
- 0xec 0x00 /* lcd_ac_bias_en.lcd_ac_bias_en, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */
+ 0x1b0 (PIN_OUTPUT_PULLDOWN | MUX_MODE3) /* xdma_event_intr0 */
+ 0xa0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data0.lcd_data0 */
+ 0xa4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data1.lcd_data1 */
+ 0xa8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data2.lcd_data2 */
+ 0xac (PIN_OUTPUT | MUX_MODE0) /* lcd_data3.lcd_data3 */
+ 0xb0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data4.lcd_data4 */
+ 0xb4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data5.lcd_data5 */
+ 0xb8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data6.lcd_data6 */
+ 0xbc (PIN_OUTPUT | MUX_MODE0) /* lcd_data7.lcd_data7 */
+ 0xc0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data8.lcd_data8 */
+ 0xc4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data9.lcd_data9 */
+ 0xc8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data10.lcd_data10 */
+ 0xcc (PIN_OUTPUT | MUX_MODE0) /* lcd_data11.lcd_data11 */
+ 0xd0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data12.lcd_data12 */
+ 0xd4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data13.lcd_data13 */
+ 0xd8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data14.lcd_data14 */
+ 0xdc (PIN_OUTPUT | MUX_MODE0) /* lcd_data15.lcd_data15 */
+ 0xe0 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* lcd_vsync.lcd_vsync */
+ 0xe4 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* lcd_hsync.lcd_hsync */
+ 0xe8 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* lcd_pclk.lcd_pclk */
+ 0xec (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* lcd_ac_bias_en.lcd_ac_bias_en */
>;
};
nxp_hdmi_bonelt_off_pins: nxp_hdmi_bonelt_off_pins {
pinctrl-single,pins = <
- 0x1b0 0x03 /* xdma_event_intr0, OMAP_MUX_MODE3 | AM33XX_PIN_OUTPUT */
+ 0x1b0 (PIN_OUTPUT_PULLDOWN | MUX_MODE3) /* xdma_event_intr0 */
>;
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <1445530847-25217-1-git-send-email-afd-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH] ARM: dts: am335x-boneblack: Use pinctrl constants [not found] ` <1445530847-25217-1-git-send-email-afd-l0cyMroinI0@public.gmane.org> @ 2015-10-22 21:23 ` Tony Lindgren 2015-10-23 13:08 ` Andrew F. Davis 0 siblings, 1 reply; 6+ messages in thread From: Tony Lindgren @ 2015-10-22 21:23 UTC (permalink / raw) To: Andrew F. Davis Cc: Benoît Cousson, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA * Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org> [151022 09:21]: > Using constants for pinctrl allows better readability and removes > redundancy with comments. You should use the include/dt-bindings/pinctrl/omap.h macro AM33XX_IOPAD(pa, val) while at it. Otherwise we'll end up patching the same things again later on. Regards, Tony > Signed-off-by: Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org> > --- > arch/arm/boot/dts/am335x-boneblack.dts | 44 +++++++++++++++++----------------- > 1 file changed, 22 insertions(+), 22 deletions(-) > > diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts > index eadbba3..a540a10 100644 > --- a/arch/arm/boot/dts/am335x-boneblack.dts > +++ b/arch/arm/boot/dts/am335x-boneblack.dts > @@ -36,32 +36,32 @@ > &am33xx_pinmux { > nxp_hdmi_bonelt_pins: nxp_hdmi_bonelt_pins { > pinctrl-single,pins = < > - 0x1b0 0x03 /* xdma_event_intr0, OMAP_MUX_MODE3 | AM33XX_PIN_OUTPUT */ > - 0xa0 0x08 /* lcd_data0.lcd_data0, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xa4 0x08 /* lcd_data1.lcd_data1, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xa8 0x08 /* lcd_data2.lcd_data2, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xac 0x08 /* lcd_data3.lcd_data3, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xb0 0x08 /* lcd_data4.lcd_data4, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xb4 0x08 /* lcd_data5.lcd_data5, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xb8 0x08 /* lcd_data6.lcd_data6, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xbc 0x08 /* lcd_data7.lcd_data7, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xc0 0x08 /* lcd_data8.lcd_data8, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xc4 0x08 /* lcd_data9.lcd_data9, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xc8 0x08 /* lcd_data10.lcd_data10, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xcc 0x08 /* lcd_data11.lcd_data11, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xd0 0x08 /* lcd_data12.lcd_data12, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xd4 0x08 /* lcd_data13.lcd_data13, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xd8 0x08 /* lcd_data14.lcd_data14, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xdc 0x08 /* lcd_data15.lcd_data15, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ > - 0xe0 0x00 /* lcd_vsync.lcd_vsync, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */ > - 0xe4 0x00 /* lcd_hsync.lcd_hsync, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */ > - 0xe8 0x00 /* lcd_pclk.lcd_pclk, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */ > - 0xec 0x00 /* lcd_ac_bias_en.lcd_ac_bias_en, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */ > + 0x1b0 (PIN_OUTPUT_PULLDOWN | MUX_MODE3) /* xdma_event_intr0 */ > + 0xa0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data0.lcd_data0 */ > + 0xa4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data1.lcd_data1 */ > + 0xa8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data2.lcd_data2 */ > + 0xac (PIN_OUTPUT | MUX_MODE0) /* lcd_data3.lcd_data3 */ > + 0xb0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data4.lcd_data4 */ > + 0xb4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data5.lcd_data5 */ > + 0xb8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data6.lcd_data6 */ > + 0xbc (PIN_OUTPUT | MUX_MODE0) /* lcd_data7.lcd_data7 */ > + 0xc0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data8.lcd_data8 */ > + 0xc4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data9.lcd_data9 */ > + 0xc8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data10.lcd_data10 */ > + 0xcc (PIN_OUTPUT | MUX_MODE0) /* lcd_data11.lcd_data11 */ > + 0xd0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data12.lcd_data12 */ > + 0xd4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data13.lcd_data13 */ > + 0xd8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data14.lcd_data14 */ > + 0xdc (PIN_OUTPUT | MUX_MODE0) /* lcd_data15.lcd_data15 */ > + 0xe0 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* lcd_vsync.lcd_vsync */ > + 0xe4 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* lcd_hsync.lcd_hsync */ > + 0xe8 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* lcd_pclk.lcd_pclk */ > + 0xec (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* lcd_ac_bias_en.lcd_ac_bias_en */ > >; > }; > nxp_hdmi_bonelt_off_pins: nxp_hdmi_bonelt_off_pins { > pinctrl-single,pins = < > - 0x1b0 0x03 /* xdma_event_intr0, OMAP_MUX_MODE3 | AM33XX_PIN_OUTPUT */ > + 0x1b0 (PIN_OUTPUT_PULLDOWN | MUX_MODE3) /* xdma_event_intr0 */ > >; > }; > }; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: am335x-boneblack: Use pinctrl constants 2015-10-22 21:23 ` Tony Lindgren @ 2015-10-23 13:08 ` Andrew F. Davis 2015-10-23 14:29 ` Javier Martinez Canillas 0 siblings, 1 reply; 6+ messages in thread From: Andrew F. Davis @ 2015-10-23 13:08 UTC (permalink / raw) To: Tony Lindgren; +Cc: Benoît Cousson, devicetree, linux-omap, linux-kernel On 10/22/2015 04:23 PM, Tony Lindgren wrote: > * Andrew F. Davis <afd@ti.com> [151022 09:21]: >> Using constants for pinctrl allows better readability and removes >> redundancy with comments. > > You should use the include/dt-bindings/pinctrl/omap.h macro > AM33XX_IOPAD(pa, val) while at it. Otherwise we'll end up patching > the same things again later on. > Hmm, I haven't really been following this change, it kind of seems to add some unnecessary abstraction by using physical hardware addresses instead of offsets, then just converting them back to offsets. The offset style DT nodes are already auto-generated with existing tools anyway: https://dev.ti.com/pinmux I'm sure this has been discussed already so if this is a blocker I'll re-spin this. Andrew > Regards, > > Tony > >> Signed-off-by: Andrew F. Davis <afd@ti.com> >> --- >> arch/arm/boot/dts/am335x-boneblack.dts | 44 +++++++++++++++++----------------- >> 1 file changed, 22 insertions(+), 22 deletions(-) >> >> diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts >> index eadbba3..a540a10 100644 >> --- a/arch/arm/boot/dts/am335x-boneblack.dts >> +++ b/arch/arm/boot/dts/am335x-boneblack.dts >> @@ -36,32 +36,32 @@ >> &am33xx_pinmux { >> nxp_hdmi_bonelt_pins: nxp_hdmi_bonelt_pins { >> pinctrl-single,pins = < >> - 0x1b0 0x03 /* xdma_event_intr0, OMAP_MUX_MODE3 | AM33XX_PIN_OUTPUT */ >> - 0xa0 0x08 /* lcd_data0.lcd_data0, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xa4 0x08 /* lcd_data1.lcd_data1, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xa8 0x08 /* lcd_data2.lcd_data2, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xac 0x08 /* lcd_data3.lcd_data3, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xb0 0x08 /* lcd_data4.lcd_data4, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xb4 0x08 /* lcd_data5.lcd_data5, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xb8 0x08 /* lcd_data6.lcd_data6, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xbc 0x08 /* lcd_data7.lcd_data7, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xc0 0x08 /* lcd_data8.lcd_data8, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xc4 0x08 /* lcd_data9.lcd_data9, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xc8 0x08 /* lcd_data10.lcd_data10, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xcc 0x08 /* lcd_data11.lcd_data11, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xd0 0x08 /* lcd_data12.lcd_data12, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xd4 0x08 /* lcd_data13.lcd_data13, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xd8 0x08 /* lcd_data14.lcd_data14, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xdc 0x08 /* lcd_data15.lcd_data15, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */ >> - 0xe0 0x00 /* lcd_vsync.lcd_vsync, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */ >> - 0xe4 0x00 /* lcd_hsync.lcd_hsync, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */ >> - 0xe8 0x00 /* lcd_pclk.lcd_pclk, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */ >> - 0xec 0x00 /* lcd_ac_bias_en.lcd_ac_bias_en, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */ >> + 0x1b0 (PIN_OUTPUT_PULLDOWN | MUX_MODE3) /* xdma_event_intr0 */ >> + 0xa0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data0.lcd_data0 */ >> + 0xa4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data1.lcd_data1 */ >> + 0xa8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data2.lcd_data2 */ >> + 0xac (PIN_OUTPUT | MUX_MODE0) /* lcd_data3.lcd_data3 */ >> + 0xb0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data4.lcd_data4 */ >> + 0xb4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data5.lcd_data5 */ >> + 0xb8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data6.lcd_data6 */ >> + 0xbc (PIN_OUTPUT | MUX_MODE0) /* lcd_data7.lcd_data7 */ >> + 0xc0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data8.lcd_data8 */ >> + 0xc4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data9.lcd_data9 */ >> + 0xc8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data10.lcd_data10 */ >> + 0xcc (PIN_OUTPUT | MUX_MODE0) /* lcd_data11.lcd_data11 */ >> + 0xd0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data12.lcd_data12 */ >> + 0xd4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data13.lcd_data13 */ >> + 0xd8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data14.lcd_data14 */ >> + 0xdc (PIN_OUTPUT | MUX_MODE0) /* lcd_data15.lcd_data15 */ >> + 0xe0 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* lcd_vsync.lcd_vsync */ >> + 0xe4 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* lcd_hsync.lcd_hsync */ >> + 0xe8 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* lcd_pclk.lcd_pclk */ >> + 0xec (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* lcd_ac_bias_en.lcd_ac_bias_en */ >> >; >> }; >> nxp_hdmi_bonelt_off_pins: nxp_hdmi_bonelt_off_pins { >> pinctrl-single,pins = < >> - 0x1b0 0x03 /* xdma_event_intr0, OMAP_MUX_MODE3 | AM33XX_PIN_OUTPUT */ >> + 0x1b0 (PIN_OUTPUT_PULLDOWN | MUX_MODE3) /* xdma_event_intr0 */ >> >; >> }; >> }; >> -- >> 1.9.1 >> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: am335x-boneblack: Use pinctrl constants 2015-10-23 13:08 ` Andrew F. Davis @ 2015-10-23 14:29 ` Javier Martinez Canillas 2015-10-23 14:36 ` Andrew F. Davis 0 siblings, 1 reply; 6+ messages in thread From: Javier Martinez Canillas @ 2015-10-23 14:29 UTC (permalink / raw) To: Andrew F. Davis Cc: Tony Lindgren, Benoît Cousson, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, Linux Kernel Hello Andrew, On Fri, Oct 23, 2015 at 3:08 PM, Andrew F. Davis <afd@ti.com> wrote: > On 10/22/2015 04:23 PM, Tony Lindgren wrote: >> >> * Andrew F. Davis <afd@ti.com> [151022 09:21]: >>> >>> Using constants for pinctrl allows better readability and removes >>> redundancy with comments. >> >> >> You should use the include/dt-bindings/pinctrl/omap.h macro >> AM33XX_IOPAD(pa, val) while at it. Otherwise we'll end up patching >> the same things again later on. >> > > Hmm, I haven't really been following this change, it kind of seems to add > some unnecessary abstraction by using physical hardware addresses instead > of offsets, then just converting them back to offsets. The offset style DT > nodes are already auto-generated with existing tools anyway: > https://dev.ti.com/pinmux > > I'm sure this has been discussed already so if this is a blocker I'll > re-spin this. > The good thing about the IOPAD pinmux macros is that matches what is in the TRM so it is easier to read the DTS and verify that is correct. I've on my queue to migrate all the remaining DTS for TI SoCs to use the IOPAD macros but is just that I didn't have time to do it this week. Probably I'll do it at the end of the next week. > Andrew > > >> Regards, >> Best regards, Javier ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: am335x-boneblack: Use pinctrl constants 2015-10-23 14:29 ` Javier Martinez Canillas @ 2015-10-23 14:36 ` Andrew F. Davis [not found] ` <562A45DC.1090501-l0cyMroinI0@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Andrew F. Davis @ 2015-10-23 14:36 UTC (permalink / raw) To: Javier Martinez Canillas Cc: Tony Lindgren, Benoît Cousson, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, Linux Kernel On 10/23/2015 09:29 AM, Javier Martinez Canillas wrote: > Hello Andrew, > > On Fri, Oct 23, 2015 at 3:08 PM, Andrew F. Davis <afd@ti.com> wrote: >> On 10/22/2015 04:23 PM, Tony Lindgren wrote: >>> >>> * Andrew F. Davis <afd@ti.com> [151022 09:21]: >>>> >>>> Using constants for pinctrl allows better readability and removes >>>> redundancy with comments. >>> >>> >>> You should use the include/dt-bindings/pinctrl/omap.h macro >>> AM33XX_IOPAD(pa, val) while at it. Otherwise we'll end up patching >>> the same things again later on. >>> >> >> Hmm, I haven't really been following this change, it kind of seems to add >> some unnecessary abstraction by using physical hardware addresses instead >> of offsets, then just converting them back to offsets. The offset style DT >> nodes are already auto-generated with existing tools anyway: >> https://dev.ti.com/pinmux >> >> I'm sure this has been discussed already so if this is a blocker I'll >> re-spin this. >> > > The good thing about the IOPAD pinmux macros is that matches what is > in the TRM so it is easier to read the DTS and verify that is correct. > > I've on my queue to migrate all the remaining DTS for TI SoCs to use > the IOPAD macros but is just that I didn't have time to do it this > week. Probably I'll do it at the end of the next week. > Then this patch can probably be dropped, hopefully the converted constants in this patch can be of some help for you though. Andrew >> Andrew >> >> >>> Regards, >>> > > Best regards, > Javier > ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <562A45DC.1090501-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH] ARM: dts: am335x-boneblack: Use pinctrl constants [not found] ` <562A45DC.1090501-l0cyMroinI0@public.gmane.org> @ 2015-10-23 14:47 ` Javier Martinez Canillas 0 siblings, 0 replies; 6+ messages in thread From: Javier Martinez Canillas @ 2015-10-23 14:47 UTC (permalink / raw) To: Andrew F. Davis Cc: Tony Lindgren, Benoît Cousson, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Kernel Hello Andrew, On Fri, Oct 23, 2015 at 4:36 PM, Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org> wrote: > On 10/23/2015 09:29 AM, Javier Martinez Canillas wrote: >> >> Hello Andrew, >> >> On Fri, Oct 23, 2015 at 3:08 PM, Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org> wrote: >>> >>> On 10/22/2015 04:23 PM, Tony Lindgren wrote: >>>> >>>> >>>> * Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org> [151022 09:21]: >>>>> >>>>> >>>>> Using constants for pinctrl allows better readability and removes >>>>> redundancy with comments. >>>> >>>> >>>> >>>> You should use the include/dt-bindings/pinctrl/omap.h macro >>>> AM33XX_IOPAD(pa, val) while at it. Otherwise we'll end up patching >>>> the same things again later on. >>>> >>> >>> Hmm, I haven't really been following this change, it kind of seems to add >>> some unnecessary abstraction by using physical hardware addresses instead >>> of offsets, then just converting them back to offsets. The offset style >>> DT >>> nodes are already auto-generated with existing tools anyway: >>> https://dev.ti.com/pinmux >>> >>> I'm sure this has been discussed already so if this is a blocker I'll >>> re-spin this. >>> >> >> The good thing about the IOPAD pinmux macros is that matches what is >> in the TRM so it is easier to read the DTS and verify that is correct. >> >> I've on my queue to migrate all the remaining DTS for TI SoCs to use >> the IOPAD macros but is just that I didn't have time to do it this >> week. Probably I'll do it at the end of the next week. >> > > Then this patch can probably be dropped, hopefully the converted constants > in this patch can be of some help for you though. > Yes they are but feel free to re-spin your patch if you wish, it will be one less DTS to convert :-) But yes, if you don't then I'll do it when changing all DTS. > Andrew > > Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-23 14:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-22 16:20 [PATCH] ARM: dts: am335x-boneblack: Use pinctrl constants Andrew F. Davis
[not found] ` <1445530847-25217-1-git-send-email-afd-l0cyMroinI0@public.gmane.org>
2015-10-22 21:23 ` Tony Lindgren
2015-10-23 13:08 ` Andrew F. Davis
2015-10-23 14:29 ` Javier Martinez Canillas
2015-10-23 14:36 ` Andrew F. Davis
[not found] ` <562A45DC.1090501-l0cyMroinI0@public.gmane.org>
2015-10-23 14:47 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).