From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH 0/3] ARM: dts: Enable Exynos RNG module
Date: Sun, 25 Oct 2015 01:58:15 +0200 [thread overview]
Message-ID: <562C1B17.3080303@math.uni-bielefeld.de> (raw)
In-Reply-To: <562581BD.3070609@samsung.com>
Hello Krzysztof,
Krzysztof Kozlowski wrote:
> On 20.10.2015 01:11, Tobias Jakobi wrote:
>> Hello Krzysztof,
>>
>> I can confirm that this also works on a Odroid-X2, so I guess it's safe
>> to enable the PRNG for all Exynos4412-based Odroid devices.
>
> Sure, I can send a patch for that. I can test it later also on Odroid-U3.
Thanks already!
>> Any chance that you might also take a look at the other hwcrypto stuff
>> on the SoC ('samsung,exynos4210-secss' compatible)?
>
> What do you mean? The s5p-sss driver already supports Device Tree.
The driver supports DT, but it doesn't really work.
I'm using the following DT entry to let the driver probe correctly:
https://github.com/tobiasjakobi/linux-odroid/commit/82c00cddb5cbf89fad994784c28c8125beae8e13
But the crypto self-test fails on boot:
alg: skcipher: encryption failed on test 1 for ecb-aes-s5p: ret=22
Another problems is that SSS and PRNG can't be used at the same time,
since they both use common hardware resources (I think it was IO).
With best wishes,
Tobias
> Best regards,
> Krzysztof
>
>>
>> With best wishes,
>> Tobias
>>
>>
>> Krzysztof Kozlowski wrote:
>>> Hi,
>>>
>>>
>>> The patchset adds necessary clock from Security SubSystem (SSS)
>>> and enables the PRNG module of Exynos for Trats2 board.
>>>
>>> The first patch (clock) is required for other ones so please
>>> take everything in one step.
>>>
>>> The actual Device Tree support (and compatible) was sent in separate
>>> patch:
>>> - https://patchwork.kernel.org/patch/7432891/
>>> - http://marc.info/?l=linux-crypto-vger&m=144522952725052&w=2
>>>
>>> The device can be tested (after applying both patchsets) with:
>>> $ echo exynos > /sys/class/misc/hw_random/rng_current
>>> $ dd if=/dev/hwrng of=/dev/null bs=1 count=16
>>>
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>> Krzysztof Kozlowski (3):
>>> clk: samsung: exynos4: Add SSS gate clock
>>> ARM: dts: Add PRNG module for exynos4
>>> ARM: dts: Enable PRNG module on exynos4412-trats2
>>>
>>> arch/arm/boot/dts/exynos4.dtsi | 8 ++++++++
>>> arch/arm/boot/dts/exynos4412-trats2.dts | 4 ++++
>>> drivers/clk/samsung/clk-exynos4.c | 1 +
>>> include/dt-bindings/clock/exynos4.h | 1 +
>>> 4 files changed, 14 insertions(+)
>>>
>>
>>
>
next prev parent reply other threads:[~2015-10-24 23:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 5:00 [PATCH 0/3] ARM: dts: Enable Exynos RNG module Krzysztof Kozlowski
2015-10-19 5:00 ` [PATCH 1/3] clk: samsung: exynos4: Add SSS gate clock Krzysztof Kozlowski
2015-10-19 19:59 ` Stephen Boyd
2015-10-19 23:51 ` Krzysztof Kozlowski
2015-10-19 5:00 ` [PATCH 2/3] ARM: dts: Add PRNG module for exynos4 Krzysztof Kozlowski
2015-10-19 5:00 ` [PATCH 3/3] ARM: dts: Enable PRNG module on exynos4412-trats2 Krzysztof Kozlowski
2015-10-19 16:11 ` [PATCH 0/3] ARM: dts: Enable Exynos RNG module Tobias Jakobi
2015-10-19 23:50 ` Krzysztof Kozlowski
2015-10-24 23:58 ` Tobias Jakobi [this message]
2015-10-29 6:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562C1B17.3080303@math.uni-bielefeld.de \
--to=tjakobi@math.uni-bielefeld.de \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=hkallweit1@gmail.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).