From: Jonathan Cameron <jic23@kernel.org>
To: Michael Welling <mwelling@ieee.org>,
Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org,
"Andrea Galbusera" <gizero@gmail.com>,
devicetree@vger.kernel.org, "Kumar Gala" <galak@codeaurora.org>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Søren Andersen" <san@rosetechnology.dk>
Subject: Re: [PATCH 1/2] iio: adc: mcp320x: Deprecated compatible strings with no vendor prefix
Date: Sun, 25 Oct 2015 12:36:37 +0000 [thread overview]
Message-ID: <562CCCD5.4030307@kernel.org> (raw)
In-Reply-To: <20151014152726.GA29846@deathstar>
On 14/10/15 16:27, Michael Welling wrote:
> On Wed, Oct 14, 2015 at 02:54:38PM +0200, Javier Martinez Canillas wrote:
>> The Microchip Analog to Digital Converter (ADC) Device Tree binding
>> documents compatible strings with no vendor prefix. Since it should
>> compatible strings with also a vendor, add these to the binding doc
>> and mark the old ones as deprecated.
>>
>> The driver says that the device is from Microchip Technology which
>> is listed in Documentation/devicetree/bindings/vendor-prefixes.txt
>> so use the documented prefix.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>
>> .../devicetree/bindings/iio/adc/mcp320x.txt | 30 +++++++++++++++-------
>> 1 file changed, 21 insertions(+), 9 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/mcp320x.txt b/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
>> index 2a1f3af30155..bcd3ac8e6e0c 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
>> +++ b/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
>> @@ -10,16 +10,28 @@ must be specified.
>> Required properties:
>> - compatible: Must be one of the following, depending on the
>> model:
>> - "mcp3001"
>> - "mcp3002"
>> - "mcp3004"
>> - "mcp3008"
>> - "mcp3201"
>> - "mcp3202"
>> - "mcp3204"
>> - "mcp3208"
>> - "mcp3301"
>> + "mcp3001" (DEPRECATED)
>> + "mcp3002" (DEPRECATED)
>> + "mcp3004" (DEPRECATED)
>> + "mcp3008" (DEPRECATED)
>> + "mcp3201" (DEPRECATED)
>> + "mcp3202" (DEPRECATED)
>> + "mcp3204" (DEPRECATED)
>> + "mcp3208" (DEPRECATED)
>> + "mcp3301" (DEPRECATED)
>>
>> + "microchip,mcp3001"
>> + "microchip,mcp3002"
>> + "microchip,mcp3004"
>> + "microchip,mcp3008"
>> + "microchip,mcp3201"
>> + "microchip,mcp3202"
>> + "microchip,mcp3204"
>> + "microchip,mcp3208"
>> + "microchip,mcp3301"
>> +
>> + NOTE: The use of the compatibles with no vendor prefix
>> + is deprecated and only listed because old DT use them.
>>
>
> Acked-by: Michael Welling <mwelling@ieee.org>
Small point, Michael. Please add such acks below the the Author sign off.
Otherwise sometimes I miss them! Added it now for this one.
>
>> Examples:
>> spi_controller {
>> --
>> 2.4.3
>>
next prev parent reply other threads:[~2015-10-25 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 12:54 [PATCH 0/2] iio: adc: mcp320x: Add compatible with vendor prefix and deprecate old ones Javier Martinez Canillas
2015-10-14 12:54 ` [PATCH 1/2] iio: adc: mcp320x: Deprecated compatible strings with no vendor prefix Javier Martinez Canillas
[not found] ` <1444827279-23163-2-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-10-14 15:27 ` Michael Welling
2015-10-25 12:36 ` Jonathan Cameron [this message]
2015-10-25 19:34 ` Michael Welling
2015-10-25 12:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562CCCD5.4030307@kernel.org \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gizero@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mwelling@ieee.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=san@rosetechnology.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).