From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH 1/3] dt-bindings: add document of mediatek efuse driver Date: Mon, 26 Oct 2015 10:55:20 +0000 Message-ID: <562E0698.1000503@linaro.org> References: <1444984751-4572-1-git-send-email-andrew-ct.chen@mediatek.com> <1444984751-4572-2-git-send-email-andrew-ct.chen@mediatek.com> <562DF8BE.4060205@linaro.org> <20151026102344.GD25308@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20151026102344.GD25308-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sascha Hauer Cc: andrew-ct.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Maxime Ripard , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Matthias Brugger , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org On 26/10/15 10:23, Sascha Hauer wrote: > On Mon, Oct 26, 2015 at 09:56:14AM +0000, Srinivas Kandagatla wrote: >> >> >> On 16/10/15 09:39, andrew-ct.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote: >>> From: Andrew-CT Chen >>> >>> Add Mediatek MT8173 EFUSE Devicetree binding file >>> >>> Signed-off-by: Andrew-CT Chen >> >> Looks good to me, minor comment below. >> >> Will queue this for v4.5 once v4.4-rc1 is released. >> >> >>> --- >>> .../devicetree/bindings/nvmem/mtk-efuse.txt | 36 +++++++++= +++++++++++++ >>> 1 file changed, 36 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/nvmem/mtk-ef= use.txt >>> >>> diff --git a/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt = b/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt >>> new file mode 100644 >>> index 0000000..92edc3d >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt >>> @@ -0,0 +1,36 @@ >>> +=3D Mediatek MTK-EFUSE device tree bindings =3D >>> + >>> +This binding is intended to represent MTK-EFUSE which is found in = most Mediatek SOCs. >>> + >>> +Required properties: >>> +- compatible: should be "mediatek,mt8173-efuse" or "mediatek,mt813= 5-efuse" >> >> Can we make the compatible more generic for mediatek socs? Like >> "mediatek,efuse" Or are they different in each SOC? > > While we can add an additional "mediatek,efuse" compatible we should > always add the most specific compatible first. Otherwise we cannot > differentiate between SoCs later without changing the device tree. Yes, that=92s correct. AFAIK, Ideally the driver should have more generic compatible string=20 unless there is any SOC specific thing, and DT can still use the order=20 of specific, generic compatible strings. If not we would end up adding=20 compatible strings into the driver for every new SOC. --srini > > Sascha > -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html