From: Heiko Schocher <hs@denx.de>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v3] regulator, dt: add dt support for tps6502x regulator
Date: Tue, 27 Oct 2015 07:23:09 +0100 [thread overview]
Message-ID: <562F184D.8000907@denx.de> (raw)
In-Reply-To: <20151027021250.GR28319@sirena.org.uk>
Hello Mark,
Am 27.10.2015 um 03:12 schrieb Mark Brown:
> On Mon, Oct 26, 2015 at 12:25:17PM +0100, Heiko Schocher wrote:
>> add DT support for the tps6502x regulators.
>
> Please use subject lines matching the style for the subsystem.
Would be "regulator: tps6520x:" correct?
>> + regulators = of_get_child_by_name(np, "regulators");
>> + if (!regulators) {
>> + dev_err(dev, "regulator node not found\n");
>> + return NULL;
>> + }
>
> Please use the generic support for locating the DT information for
> regulators using regulators_node and of_match in the regulator_desc
> rather than open coding this.
Hmm.. could you point me to a correct example? Seems I overlook sth.
drivers/regulator/tps65090-regulator.c
drivers/regulator/tps65910-regulator.c
drivers/regulator/tps6507x-regulator.c
drivers/regulator/tps6586x-regulator.c
are doing it all the same way ...
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2015-10-27 6:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 11:25 [PATCH v3] regulator, dt: add dt support for tps6502x regulator Heiko Schocher
2015-10-27 2:12 ` Mark Brown
2015-10-27 6:23 ` Heiko Schocher [this message]
[not found] ` <562F184D.8000907-ynQEQJNshbs@public.gmane.org>
2015-10-27 7:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F184D.8000907@denx.de \
--to=hs@denx.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).