From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Andrew F. Davis" Subject: Re: [PATCH v4 4/5] regulator: tps65912: Add regulator driver for the TPS65912 PMIC Date: Tue, 27 Oct 2015 09:23:19 -0500 Message-ID: <562F88D7.6030505@ti.com> References: <1443731874-21362-1-git-send-email-afd@ti.com> <1443731874-21362-5-git-send-email-afd@ti.com> <20151022164724.GZ8232@sirena.org.uk> <562A2C2F.1020808@ti.com> <20151023231822.GQ29919@sirena.org.uk> <562ACCCC.503@ti.com> <20151024221457.GS29919@sirena.org.uk> <562D3F77.5040205@ti.com> <20151026004320.GU29919@sirena.org.uk> <562E4B1D.4060205@ti.com> <20151027001608.GJ28319@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151027001608.GJ28319-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Lee Jones , Alexandre Courbot , Grygorii Strashko , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 10/26/2015 07:16 PM, Mark Brown wrote: > On Mon, Oct 26, 2015 at 10:47:41AM -0500, Andrew F. Davis wrote: >> On 10/25/2015 07:43 PM, Mark Brown wrote: > >>>> .of_compatible = "mediatek,mt6397-regulator", > >>> This is in the MFD, this is not used in actual systems. > >> Not sure what you mean by "actual systems", it looks like these >> use it?: > >> arch/arm/boot/dts/mt8135-evbp1.dts >> arch/arm64/boot/dts/mediatek/mt8173-evb.dts > > To repeat: the regulator driver does not register a compatible string > for the device for device model probing. > >> I understand this, I thought we are talking about compatible strings in >> the regulator sub-node, not how the core instantiates the sub-driver. > > No, this exactly about how the device model devices are instantiated. > Ahh, I see, this makes more sense then, I'll re-spin this matching on platform name. Apologies about all this noise. :) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html