From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAB80C38145 for ; Wed, 7 Sep 2022 12:22:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229747AbiIGMWM (ORCPT ); Wed, 7 Sep 2022 08:22:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229714AbiIGMWL (ORCPT ); Wed, 7 Sep 2022 08:22:11 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA5E6AB417 for ; Wed, 7 Sep 2022 05:22:09 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id f11so8133475lfa.6 for ; Wed, 07 Sep 2022 05:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=+WkJBmsyH1vsBqkEXP+qbFWoUijLTNIoydGFYIhgXJI=; b=CfkxBrTwWAK8tTr73FjBvDdxCOCy499JJMLu90hQ/cxz+G1eMjnyHSXykAey6okcEU xsUzc356u8kqsid+5qlbMB2e69cPc0L5hsVyOjVRdVDG16B1tUWazIZDVUt2KTjJzUWp vdcPGSDBr2gqdoE+5E4q6wMyE4IbkbvEofVR5gBxwIGluvC23HoQx23wqJKgo9XDEqL+ YdQTyxEnny4IONKqEtddIkriNQbAG/8LidAD0rjL9DToYJMsM98xT+/hN76aDqeV+VFU mS+PrGCOI3g/0lhFNmVFcEbikR1tcpyt1gAKBvCTMTF0YoJ6AWkbDPuluRBQXobX/dzj GHxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=+WkJBmsyH1vsBqkEXP+qbFWoUijLTNIoydGFYIhgXJI=; b=L6SAS5RvCrYQ+rvlQtMqBgt/HNYgUbE3UzjY7iTR0y53CsO3g66vafhpzD8e/YPRxc ermHV9kO3jFIQTKT92bsPcRnh+dg9NeVGqv6gz1765CDyRy+wK2hLYyUG72l0DBYyaNA 2AJoaYITZyw4PUQKBL4fsxYsXPYJ/OHFVXILWNqlnVaS6nTWZwTV8mDO4LR2axDf7+Td yA/XQBVV9NvfBnj3BZCGXOAZl/3+sOaOqHZvDFTFPJsHXVmpOIR6oinVRAA+Wh8Par5h kkK0Hx8cQvAfm4DrPVps3DNQcMtWgCA4hfS8lcpk/gh0+hbj6ila9BTXckLOJSrWS4C/ 8hAg== X-Gm-Message-State: ACgBeo3bCrZmSsVPgf7qpdLUcXk1sv0SzT7NK+yxiNFzs0a0NWqrMmcs qLIDHj4I+tuCTxpcVocxj9fKJg== X-Google-Smtp-Source: AA6agR6JoL1nZuFPzHt37TZNIcdOdWFyxLpGOtAmPbV/or30uevMdL/iW8HwmWCC7w6CRktHeU8WHg== X-Received: by 2002:a05:6512:b0d:b0:492:d661:b368 with SMTP id w13-20020a0565120b0d00b00492d661b368mr985485lfu.466.1662553328032; Wed, 07 Sep 2022 05:22:08 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v8-20020a056512348800b0048b256bb005sm2462006lfr.49.2022.09.07.05.22.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Sep 2022 05:22:07 -0700 (PDT) Message-ID: <5630d0e7-bdfb-36f4-6cd8-9ca986bb2a11@linaro.org> Date: Wed, 7 Sep 2022 14:22:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v3 2/3] dt-bindings: pci: QCOM Add missing sc7280 aggre0, aggre1 clocks Content-Language: en-US To: Krishna chaitanya chundru , helgaas@kernel.org Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, mka@chromium.org, quic_vbadigan@quicinc.com, quic_hemantk@quicinc.com, quic_nitegupt@quicinc.com, quic_skananth@quicinc.com, quic_ramkri@quicinc.com, manivannan.sadhasivam@linaro.org, swboyd@chromium.org, dmitry.baryshkov@linaro.org, Andy Gross , Bjorn Andersson , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Stanimir Varbanov , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <1662171184-25211-1-git-send-email-quic_krichai@quicinc.com> <1662171184-25211-3-git-send-email-quic_krichai@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <1662171184-25211-3-git-send-email-quic_krichai@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/09/2022 04:13, Krishna chaitanya chundru wrote: > Add missing aggre0 and aggre1 clocks. > > Signed-off-by: Krishna chaitanya chundru > --- > changes since v2: > - Increase the max items of clock's in common properties. > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 0b69b12..b759465 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -53,11 +53,11 @@ properties: > # Platform constraints are described later. > clocks: > minItems: 3 > - maxItems: 12 > + maxItems: 13 > > clock-names: > minItems: 3 > - maxItems: 12 > + maxItems: 13 > > resets: > minItems: 1 > @@ -423,8 +423,8 @@ allOf: > then: > properties: > clocks: > - minItems: 11 > - maxItems: 11 > + minItems: 13 > + maxItems: 13 > clock-names: > items: > - const: pipe # PIPE clock > @@ -437,6 +437,8 @@ allOf: > - const: bus_slave # Slave AXI clock > - const: slave_q2a # Slave Q2A clock > - const: tbu # PCIe TBU clock > + - const: aggre0 # Aggre NoC PCIe CENTER SF AXI clock > + - const: aggre1 # Aggre NoC PCIe1 AXI clock > - const: ddrss_sf_tbu # PCIe SF TBU clock Why adding them in the middle, not at the end of list? It does not match other variants and affects the DTB ABI (order is strict). Best regards, Krzysztof