From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
'Kukjin Kim' <kgene@kernel.org>,
'Pankaj Dubey' <pankaj.dubey@samsung.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/4] Documentation: dt-bindings: Describe SROMc configuration
Date: Fri, 30 Oct 2015 15:09:28 +0900 [thread overview]
Message-ID: <56330998.5060706@samsung.com> (raw)
In-Reply-To: <003c01d1123f$002a3220$007e9660$@samsung.com>
On 29.10.2015 20:43, Pavel Fedin wrote:
> Hello!
>
>>>> Any vendor prefix here? How generic is this?
>>>
>>> I just don't know... Does *everything* really need a vendor prefix? How readable would that
>> be? "compatible" property already says
>>> that it's samsung-exynos-specific. And IMHO it's quite obvious that properties of vendor-
>> specific device are automatically
>>> vendor-specific.
>>> Ok, i am currently fixing up the rest and will post v4 soon, and will Cc: it to devicetree
>> ML.
>>
>> Which my reply you are referring to? You stripped part of some
>> sentence and put it without *any context*. Just random sentence.
>> I asked for vendor prefix in few places... srom-timing? width? And I
>> do not remember where I used exactly these words.
>
> Ok, sorry, i promise to improve. :)
> Anyway, i have figured out how to add sub-devices, and heavily modified the whole thing. And indeed, vendor prefix is now very useful, so i added it to all three properties. Making v4...
Actually now I found:
Documentation/devicetree/bindings/net/gpmc-eth.txt
Aren't you duplicating this work? This looks very, very similar.
Best regards,
Krzysztof
prev parent reply other threads:[~2015-10-30 6:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1446018918.git.p.fedin@samsung.com>
[not found] ` <046d990092dc85cf50db9082fc894d93a3ece7c0.1446018918.git.p.fedin@samsung.com>
2015-10-29 2:27 ` [PATCH v3 1/4] Documentation: dt-bindings: Describe SROMc configuration Krzysztof Kozlowski
2015-10-29 7:45 ` Pavel Fedin
2015-10-29 10:29 ` Krzysztof Kozlowski
2015-10-29 11:43 ` Pavel Fedin
2015-10-30 6:09 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56330998.5060706@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=p.fedin@samsung.com \
--cc=pankaj.dubey@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).