devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: sun7i: Enable audio codec on pcDuino
@ 2015-11-03 15:47 Hans de Goede
  2015-11-04  2:43 ` Stefan Monnier
       [not found] ` <1446565640-21069-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  0 siblings, 2 replies; 4+ messages in thread
From: Hans de Goede @ 2015-11-03 15:47 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Jelle van der Waa,
	Hans de Goede

From: Jelle van der Waa <jelle-oJJ1AqDjjO4@public.gmane.org>

Enable the on-chip audio codec

Signed-off-by: Jelle van der Waa <jelle-oJJ1AqDjjO4@public.gmane.org>
Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 arch/arm/boot/dts/sun7i-a20-pcduino3.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20-pcduino3.dts b/arch/arm/boot/dts/sun7i-a20-pcduino3.dts
index 861a4a6..067f365 100644
--- a/arch/arm/boot/dts/sun7i-a20-pcduino3.dts
+++ b/arch/arm/boot/dts/sun7i-a20-pcduino3.dts
@@ -111,6 +111,11 @@
 	allwinner,pins = "PH2";
 };
 
+
+&codec {
+	status = "okay";
+};
+
 &cpu0 {
 	cpu-supply = <&reg_dcdc2>;
 };
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: sun7i: Enable audio codec on pcDuino
  2015-11-03 15:47 [PATCH] ARM: dts: sun7i: Enable audio codec on pcDuino Hans de Goede
@ 2015-11-04  2:43 ` Stefan Monnier
       [not found]   ` <jwvsi4mo5al.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi-mXXj517/zsQ@public.gmane.org>
       [not found] ` <1446565640-21069-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  1 sibling, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2015-11-04  2:43 UTC (permalink / raw)
  To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

BTW, I've been using successfully the same additions in
sun7i-a20-bananapi.dts and sun7i-a20-orangepi-mini.dts.


        Stefan


>>>>> "Hans" == Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes:

> From: Jelle van der Waa <jelle-oJJ1AqDjjO4@public.gmane.org>
> Enable the on-chip audio codec

> Signed-off-by: Jelle van der Waa <jelle-oJJ1AqDjjO4@public.gmane.org>
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  arch/arm/boot/dts/sun7i-a20-pcduino3.dts | 5 +++++
>  1 file changed, 5 insertions(+)

> diff --git a/arch/arm/boot/dts/sun7i-a20-pcduino3.dts b/arch/arm/boot/dts/sun7i-a20-pcduino3.dts
> index 861a4a6..067f365 100644
> --- a/arch/arm/boot/dts/sun7i-a20-pcduino3.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-pcduino3.dts
> @@ -111,6 +111,11 @@
>  	allwinner,pins = "PH2";
>  };
 
> +
> +&codec {
> +	status = "okay";
> +};
> +
>  &cpu0 {
>  	cpu-supply = <&reg_dcdc2>;
>  };
> -- 
> 2.5.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [linux-sunxi] Re: [PATCH] ARM: dts: sun7i: Enable audio codec on pcDuino
       [not found]   ` <jwvsi4mo5al.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi-mXXj517/zsQ@public.gmane.org>
@ 2015-11-04  9:15     ` Hans de Goede
  0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2015-11-04  9:15 UTC (permalink / raw)
  To: monnier-CRDzTM1onBSWkKpYnGOUKg,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

Hi Stefan,

On 04-11-15 03:43, Stefan Monnier wrote:
> BTW, I've been using successfully the same additions in
> sun7i-a20-bananapi.dts and sun7i-a20-orangepi-mini.dts.

Can you please turn these additions into proper patches,
and send 2 separate patches for these with S-o-b lines
in the commit msg, using git send-email to send the patches ?

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: sun7i: Enable audio codec on pcDuino
       [not found] ` <1446565640-21069-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2015-11-04 16:06   ` Maxime Ripard
  0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2015-11-04 16:06 UTC (permalink / raw)
  To: Hans de Goede
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Jelle van der Waa

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

Hi,

On Tue, Nov 03, 2015 at 04:47:20PM +0100, Hans de Goede wrote:
> From: Jelle van der Waa <jelle-oJJ1AqDjjO4@public.gmane.org>
> 
> Enable the on-chip audio codec
> 
> Signed-off-by: Jelle van der Waa <jelle-oJJ1AqDjjO4@public.gmane.org>
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

I removed the extra blank line, and applied the patch.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-11-04 16:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-03 15:47 [PATCH] ARM: dts: sun7i: Enable audio codec on pcDuino Hans de Goede
2015-11-04  2:43 ` Stefan Monnier
     [not found]   ` <jwvsi4mo5al.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi-mXXj517/zsQ@public.gmane.org>
2015-11-04  9:15     ` [linux-sunxi] " Hans de Goede
     [not found] ` <1446565640-21069-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-04 16:06   ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).