From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sudarshan Shetty <tessolveupstream@gmail.com>,
andersson@kernel.org, konradybcio@kernel.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: Add support to validate direct DSI
Date: Tue, 11 Nov 2025 11:49:41 +0100 [thread overview]
Message-ID: <563a0de4-09d6-49f8-90a9-38b72e5c03ce@kernel.org> (raw)
In-Reply-To: <20251111104245.3420041-2-tessolveupstream@gmail.com>
On 11/11/2025 11:42, Sudarshan Shetty wrote:
> Adds device tree support for the Waveshare 10.1-inch
> MIPI-DSI panel on the QCS615 talos evk platform.
Why is this a board? Panel is a hat or sort of addon, so overlay, not a
board.
>
> Signed-off-by: Sudarshan Shetty <tessolveupstream@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> arch/arm64/boot/dts/qcom/talos-evk-dsi.dts | 43 ++++++++++++++++++++++
> 2 files changed, 44 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-dsi.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 282d744acd73..d5a3dd98137d 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -306,6 +306,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb
> dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += talos-evk-dsi.dtb
> x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo
> dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb
> x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtbo
> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-dsi.dts b/arch/arm64/boot/dts/qcom/talos-evk-dsi.dts
> new file mode 100644
> index 000000000000..8a6dc8b6bf8f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/talos-evk-dsi.dts
> @@ -0,0 +1,43 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +/dts-v1/;
> +
> +#include "talos-evk-cb.dtsi"
> +
> +&i2c1 {
> + clock-frequency = <400000>;
> +
> + status = "okay";
> +
> + display_mcu: display-mcu@45 {
> + compatible = "waveshare,touchscreen-panel-regulator";
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on
distro packages for dtschema and be sure you are using the latest
released dtschema.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-11 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 10:42 [PATCH v1 1/2] dt-bindings: arm: qcom: Add waveshare MIPI-DSI panels support Sudarshan Shetty
2025-11-11 10:42 ` [PATCH v1 2/2] arm64: dts: qcom: Add support to validate direct DSI Sudarshan Shetty
2025-11-11 10:49 ` Krzysztof Kozlowski [this message]
2025-11-11 11:10 ` Dmitry Baryshkov
2025-11-17 22:51 ` Bjorn Andersson
2025-11-11 10:48 ` [PATCH v1 1/2] dt-bindings: arm: qcom: Add waveshare MIPI-DSI panels support Krzysztof Kozlowski
2025-11-11 11:32 ` Rob Herring (Arm)
2025-11-17 23:05 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563a0de4-09d6-49f8-90a9-38b72e5c03ce@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tessolveupstream@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox