* [PATCH] dt-bindings: display: simplify compatibles syntax
@ 2023-04-14 10:42 Krzysztof Kozlowski
2023-04-17 7:26 ` Neil Armstrong
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-14 10:42 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Sam Ravnborg,
Javier Martinez Canillas, Xin Ji, Thierry Reding, Maxime Ripard,
dri-devel, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Lists (items) with one item should be just const or enum because it is
shorter and simpler.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Rebased on next-20230406. I hope it applies cleanly...
---
.../display/bridge/analogix,anx7625.yaml | 3 +--
.../display/panel/sharp,lq101r1sx01.yaml | 4 ++--
.../bindings/display/solomon,ssd1307fb.yaml | 24 +++++++++----------
3 files changed, 14 insertions(+), 17 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index 7960745a8dbe..a1ed1004651b 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -16,8 +16,7 @@ description: |
properties:
compatible:
- items:
- - const: analogix,anx7625
+ const: analogix,anx7625
reg:
maxItems: 1
diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml b/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml
index 9ec0e8aae4c6..57b44a0e763d 100644
--- a/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml
+++ b/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml
@@ -34,8 +34,8 @@ properties:
- items:
- const: sharp,lq101r1sx03
- const: sharp,lq101r1sx01
- - items:
- - const: sharp,lq101r1sx01
+ - enum:
+ - sharp,lq101r1sx01
reg: true
power-supply: true
diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
index 8bd58913804a..94bb5ef567c6 100644
--- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
+++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
@@ -14,20 +14,18 @@ properties:
compatible:
oneOf:
# Deprecated compatible strings
- - items:
- - enum:
- - solomon,ssd1305fb-i2c
- - solomon,ssd1306fb-i2c
- - solomon,ssd1307fb-i2c
- - solomon,ssd1309fb-i2c
+ - enum:
+ - solomon,ssd1305fb-i2c
+ - solomon,ssd1306fb-i2c
+ - solomon,ssd1307fb-i2c
+ - solomon,ssd1309fb-i2c
deprecated: true
- - items:
- - enum:
- - sinowealth,sh1106
- - solomon,ssd1305
- - solomon,ssd1306
- - solomon,ssd1307
- - solomon,ssd1309
+ - enum:
+ - sinowealth,sh1106
+ - solomon,ssd1305
+ - solomon,ssd1306
+ - solomon,ssd1307
+ - solomon,ssd1309
reg:
maxItems: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: display: simplify compatibles syntax
2023-04-14 10:42 [PATCH] dt-bindings: display: simplify compatibles syntax Krzysztof Kozlowski
@ 2023-04-17 7:26 ` Neil Armstrong
2023-04-18 21:11 ` Rob Herring
2023-04-27 11:50 ` Neil Armstrong
2 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2023-04-17 7:26 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andrzej Hajda, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Sam Ravnborg,
Javier Martinez Canillas, Xin Ji, Thierry Reding, Maxime Ripard,
dri-devel, devicetree, linux-kernel
On 14/04/2023 12:42, Krzysztof Kozlowski wrote:
> Lists (items) with one item should be just const or enum because it is
> shorter and simpler.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Rebased on next-20230406. I hope it applies cleanly...
> ---
> .../display/bridge/analogix,anx7625.yaml | 3 +--
> .../display/panel/sharp,lq101r1sx01.yaml | 4 ++--
> .../bindings/display/solomon,ssd1307fb.yaml | 24 +++++++++----------
> 3 files changed, 14 insertions(+), 17 deletions(-)
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: display: simplify compatibles syntax
2023-04-14 10:42 [PATCH] dt-bindings: display: simplify compatibles syntax Krzysztof Kozlowski
2023-04-17 7:26 ` Neil Armstrong
@ 2023-04-18 21:11 ` Rob Herring
2023-04-27 11:50 ` Neil Armstrong
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2023-04-18 21:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Xin Ji, Andrzej Hajda, linux-kernel,
Laurent Pinchart, Jonas Karlman, Daniel Vetter, Robert Foss,
Sam Ravnborg, Maxime Ripard, Krzysztof Kozlowski, dri-devel,
Neil Armstrong, Javier Martinez Canillas, David Airlie,
devicetree, Thierry Reding, Jernej Skrabec
On Fri, 14 Apr 2023 12:42:30 +0200, Krzysztof Kozlowski wrote:
> Lists (items) with one item should be just const or enum because it is
> shorter and simpler.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Rebased on next-20230406. I hope it applies cleanly...
> ---
> .../display/bridge/analogix,anx7625.yaml | 3 +--
> .../display/panel/sharp,lq101r1sx01.yaml | 4 ++--
> .../bindings/display/solomon,ssd1307fb.yaml | 24 +++++++++----------
> 3 files changed, 14 insertions(+), 17 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: display: simplify compatibles syntax
2023-04-14 10:42 [PATCH] dt-bindings: display: simplify compatibles syntax Krzysztof Kozlowski
2023-04-17 7:26 ` Neil Armstrong
2023-04-18 21:11 ` Rob Herring
@ 2023-04-27 11:50 ` Neil Armstrong
2023-04-27 15:50 ` Krzysztof Kozlowski
2 siblings, 1 reply; 5+ messages in thread
From: Neil Armstrong @ 2023-04-27 11:50 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andrzej Hajda, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Sam Ravnborg,
Javier Martinez Canillas, Xin Ji, Thierry Reding, Maxime Ripard,
dri-devel, devicetree, linux-kernel
On 14/04/2023 12:42, Krzysztof Kozlowski wrote:
> Lists (items) with one item should be just const or enum because it is
> shorter and simpler.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Rebased on next-20230406. I hope it applies cleanly...
> ---
> .../display/bridge/analogix,anx7625.yaml | 3 +--
> .../display/panel/sharp,lq101r1sx01.yaml | 4 ++--
> .../bindings/display/solomon,ssd1307fb.yaml | 24 +++++++++----------
> 3 files changed, 14 insertions(+), 17 deletions(-)
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Should I apply those patches ? Until now Rob finished by applying them.
Neil
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: display: simplify compatibles syntax
2023-04-27 11:50 ` Neil Armstrong
@ 2023-04-27 15:50 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-27 15:50 UTC (permalink / raw)
To: neil.armstrong, Andrzej Hajda, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Sam Ravnborg,
Javier Martinez Canillas, Xin Ji, Thierry Reding, Maxime Ripard,
dri-devel, devicetree, linux-kernel
On 27/04/2023 13:50, Neil Armstrong wrote:
> On 14/04/2023 12:42, Krzysztof Kozlowski wrote:
>> Lists (items) with one item should be just const or enum because it is
>> shorter and simpler.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Rebased on next-20230406. I hope it applies cleanly...
>> ---
>> .../display/bridge/analogix,anx7625.yaml | 3 +--
>> .../display/panel/sharp,lq101r1sx01.yaml | 4 ++--
>> .../bindings/display/solomon,ssd1307fb.yaml | 24 +++++++++----------
>> 3 files changed, 14 insertions(+), 17 deletions(-)
>>
>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
>
> Should I apply those patches ? Until now Rob finished by applying them.
Thanks. This and the mediatek display one were applied already by Rob.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-04-27 15:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-14 10:42 [PATCH] dt-bindings: display: simplify compatibles syntax Krzysztof Kozlowski
2023-04-17 7:26 ` Neil Armstrong
2023-04-18 21:11 ` Rob Herring
2023-04-27 11:50 ` Neil Armstrong
2023-04-27 15:50 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).