* [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC [not found] <1446186334-16510-1-git-send-email-alim.akhtar@samsung.com> @ 2015-10-30 6:25 ` Alim Akhtar 2015-10-30 7:42 ` Krzysztof Kozlowski ` (2 more replies) 0 siblings, 3 replies; 9+ messages in thread From: Alim Akhtar @ 2015-10-30 6:25 UTC (permalink / raw) To: lee.jones, broonie Cc: k.kozlowski, linux-samsung-soc, rtc-linux, linux-kernel, Thomas Abraham, devicetree From: Thomas Abraham <thomas.ab@samsung.com> Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. This also supports RTC and three 32.768KHz clock outputs. Cc: devicetree@vger.kernel.org Signed-off-by: Thomas Abraham <thomas.ab@samsung.com> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- Documentation/devicetree/bindings/mfd/s2mps11.txt | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt index 890f0b0e1643..4c0543ceec25 100644 --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt @@ -1,5 +1,5 @@ -* Samsung S2MPS11, S2MPS13, S2MPS14 and S2MPU02 Voltage and Current Regulator +* Samsung S2MPS11/13/14/15 and S2MPU02 Voltage and Current Regulator The Samsung S2MPS11 is a multi-function device which includes voltage and current regulators, RTC, charger controller and other sub-blocks. It is @@ -7,8 +7,12 @@ interfaced to the host controller using an I2C interface. Each sub-block is addressed by the host system using different I2C slave addresses. Required properties: -- compatible: Should be "samsung,s2mps11-pmic" or "samsung,s2mps13-pmic" - or "samsung,s2mps14-pmic" or "samsung,s2mpu02-pmic". +- compatible: Should be one of the following + - "samsung,s2mps11-pmic" + - "samsung,s2mps13-pmic" + - "samsung,s2mps14-pmic" + - "samsung,s2mps15-pmic" + - "samsung,s2mpu02-pmic". - reg: Specifies the I2C slave address of the pmic block. It should be 0x66. Optional properties: @@ -24,7 +28,7 @@ Optional properties: unwanted buck warm reset (setting buck voltages to default values). Optional nodes: -- clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered 32.768 +- clocks: s2mps11, s2mps13, s2mps15 and s5m8767 provide three(AP/CP/BT) buffered 32.768 KHz outputs, so to register these as clocks with common clock framework instantiate a sub-node named "clocks". It uses the common clock binding documented in : @@ -37,12 +41,13 @@ Optional nodes: the clock which they consume. Clock ID Devices ---------------------------------------------------------- - 32KhzAP 0 S2MPS11, S2MPS13, S2MPS14, S5M8767 - 32KhzCP 1 S2MPS11, S2MPS13, S5M8767 - 32KhzBT 2 S2MPS11, S2MPS13, S2MPS14, S5M8767 + 32KhzAP 0 S2MPS11, S2MPS13, S2MPS14, S2MPS15, S5M8767 + 32KhzCP 1 S2MPS11, S2MPS13, S2MPS15, S5M8767 + 32KhzBT 2 S2MPS11, S2MPS13, S2MPS14, S2MPS15, S5M8767 - compatible: Should be one of: "samsung,s2mps11-clk", "samsung,s2mps13-clk", "samsung,s2mps14-clk", "samsung,s5m8767-clk" + The s2msp15 uses the same compatible as s2mps13, as both provides similar clocks. - regulators: The regulators of s2mps11 that have to be instantiated should be included in a sub-node named 'regulators'. Regulator nodes included in this @@ -90,6 +95,7 @@ as per the datasheet of s2mps11. - S2MPS11: 1 to 38 - S2MPS13: 1 to 40 - S2MPS14: 1 to 25 + - S2MPS15: 1 to 27 - S2MPU02: 1 to 28 - Example: LDO1, LDO2, LDO28 - BUCKn @@ -97,6 +103,7 @@ as per the datasheet of s2mps11. - S2MPS11: 1 to 10 - S2MPS13: 1 to 10 - S2MPS14: 1 to 5 + - S2MPS15: 1 to 10 - S2MPU02: 1 to 7 - Example: BUCK1, BUCK2, BUCK9 -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC 2015-10-30 6:25 ` [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC Alim Akhtar @ 2015-10-30 7:42 ` Krzysztof Kozlowski 2015-10-30 9:25 ` Alim Akhtar 2015-10-30 17:24 ` Lee Jones [not found] ` <1446186334-16510-2-git-send-email-alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2 siblings, 1 reply; 9+ messages in thread From: Krzysztof Kozlowski @ 2015-10-30 7:42 UTC (permalink / raw) To: Alim Akhtar, lee.jones, broonie Cc: linux-samsung-soc, rtc-linux, linux-kernel, Thomas Abraham, devicetree On 30.10.2015 15:25, Alim Akhtar wrote: > From: Thomas Abraham <thomas.ab@samsung.com> > > Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device > is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. > This also supports RTC and three 32.768KHz clock outputs. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Thomas Abraham <thomas.ab@samsung.com> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > Documentation/devicetree/bindings/mfd/s2mps11.txt | 21 ++++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-) > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC 2015-10-30 7:42 ` Krzysztof Kozlowski @ 2015-10-30 9:25 ` Alim Akhtar 0 siblings, 0 replies; 9+ messages in thread From: Alim Akhtar @ 2015-10-30 9:25 UTC (permalink / raw) To: Krzysztof Kozlowski, lee.jones, broonie Cc: linux-samsung-soc, rtc-linux, linux-kernel, Thomas Abraham, devicetree On 10/30/2015 01:12 PM, Krzysztof Kozlowski wrote: > On 30.10.2015 15:25, Alim Akhtar wrote: >> From: Thomas Abraham <thomas.ab@samsung.com> >> >> Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device >> is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. >> This also supports RTC and three 32.768KHz clock outputs. >> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com> >> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >> --- >> Documentation/devicetree/bindings/mfd/s2mps11.txt | 21 ++++++++++++++------- >> 1 file changed, 14 insertions(+), 7 deletions(-) >> > > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Thanks Krzysztof. > Best regards, > Krzysztof > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC 2015-10-30 6:25 ` [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC Alim Akhtar 2015-10-30 7:42 ` Krzysztof Kozlowski @ 2015-10-30 17:24 ` Lee Jones [not found] ` <1446186334-16510-2-git-send-email-alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2 siblings, 0 replies; 9+ messages in thread From: Lee Jones @ 2015-10-30 17:24 UTC (permalink / raw) To: Alim Akhtar Cc: broonie, k.kozlowski, linux-samsung-soc, rtc-linux, linux-kernel, Thomas Abraham, devicetree On Fri, 30 Oct 2015, Alim Akhtar wrote: > From: Thomas Abraham <thomas.ab@samsung.com> > > Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device > is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. > This also supports RTC and three 32.768KHz clock outputs. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Thomas Abraham <thomas.ab@samsung.com> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > Documentation/devicetree/bindings/mfd/s2mps11.txt | 21 ++++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-) Applied, thanks. > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt > index 890f0b0e1643..4c0543ceec25 100644 > --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt > +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt > @@ -1,5 +1,5 @@ > > -* Samsung S2MPS11, S2MPS13, S2MPS14 and S2MPU02 Voltage and Current Regulator > +* Samsung S2MPS11/13/14/15 and S2MPU02 Voltage and Current Regulator > > The Samsung S2MPS11 is a multi-function device which includes voltage and > current regulators, RTC, charger controller and other sub-blocks. It is > @@ -7,8 +7,12 @@ interfaced to the host controller using an I2C interface. Each sub-block is > addressed by the host system using different I2C slave addresses. > > Required properties: > -- compatible: Should be "samsung,s2mps11-pmic" or "samsung,s2mps13-pmic" > - or "samsung,s2mps14-pmic" or "samsung,s2mpu02-pmic". > +- compatible: Should be one of the following > + - "samsung,s2mps11-pmic" > + - "samsung,s2mps13-pmic" > + - "samsung,s2mps14-pmic" > + - "samsung,s2mps15-pmic" > + - "samsung,s2mpu02-pmic". > - reg: Specifies the I2C slave address of the pmic block. It should be 0x66. > > Optional properties: > @@ -24,7 +28,7 @@ Optional properties: > unwanted buck warm reset (setting buck voltages to default values). > > Optional nodes: > -- clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered 32.768 > +- clocks: s2mps11, s2mps13, s2mps15 and s5m8767 provide three(AP/CP/BT) buffered 32.768 > KHz outputs, so to register these as clocks with common clock framework > instantiate a sub-node named "clocks". It uses the common clock binding > documented in : > @@ -37,12 +41,13 @@ Optional nodes: > the clock which they consume. > Clock ID Devices > ---------------------------------------------------------- > - 32KhzAP 0 S2MPS11, S2MPS13, S2MPS14, S5M8767 > - 32KhzCP 1 S2MPS11, S2MPS13, S5M8767 > - 32KhzBT 2 S2MPS11, S2MPS13, S2MPS14, S5M8767 > + 32KhzAP 0 S2MPS11, S2MPS13, S2MPS14, S2MPS15, S5M8767 > + 32KhzCP 1 S2MPS11, S2MPS13, S2MPS15, S5M8767 > + 32KhzBT 2 S2MPS11, S2MPS13, S2MPS14, S2MPS15, S5M8767 > > - compatible: Should be one of: "samsung,s2mps11-clk", "samsung,s2mps13-clk", > "samsung,s2mps14-clk", "samsung,s5m8767-clk" > + The s2msp15 uses the same compatible as s2mps13, as both provides similar clocks. > > - regulators: The regulators of s2mps11 that have to be instantiated should be > included in a sub-node named 'regulators'. Regulator nodes included in this > @@ -90,6 +95,7 @@ as per the datasheet of s2mps11. > - S2MPS11: 1 to 38 > - S2MPS13: 1 to 40 > - S2MPS14: 1 to 25 > + - S2MPS15: 1 to 27 > - S2MPU02: 1 to 28 > - Example: LDO1, LDO2, LDO28 > - BUCKn > @@ -97,6 +103,7 @@ as per the datasheet of s2mps11. > - S2MPS11: 1 to 10 > - S2MPS13: 1 to 10 > - S2MPS14: 1 to 5 > + - S2MPS15: 1 to 10 > - S2MPU02: 1 to 7 > - Example: BUCK1, BUCK2, BUCK9 > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <1446186334-16510-2-git-send-email-alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC [not found] ` <1446186334-16510-2-git-send-email-alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> @ 2015-11-06 22:33 ` Rob Herring 2015-11-07 1:11 ` Alim Akhtar 2015-11-07 3:09 ` [rtc-linux] " Krzysztof Kozlowski 0 siblings, 2 replies; 9+ messages in thread From: Rob Herring @ 2015-11-06 22:33 UTC (permalink / raw) To: Alim Akhtar Cc: lee.jones-QSEj5FYQhm4dnm+yROfE0A, broonie-DgEjT+Ai2ygdnm+yROfE0A, k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, rtc-linux-/JYPxA39Uh5TLH3MbocFFw, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Thomas Abraham, devicetree-u79uwXL29TY76Z2rM5mHXA On Fri, Oct 30, 2015 at 11:55:31AM +0530, Alim Akhtar wrote: > From: Thomas Abraham <thomas.ab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > > Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device > is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. > This also supports RTC and three 32.768KHz clock outputs. > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Signed-off-by: Thomas Abraham <thomas.ab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > Signed-off-by: Alim Akhtar <alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > --- > Documentation/devicetree/bindings/mfd/s2mps11.txt | 21 ++++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt > index 890f0b0e1643..4c0543ceec25 100644 > --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt > +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt > @@ -1,5 +1,5 @@ > > -* Samsung S2MPS11, S2MPS13, S2MPS14 and S2MPU02 Voltage and Current Regulator > +* Samsung S2MPS11/13/14/15 and S2MPU02 Voltage and Current Regulator > > The Samsung S2MPS11 is a multi-function device which includes voltage and > current regulators, RTC, charger controller and other sub-blocks. It is > @@ -7,8 +7,12 @@ interfaced to the host controller using an I2C interface. Each sub-block is > addressed by the host system using different I2C slave addresses. > > Required properties: > -- compatible: Should be "samsung,s2mps11-pmic" or "samsung,s2mps13-pmic" > - or "samsung,s2mps14-pmic" or "samsung,s2mpu02-pmic". > +- compatible: Should be one of the following > + - "samsung,s2mps11-pmic" > + - "samsung,s2mps13-pmic" > + - "samsung,s2mps14-pmic" > + - "samsung,s2mps15-pmic" > + - "samsung,s2mpu02-pmic". > - reg: Specifies the I2C slave address of the pmic block. It should be 0x66. > > Optional properties: > @@ -24,7 +28,7 @@ Optional properties: > unwanted buck warm reset (setting buck voltages to default values). > > Optional nodes: > -- clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered 32.768 > +- clocks: s2mps11, s2mps13, s2mps15 and s5m8767 provide three(AP/CP/BT) buffered 32.768 s5m8767 doesn't seem to be documented. Can you please fix or remove. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC 2015-11-06 22:33 ` Rob Herring @ 2015-11-07 1:11 ` Alim Akhtar 2015-11-07 3:09 ` [rtc-linux] " Krzysztof Kozlowski 1 sibling, 0 replies; 9+ messages in thread From: Alim Akhtar @ 2015-11-07 1:11 UTC (permalink / raw) To: Rob Herring Cc: Alim Akhtar, Lee Jones, broonie-DgEjT+Ai2ygdnm+yROfE0A, Krzysztof Kozłowski, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Abraham, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Hi Rob, On Sat, Nov 7, 2015 at 4:03 AM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > On Fri, Oct 30, 2015 at 11:55:31AM +0530, Alim Akhtar wrote: >> From: Thomas Abraham <thomas.ab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> >> >> Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device >> is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. >> This also supports RTC and three 32.768KHz clock outputs. >> >> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> Signed-off-by: Thomas Abraham <thomas.ab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> >> Signed-off-by: Alim Akhtar <alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> >> --- >> Documentation/devicetree/bindings/mfd/s2mps11.txt | 21 ++++++++++++++------- >> 1 file changed, 14 insertions(+), 7 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt >> index 890f0b0e1643..4c0543ceec25 100644 >> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt >> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt >> @@ -1,5 +1,5 @@ >> >> -* Samsung S2MPS11, S2MPS13, S2MPS14 and S2MPU02 Voltage and Current Regulator >> +* Samsung S2MPS11/13/14/15 and S2MPU02 Voltage and Current Regulator >> >> The Samsung S2MPS11 is a multi-function device which includes voltage and >> current regulators, RTC, charger controller and other sub-blocks. It is >> @@ -7,8 +7,12 @@ interfaced to the host controller using an I2C interface. Each sub-block is >> addressed by the host system using different I2C slave addresses. >> >> Required properties: >> -- compatible: Should be "samsung,s2mps11-pmic" or "samsung,s2mps13-pmic" >> - or "samsung,s2mps14-pmic" or "samsung,s2mpu02-pmic". >> +- compatible: Should be one of the following >> + - "samsung,s2mps11-pmic" >> + - "samsung,s2mps13-pmic" >> + - "samsung,s2mps14-pmic" >> + - "samsung,s2mps15-pmic" >> + - "samsung,s2mpu02-pmic". >> - reg: Specifies the I2C slave address of the pmic block. It should be 0x66. >> >> Optional properties: >> @@ -24,7 +28,7 @@ Optional properties: >> unwanted buck warm reset (setting buck voltages to default values). >> >> Optional nodes: >> -- clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered 32.768 >> +- clocks: s2mps11, s2mps13, s2mps15 and s5m8767 provide three(AP/CP/BT) buffered 32.768 > > s5m8767 doesn't seem to be documented. Can you please fix or remove. > Ok, will take a look. > Rob > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Regards, Alim -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [rtc-linux] Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC 2015-11-06 22:33 ` Rob Herring 2015-11-07 1:11 ` Alim Akhtar @ 2015-11-07 3:09 ` Krzysztof Kozlowski 2015-11-09 5:54 ` Alim Akhtar 1 sibling, 1 reply; 9+ messages in thread From: Krzysztof Kozlowski @ 2015-11-07 3:09 UTC (permalink / raw) To: rtc-linux, Alim Akhtar Cc: k.kozlowski.k, lee.jones, broonie, linux-samsung-soc, linux-kernel, Thomas Abraham, devicetree W dniu 07.11.2015 o 07:33, Rob Herring pisze: > On Fri, Oct 30, 2015 at 11:55:31AM +0530, Alim Akhtar wrote: >> From: Thomas Abraham <thomas.ab@samsung.com> >> >> Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device >> is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. >> This also supports RTC and three 32.768KHz clock outputs. >> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com> >> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >> --- >> Documentation/devicetree/bindings/mfd/s2mps11.txt | 21 ++++++++++++++------- >> 1 file changed, 14 insertions(+), 7 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt >> index 890f0b0e1643..4c0543ceec25 100644 >> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt >> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt >> @@ -1,5 +1,5 @@ >> >> -* Samsung S2MPS11, S2MPS13, S2MPS14 and S2MPU02 Voltage and Current Regulator >> +* Samsung S2MPS11/13/14/15 and S2MPU02 Voltage and Current Regulator >> >> The Samsung S2MPS11 is a multi-function device which includes voltage and >> current regulators, RTC, charger controller and other sub-blocks. It is >> @@ -7,8 +7,12 @@ interfaced to the host controller using an I2C interface. Each sub-block is >> addressed by the host system using different I2C slave addresses. >> >> Required properties: >> -- compatible: Should be "samsung,s2mps11-pmic" or "samsung,s2mps13-pmic" >> - or "samsung,s2mps14-pmic" or "samsung,s2mpu02-pmic". >> +- compatible: Should be one of the following >> + - "samsung,s2mps11-pmic" >> + - "samsung,s2mps13-pmic" >> + - "samsung,s2mps14-pmic" >> + - "samsung,s2mps15-pmic" >> + - "samsung,s2mpu02-pmic". >> - reg: Specifies the I2C slave address of the pmic block. It should be 0x66. >> >> Optional properties: >> @@ -24,7 +28,7 @@ Optional properties: >> unwanted buck warm reset (setting buck voltages to default values). >> >> Optional nodes: >> -- clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered 32.768 >> +- clocks: s2mps11, s2mps13, s2mps15 and s5m8767 provide three(AP/CP/BT) buffered 32.768 > > s5m8767 doesn't seem to be documented. Can you please fix or remove. What exactly do you have in mind? The s5m8767-clk is already documented as part of clk-s2mps11.c driver: Documentation/devicetree/bindings/mfd/s2mps11.txt The main s5m8767 MFD driver is documented as part of regulator driver: Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt Yes, this may be confusing... They S2M and S5M family devices share: - main mfd driver, - rtc driver, - clk driver. but regulator drivers are separate. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [rtc-linux] Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC 2015-11-07 3:09 ` [rtc-linux] " Krzysztof Kozlowski @ 2015-11-09 5:54 ` Alim Akhtar 2015-11-09 6:40 ` Krzysztof Kozlowski 0 siblings, 1 reply; 9+ messages in thread From: Alim Akhtar @ 2015-11-09 5:54 UTC (permalink / raw) To: Krzysztof Kozlowski, rtc-linux Cc: k.kozlowski.k, lee.jones, broonie, linux-samsung-soc, linux-kernel, Thomas Abraham, devicetree Hi Krzysztof, On 11/07/2015 08:39 AM, Krzysztof Kozlowski wrote: > W dniu 07.11.2015 o 07:33, Rob Herring pisze: >> On Fri, Oct 30, 2015 at 11:55:31AM +0530, Alim Akhtar wrote: >>> From: Thomas Abraham <thomas.ab@samsung.com> >>> >>> Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device >>> is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. >>> This also supports RTC and three 32.768KHz clock outputs. >>> >>> Cc: devicetree@vger.kernel.org >>> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com> >>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >>> --- >>> Documentation/devicetree/bindings/mfd/s2mps11.txt | 21 ++++++++++++++------- >>> 1 file changed, 14 insertions(+), 7 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt >>> index 890f0b0e1643..4c0543ceec25 100644 >>> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt >>> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt >>> @@ -1,5 +1,5 @@ >>> >>> -* Samsung S2MPS11, S2MPS13, S2MPS14 and S2MPU02 Voltage and Current Regulator >>> +* Samsung S2MPS11/13/14/15 and S2MPU02 Voltage and Current Regulator >>> >>> The Samsung S2MPS11 is a multi-function device which includes voltage and >>> current regulators, RTC, charger controller and other sub-blocks. It is >>> @@ -7,8 +7,12 @@ interfaced to the host controller using an I2C interface. Each sub-block is >>> addressed by the host system using different I2C slave addresses. >>> >>> Required properties: >>> -- compatible: Should be "samsung,s2mps11-pmic" or "samsung,s2mps13-pmic" >>> - or "samsung,s2mps14-pmic" or "samsung,s2mpu02-pmic". >>> +- compatible: Should be one of the following >>> + - "samsung,s2mps11-pmic" >>> + - "samsung,s2mps13-pmic" >>> + - "samsung,s2mps14-pmic" >>> + - "samsung,s2mps15-pmic" >>> + - "samsung,s2mpu02-pmic". >>> - reg: Specifies the I2C slave address of the pmic block. It should be 0x66. >>> >>> Optional properties: >>> @@ -24,7 +28,7 @@ Optional properties: >>> unwanted buck warm reset (setting buck voltages to default values). >>> >>> Optional nodes: >>> -- clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered 32.768 >>> +- clocks: s2mps11, s2mps13, s2mps15 and s5m8767 provide three(AP/CP/BT) buffered 32.768 >> >> s5m8767 doesn't seem to be documented. Can you please fix or remove. > > What exactly do you have in mind? > > The s5m8767-clk is already documented as part of clk-s2mps11.c driver: > Documentation/devicetree/bindings/mfd/s2mps11.txt > > The main s5m8767 MFD driver is documented as part of regulator driver: > Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt > > Yes, this may be confusing... They S2M and S5M family devices share: > - main mfd driver, > - rtc driver, > - clk driver. > > but regulator drivers are separate. > Indeed things are documented but in very confusing manners, e.g. compatible name "samsung,s5m8767-pmic" belongs to MFD not regulator. It should have being in */bindings/mfd/s2mps11.txt Not sure if it make sense to change it though. > Best regards, > Krzysztof > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [rtc-linux] Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC 2015-11-09 5:54 ` Alim Akhtar @ 2015-11-09 6:40 ` Krzysztof Kozlowski 0 siblings, 0 replies; 9+ messages in thread From: Krzysztof Kozlowski @ 2015-11-09 6:40 UTC (permalink / raw) To: Alim Akhtar, rtc-linux Cc: k.kozlowski.k, lee.jones, broonie, linux-samsung-soc, linux-kernel, Thomas Abraham, devicetree On 09.11.2015 14:54, Alim Akhtar wrote: > Hi Krzysztof, > > On 11/07/2015 08:39 AM, Krzysztof Kozlowski wrote: >> W dniu 07.11.2015 o 07:33, Rob Herring pisze: >>> On Fri, Oct 30, 2015 at 11:55:31AM +0530, Alim Akhtar wrote: >>>> From: Thomas Abraham <thomas.ab@samsung.com> >>>> >>>> Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 >>>> device >>>> is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck >>>> regulators. >>>> This also supports RTC and three 32.768KHz clock outputs. >>>> >>>> Cc: devicetree@vger.kernel.org >>>> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com> >>>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >>>> --- >>>> Documentation/devicetree/bindings/mfd/s2mps11.txt | 21 >>>> ++++++++++++++------- >>>> 1 file changed, 14 insertions(+), 7 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt >>>> b/Documentation/devicetree/bindings/mfd/s2mps11.txt >>>> index 890f0b0e1643..4c0543ceec25 100644 >>>> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt >>>> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt >>>> @@ -1,5 +1,5 @@ >>>> >>>> -* Samsung S2MPS11, S2MPS13, S2MPS14 and S2MPU02 Voltage and Current >>>> Regulator >>>> +* Samsung S2MPS11/13/14/15 and S2MPU02 Voltage and Current Regulator >>>> >>>> The Samsung S2MPS11 is a multi-function device which includes >>>> voltage and >>>> current regulators, RTC, charger controller and other sub-blocks. >>>> It is >>>> @@ -7,8 +7,12 @@ interfaced to the host controller using an I2C >>>> interface. Each sub-block is >>>> addressed by the host system using different I2C slave addresses. >>>> >>>> Required properties: >>>> -- compatible: Should be "samsung,s2mps11-pmic" or >>>> "samsung,s2mps13-pmic" >>>> - or "samsung,s2mps14-pmic" or "samsung,s2mpu02-pmic". >>>> +- compatible: Should be one of the following >>>> + - "samsung,s2mps11-pmic" >>>> + - "samsung,s2mps13-pmic" >>>> + - "samsung,s2mps14-pmic" >>>> + - "samsung,s2mps15-pmic" >>>> + - "samsung,s2mpu02-pmic". >>>> - reg: Specifies the I2C slave address of the pmic block. It >>>> should be 0x66. >>>> >>>> Optional properties: >>>> @@ -24,7 +28,7 @@ Optional properties: >>>> unwanted buck warm reset (setting buck voltages to default values). >>>> >>>> Optional nodes: >>>> -- clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) >>>> buffered 32.768 >>>> +- clocks: s2mps11, s2mps13, s2mps15 and s5m8767 provide >>>> three(AP/CP/BT) buffered 32.768 >>> >>> s5m8767 doesn't seem to be documented. Can you please fix or remove. >> >> What exactly do you have in mind? >> >> The s5m8767-clk is already documented as part of clk-s2mps11.c driver: >> Documentation/devicetree/bindings/mfd/s2mps11.txt >> >> The main s5m8767 MFD driver is documented as part of regulator driver: >> Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt >> >> Yes, this may be confusing... They S2M and S5M family devices share: >> - main mfd driver, >> - rtc driver, >> - clk driver. >> >> but regulator drivers are separate. >> > Indeed things are documented but in very confusing manners, e.g. > compatible name "samsung,s5m8767-pmic" belongs to MFD not regulator. The compatible itself belongs to MFD but in the same time the required properties for regulator driver (which expects to be child of that compatible) are stored next to it. > It should have being in */bindings/mfd/s2mps11.txt > Not sure if it make sense to change it though. Then the naming would be confusing. :) Actually I have it on my todo list to fix things up. Truth is that all of these devices are tightly coupled. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-11-09 6:40 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1446186334-16510-1-git-send-email-alim.akhtar@samsung.com>
2015-10-30 6:25 ` [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC Alim Akhtar
2015-10-30 7:42 ` Krzysztof Kozlowski
2015-10-30 9:25 ` Alim Akhtar
2015-10-30 17:24 ` Lee Jones
[not found] ` <1446186334-16510-2-git-send-email-alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-11-06 22:33 ` Rob Herring
2015-11-07 1:11 ` Alim Akhtar
2015-11-07 3:09 ` [rtc-linux] " Krzysztof Kozlowski
2015-11-09 5:54 ` Alim Akhtar
2015-11-09 6:40 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).