From: John Garry <john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: JBottomley-wo1vFcy6AUs@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
john.garry2-s/0ZXS5h9803lw97EnAbAg@public.gmane.org,
hare-l3A5Bk7waGM@public.gmane.org,
xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v3 11/32] scsi: hisi_sas: add phy SAS ADDR initialization
Date: Mon, 9 Nov 2015 16:51:12 +0000 [thread overview]
Message-ID: <5640CF00.2030003@huawei.com> (raw)
In-Reply-To: <4369607.QVA3rBnZUm@wuerfel>
On 09/11/2015 16:28, Arnd Bergmann wrote:
> On Tuesday 10 November 2015 00:32:16 John Garry wrote:
>> }
>>
>> +static void hisi_sas_init_add(struct hisi_hba *hisi_hba)
>> +{
>> + int i;
>> +
>> + for (i = 0; i < hisi_hba->n_phy; i++)
>> + memcpy(&hisi_hba->phy[i].dev_sas_addr,
>> + hisi_hba->sas_addr,
>> + SAS_ADDR_SIZE);
>> +}
>
> I don't know the background here, but I thought it would have to
> be a different address on each phy. Are you sure this is not the
> case?
>
> Arnd
>
> .
>
Hi,
Each controller should have a unique SAS addr but not each phy.
Regards,
john
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-09 16:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 16:32 [PATCH v3 00/32] HiSilicon SAS driver John Garry
2015-11-09 16:32 ` [PATCH v3 01/32] [SCSI] sas: centralise ssp frame information units John Garry
2015-11-09 16:32 ` [PATCH v3 03/32] scsi: hisi_sas: add initial bare main driver John Garry
2015-11-09 16:32 ` [PATCH v3 04/32] scsi: hisi_sas: add scsi host registration John Garry
2015-11-09 16:32 ` [PATCH v3 05/32] scsi: hisi_sas: scan device tree John Garry
2015-11-09 16:32 ` [PATCH v3 06/32] scsi: hisi_sas: add HW DMA structures John Garry
2015-11-09 16:32 ` [PATCH v3 07/32] scsi: hisi_sas: allocate memories and create pools John Garry
2015-11-09 16:32 ` [PATCH v3 08/32] scsi: hisi_sas: add hisi_sas_remove John Garry
[not found] ` <1447086757-147706-9-git-send-email-john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-11-10 3:48 ` Wei Fang
2015-11-10 10:55 ` John Garry
2015-11-09 16:32 ` [PATCH v3 09/32] scsi: hisi_sas: add slot init code John Garry
2015-11-09 16:32 ` [PATCH v3 10/32] scsi: hisi_sas: add cq structure initialization John Garry
2015-11-09 16:32 ` [PATCH v3 11/32] scsi: hisi_sas: add phy SAS ADDR initialization John Garry
2015-11-09 16:28 ` Arnd Bergmann
2015-11-09 16:51 ` John Garry [this message]
2015-11-09 16:32 ` [PATCH v3 16/32] scsi: hisi_sas: add timer and spinlock init John Garry
2015-11-09 16:32 ` [PATCH v3 17/32] scsi: hisi_sas: add v1 hw module init John Garry
2015-11-09 16:32 ` [PATCH v3 18/32] scsi: hisi_sas: add v1 hardware register definitions John Garry
[not found] ` <1447086757-147706-1-git-send-email-john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-11-09 16:32 ` [PATCH v3 02/32] devicetree: bindings: scsi: HiSi SAS John Garry
2015-11-09 18:01 ` Rob Herring
2015-11-10 11:09 ` John Garry
2015-11-10 13:16 ` Rob Herring
2015-11-09 16:32 ` [PATCH v3 12/32] scsi: hisi_sas: set dev DMA mask John Garry
2015-11-09 16:32 ` [PATCH v3 13/32] scsi: hisi_sas: add hisi_hba workqueue John Garry
2015-11-09 16:32 ` [PATCH v3 14/32] scsi: hisi_sas: add hisi sas device type John Garry
2015-11-09 16:32 ` [PATCH v3 15/32] scsi: hisi_sas: add phy and port init John Garry
2015-11-09 16:32 ` [PATCH v3 19/32] scsi: hisi_sas: add v1 HW initialisation code John Garry
2015-11-09 16:32 ` [PATCH v3 20/32] scsi: hisi_sas: add v1 hw interrupt init John Garry
2015-11-09 16:32 ` [PATCH v3 27/32] scsi: hisi_sas: add smp protocol support John Garry
2015-11-09 16:32 ` [PATCH v3 21/32] scsi: hisi_sas: add path from phyup irq to SAS framework John Garry
2015-11-09 16:32 ` [PATCH v3 22/32] scsi: hisi_sas: add ssp command function John Garry
2015-11-09 16:32 ` [PATCH v3 23/32] scsi: hisi_sas: add cq interrupt handler John Garry
2015-11-09 16:32 ` [PATCH v3 24/32] scsi: hisi_sas: add dev_found and dev_gone John Garry
2015-11-09 16:32 ` [PATCH v3 25/32] scsi: hisi_sas: add abnormal irq handler John Garry
2015-11-09 16:32 ` [PATCH v3 26/32] scsi: hisi_sas: add bcast interrupt handler John Garry
2015-11-09 16:32 ` [PATCH v3 28/32] scsi: hisi_sas: add scan finished and start John Garry
2015-11-09 16:32 ` [PATCH v3 29/32] scsi: hisi_sas: add tmf methods John Garry
2015-11-09 16:32 ` [PATCH v3 30/32] scsi: hisi_sas: add control phy handler John Garry
2015-11-09 16:32 ` [PATCH v3 31/32] scsi: hisi_sas: add fatal irq handler John Garry
2015-11-09 16:32 ` [PATCH v3 32/32] MAINTAINERS: add maintainer for HiSi SAS driver John Garry
2015-11-09 16:40 ` [PATCH v3 00/32] HiSilicon " Arnd Bergmann
2015-11-10 7:15 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5640CF00.2030003@huawei.com \
--to=john.garry-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=JBottomley-wo1vFcy6AUs@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=hare-l3A5Bk7waGM@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=john.garry2-s/0ZXS5h9803lw97EnAbAg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
--cc=zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).