devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Alim Akhtar <alim.akhtar@gmail.com>,
	Alim Akhtar <alim.akhtar@samsung.com>
Cc: linux-scsi@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"James E.J. Bottomley" <JBottomley@odin.com>,
	vinayak holikatti <vinholikatti@gmail.com>,
	Vivek Gautam <gautam.vivek@samsung.com>,
	Seungwon Jeon <essuuj@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 00/11] exynos-ufs: add support for Exynos
Date: Tue, 17 Nov 2015 11:00:12 +0530	[thread overview]
Message-ID: <564ABB64.3080001@ti.com> (raw)
In-Reply-To: <CAGOxZ51jKb_UYG-UmsN17zpAwR92KXt0KjGq8gCotmsvCsfHkA@mail.gmail.com>

Hi Alim,

On Monday 16 November 2015 06:31 AM, Alim Akhtar wrote:
> Hi Kishon,
> 
> Any more concern on the PHY part of this series?

Sorry for the late reply. Yes, I still have concerns. I'll comment on your patch.

Thanks
Kishon
> 
> Thanks!
> 
> On Mon, Nov 9, 2015 at 10:56 AM, Alim Akhtar <alim.akhtar@samsung.com> wrote:
>> This patch-set introduces UFS (Universal Flash Storage) host support
>> for Samsung Exynos SoC. Mostly, it consists of UFS PHY and host specific driver.
>> And it also contains some quirks handling for Exynos.
>>
>> NOTE: ** This series has a dependency on [4]. **
>>
>> -Changes since v4:
>> * Removed platform specific PHY ops as suggested by Kishon
>> * Rebased on the top of Yaniv Gardi's work [4]
>> * make use of newly introduce ufshcd_{get,set}_variant
>> * other small changes and improvements.
>> * rebased on the top of linux next-20151109
>>
>> -Changes since v3:
>> * Fixed compilation warrings as reported by "Kbuild Test Robot"[5].
>> * Restructure the driver to make it as a platform driver, rebased on top of [4].
>> * Addressed review comments from Arnd Bergmann[5].
>> * Other misc changes and improvements.
>>
>> -Changes since v2:
>> * Addressed review comments from Kishon[1] and Rob Herring [2]
>> * Splited ufs dt binding documetation from ufs driver patch
>>
>> -Changes since v1:
>> * Addressed review comments from Alexey[3] and various review comments from Amit.
>> * Updated email id of Seungwon as his samsung id is void now.
>> * Added ufs platform data
>>
>> [1]-> https://lkml.org/lkml/2015/9/18/29
>> [2]-> https://lkml.org/lkml/2015/9/21/668
>> [3]-> https://lkml.org/lkml/2015/8/23/124
>> [4]-> https://lkml.org/lkml/2015/10/28/271
>> [5]-> https://lkml.org/lkml/2015/10/1/402
>>
>> This patch set is tested on exynos7-espresso board.
>>
>>
>> Alim Akhtar (1):
>>   Documentation: samsung-phy: Add dt bindings for UFS
>>
>> Seungwon Jeon (10):
>>   phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC
>>   scsi: ufs: add quirk to contain unconformable utrd field
>>   scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr
>>   scsi: ufs: add quirk not to allow reset of interrupt aggregation
>>   scsi: ufs: add quirk to enable host controller without hce
>>   scsi: ufs: add specific callback for nexus type
>>   scsi: ufs: add add specific callback for hibern8
>>   scsi: ufs: make ufshcd_config_pwr_mode of non-static func
>>   Documentation: devicetree: ufs: Add DT bindings for exynos UFS host
>>     controller
>>   scsi: ufs-exynos: add UFS host support for Exynos SoCs
>>
>>  .../devicetree/bindings/phy/samsung-phy.txt        |   22 +
>>  .../devicetree/bindings/ufs/ufs-exynos.txt         |  104 ++
>>  drivers/phy/Kconfig                                |    7 +
>>  drivers/phy/Makefile                               |    1 +
>>  drivers/phy/phy-exynos-ufs.c                       |  241 ++++
>>  drivers/phy/phy-exynos-ufs.h                       |   85 ++
>>  drivers/phy/phy-exynos7-ufs.h                      |   89 ++
>>  drivers/scsi/ufs/Kconfig                           |   12 +
>>  drivers/scsi/ufs/Makefile                          |    1 +
>>  drivers/scsi/ufs/ufs-exynos-hw.c                   |  131 ++
>>  drivers/scsi/ufs/ufs-exynos-hw.h                   |   43 +
>>  drivers/scsi/ufs/ufs-exynos.c                      | 1304 ++++++++++++++++++++
>>  drivers/scsi/ufs/ufs-exynos.h                      |  247 ++++
>>  drivers/scsi/ufs/ufshcd.c                          |  168 ++-
>>  drivers/scsi/ufs/ufshcd.h                          |   54 +
>>  drivers/scsi/ufs/ufshci.h                          |   26 +-
>>  drivers/scsi/ufs/unipro.h                          |   47 +
>>  include/linux/phy/phy-exynos-ufs.h                 |   85 ++
>>  18 files changed, 2647 insertions(+), 20 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/ufs/ufs-exynos.txt
>>  create mode 100644 drivers/phy/phy-exynos-ufs.c
>>  create mode 100644 drivers/phy/phy-exynos-ufs.h
>>  create mode 100644 drivers/phy/phy-exynos7-ufs.h
>>  create mode 100644 drivers/scsi/ufs/ufs-exynos-hw.c
>>  create mode 100644 drivers/scsi/ufs/ufs-exynos-hw.h
>>  create mode 100644 drivers/scsi/ufs/ufs-exynos.c
>>  create mode 100644 drivers/scsi/ufs/ufs-exynos.h
>>  create mode 100644 include/linux/phy/phy-exynos-ufs.h
>>
>> --
>> 1.7.10.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 

      reply	other threads:[~2015-11-17  5:30 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09  5:26 [PATCH v5 00/11] exynos-ufs: add support for Exynos Alim Akhtar
2015-11-09  5:26 ` [PATCH v5 01/11] Documentation: samsung-phy: Add dt bindings for UFS Alim Akhtar
2015-11-09  5:26 ` [PATCH v5 02/11] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC Alim Akhtar
2015-11-17  6:16   ` Kishon Vijay Abraham I
2015-11-17  8:11     ` Alim Akhtar
     [not found]       ` <564AE11F.50908-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-11-19 13:39         ` Kishon Vijay Abraham I
     [not found]           ` <CGME20170203092123epcas4p20b1d56d7a6fdec46903c41fc65718795@epcas4p2.samsung.com>
     [not found]             ` <564DD11D.2060101-l0cyMroinI0@public.gmane.org>
2017-02-03  9:19               ` Alim Akhtar
2017-02-22 18:50                 ` Alim Akhtar
2017-02-27  5:26                   ` Kishon Vijay Abraham I
2017-02-27 14:10                     ` Alim Akhtar
     [not found]                       ` <58B4EFC8.2060300@ti.com>
2017-02-28  8:21                         ` Alim Akhtar
     [not found]                           ` <12decf59-0486-9efd-63de-12fee95a8cea-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-03-01  4:37                             ` Kishon Vijay Abraham I
     [not found]                               ` <58B64FF1.3020808-l0cyMroinI0@public.gmane.org>
2017-03-06 11:42                                 ` Alim Akhtar
2017-03-06 13:31                                   ` Kishon Vijay Abraham I
2015-11-09  5:26 ` [PATCH v5 03/11] scsi: ufs: add quirk to contain unconformable utrd field Alim Akhtar
2015-11-09  5:26 ` [PATCH v5 04/11] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr Alim Akhtar
2015-11-09  5:26 ` [PATCH v5 05/11] scsi: ufs: add quirk not to allow reset of interrupt aggregation Alim Akhtar
     [not found] ` <1447046787-480-1-git-send-email-alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-11-09  5:26   ` [PATCH v5 06/11] scsi: ufs: add quirk to enable host controller without hce Alim Akhtar
     [not found]     ` <1447046787-480-7-git-send-email-alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-11-17  8:43       ` Arnd Bergmann
2015-11-09  5:26 ` [PATCH v5 07/11] scsi: ufs: add specific callback for nexus type Alim Akhtar
2015-11-09  5:26 ` [PATCH v5 08/11] scsi: ufs: add add specific callback for hibern8 Alim Akhtar
2015-11-09  5:26 ` [PATCH v5 09/11] scsi: ufs: make ufshcd_config_pwr_mode of non-static func Alim Akhtar
2015-11-09  5:26 ` [PATCH v5 10/11] Documentation: devicetree: ufs: Add DT bindings for exynos UFS host controller Alim Akhtar
2015-11-09 16:23   ` Rob Herring
2015-11-10  8:35     ` Alim Akhtar
2015-11-10 13:18       ` Rob Herring
2015-11-09  5:26 ` [PATCH v5 11/11] scsi: ufs-exynos: add UFS host support for Exynos SoCs Alim Akhtar
     [not found]   ` <1447046787-480-12-git-send-email-alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-11-17  8:50     ` Arnd Bergmann
2015-11-16  1:01 ` [PATCH v5 00/11] exynos-ufs: add support for Exynos Alim Akhtar
2015-11-17  5:30   ` Kishon Vijay Abraham I [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564ABB64.3080001@ti.com \
    --to=kishon@ti.com \
    --cc=JBottomley@odin.com \
    --cc=alim.akhtar@gmail.com \
    --cc=alim.akhtar@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=essuuj@gmail.com \
    --cc=gautam.vivek@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=vinholikatti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).