Re: [PATCH v2 net-next] net: hisilicon: fix binding document of mdio

[huangdaode <huangdaode-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>]

On 2015/11/16 23:20, Rob Herring wrote:
> On Mon, Nov 16, 2015 at 05:38:24PM +0800, huangdaode wrote:
>> This patch explains the occasion of "hisilcon,mdio" and
>> "hisilicon,hns-mdio" according to Arnd's comments.
>> and reformat it according to comments from Rob<robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>.
>>
>> chang log:
>>
>> v2:
>>    1) reformat the style.
>>    2) make it more clearity.
>>
>> v1:
>>    initial version.
>>
>> Signed-off-by: huangdaode <huangdaode-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
>> ---
>>   Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt
>> index 9c23fdf..4942d20 100644
>> --- a/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt
>> +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt
>> @@ -1,7 +1,12 @@
>>   Hisilicon MDIO bus controller
>>   
>>   Properties:
>> -- compatible: "hisilicon,mdio","hisilicon,hns-mdio".
>> +- compatible: can be one of:
>> +	"hisilicon,hns-mdio"
>> +	"hisilicon,mdio"
>> +  "hisilicon,hns-mdio" is recommendly to be used for hip05 and later SOCs,
> s/recommendly/recommended/
>
>> +  while "hisilicon,mdio" is optional for backwards compatibility, only
>> +  support for hip04 Soc.
> ...compatibility only on hip04 SOC.
>
>>   - reg: The base address of the MDIO bus controller register bank.
>>   - #address-cells: Must be <1>.
>>   - #size-cells: Must be <0>.  MDIO addresses have no size component.
>> -- 
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Agreed.
Will fix this in v3 patch.

thanks
Daode.

> .
>


-- 
Best Regards
Daode Huang


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html