From: Salil Mehta <salil.mehta@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
paul.gortmaker@windriver.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, catalin.marinas@arm.com,
will.deacon@arm.com, arnd@arndb.de, liguozhu@hisilicon.com,
yisen.zhuang@huawei.com, dingtianhong@huawei.com,
zhangfei.gao@linaro.org, huangdaode@hisilicon.com,
kenneth-lee-2012@foxmail.com, mehta.salil.lnk@gmail.com,
xuwei5@hisilicon.com, lisheng011@huawei.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linuxarm@huawei.com, yankejian@huawei.com, lipeng321@huawei.com,
fengguang.wu@intel.com
Subject: Re: [PATCH V2 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem
Date: Fri, 20 Nov 2015 14:15:09 +0000 [thread overview]
Message-ID: <564F2AED.30906@huawei.com> (raw)
In-Reply-To: <20151118.135250.2066223916643044258.davem@davemloft.net>
On 11/18/2015 6:52 PM, David Miller wrote:
> From: Salil <salil.mehta@huawei.com>
> Date: Wed, 18 Nov 2015 02:52:23 +0800
>
>> @@ -387,19 +409,23 @@ static void hns_rcb_ring_get_cfg(struct hnae_queue *q, int ring_type)
>> struct rcb_common_cb *rcb_common;
>> struct ring_pair_cb *ring_pair_cb;
>> u32 buf_size;
>> - u16 desc_num;
>> - int irq_idx;
>> + u16 desc_num, mdnum_ppkt;
>> + int irq_idx, is_ver1;
> Please use "bool" and true/false for boolean conditions like is_ver1.
>
> Please audit your entire submission for this problem.
Thanks for your time and comments. As per your suggestions, I have
changed the data type of variable "is_ver" to "bool" where ever possible
in the PATCH V3 floated yesterday.
Best Regards
Salil
next prev parent reply other threads:[~2015-11-20 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 18:52 [PATCH V2 net-next 0/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem Salil
2015-11-17 18:52 ` [PATCH V2 net-next 1/5] " Salil
[not found] ` <1447786347-147518-2-git-send-email-salil.mehta-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-11-18 18:52 ` David Miller
2015-11-20 14:15 ` Salil Mehta [this message]
2015-11-17 18:52 ` [PATCH V2 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver Salil
2015-11-17 18:52 ` [PATCH V2 net-next 3/5] net:hns: Add Hip06 "TSO(TCP Segment Offload)" support " Salil
2015-11-17 18:52 ` [PATCH V2 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS Salil
2015-11-17 18:52 ` [PATCH V2 net-next 5/5] net:hns: Add the init code to disable Hip06 "Hardware VLAN assist" Salil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564F2AED.30906@huawei.com \
--to=salil.mehta@huawei.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dingtianhong@huawei.com \
--cc=fengguang.wu@intel.com \
--cc=galak@codeaurora.org \
--cc=huangdaode@hisilicon.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kenneth-lee-2012@foxmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=lisheng011@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mehta.salil.lnk@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
--cc=yankejian@huawei.com \
--cc=yisen.zhuang@huawei.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).