devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: santosh shilimkar <santosh.shilimkar@oracle.com>
To: Murali Karicheri <m-karicheri2@ti.com>,
	ssantosh@kernel.org, corbet@lwn.net, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	linux@arm.linux.org.uk, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: keystone: k2l: fix kernel crash when clk_ignore_unused is not in bootargs
Date: Mon, 23 Nov 2015 10:17:03 -0800	[thread overview]
Message-ID: <5653581F.4060902@oracle.com> (raw)
In-Reply-To: <1448297649-22122-1-git-send-email-m-karicheri2@ti.com>

On 11/23/2015 8:54 AM, Murali Karicheri wrote:
> Currently kernel crash randomly when K2L EVM is booted without
> clk_ignore_unused in the bootargs. This workaround is not needed
> on other K2 devices such as K2HK and K2E and with this fix, we can
> remove the workaround altogether. netcp driver on K2L uses linked
> ram on OSR (On chip Static RAM) and requires the clock to this peripheral
> enabled for proper functioning. This is the reason for the kernel crash.
> So add the clock node to fix this issue.
>
> While at it, remove the workaround documentation as well.
>
> With the fix applied, clk_summary dump shows the clock to OSR enabled.
>
> cat /sys/kernel/debug/clk/clk_summary
>   ------cut--------------
>     tcp3d-1                   0            0   399360000          0 0
>     tcp3d-0                   0            0   399360000          0 0
>     osr                       1            1   399360000          0 0
>     fftc-0                    0            0   399360000          0 0
>   -----cut----------------
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> ---
Nice !!
I will queue this up for fixes. Thanks.

Regards,
Santosh

      reply	other threads:[~2015-11-23 18:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23 16:54 [PATCH] ARM: dts: keystone: k2l: fix kernel crash when clk_ignore_unused is not in bootargs Murali Karicheri
2015-11-23 18:17 ` santosh shilimkar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5653581F.4060902@oracle.com \
    --to=santosh.shilimkar@oracle.com \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=m-karicheri2@ti.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).