From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v5 0/2] simplefb: Add regulator handling support Date: Tue, 24 Nov 2015 13:00:46 +0200 Message-ID: <5654435E.3060202@ti.com> References: <1447734663-19189-1-git-send-email-wens@csie.org> Reply-To: tomi.valkeinen-l0cyMroinI0@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ncefJ31MsxRgxs7D4FUpbuCAAmhD2aQfu" Return-path: In-Reply-To: <1447734663-19189-1-git-send-email-wens-jdAy2FN1RRM@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Jean-Christophe Plagniol-Villard , Hans de Goede Cc: Mark Brown , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org --ncefJ31MsxRgxs7D4FUpbuCAAmhD2aQfu Content-Type: text/plain; charset=UTF-8 On 17/11/15 06:31, Chen-Yu Tsai wrote: > Hi everyone, > > This is v5 of the simplefb regulator support series. This series adds > regulator claiming and enabling support for simplefb. > > Hans, I dropped your Reviewed-by tag from patch 2 since v4. > > Changes since v5: > - Rebased onto v4.4-rc1 > - Dropped dts patches (merged) > > Changes since v4: > - Fixed inverted logic when testing the property name. > - Fixed regulator supply name string copy length off by 1. > - Added real world user, MSI Primo 81 dts patches. > > Changes since v3: > - Dropped extra "if" which is always true, leftover from v1. > - Updated commit message of patch 1 > > Sometimes the simplefb display output path consits of external conversion > chips and/or LCD drivers and backlights. These devices normally have > GPIOs to turn them on and/or bring them out of reset, and regulators > supplying power to them. > > While the kernel does not touch unclaimed GPIOs, the regulator core > happily disables unused regulators. Thus we need simplefb to claim > and enable the regulators used throughout the display pipeline. > > The binding supports any named regulator supplies under its device > node. The driver will look through its properties, and claim any > regulators by matching "*-supply", as Mark suggested. > > I've not done a generic helper in the regulator core yet, instead doing > the regulator property handling in the simplefb code for now. > > > Patch 1 adds the regulator properties to the DT binding. > > Patch 2 adds code to the simplefb driver to claim and enable regulators. > > Regards > ChenYu > > > Chen-Yu Tsai (2): > dt-bindings: simplefb: Support regulator supply properties > simplefb: Claim and enable regulators > > .../bindings/display/simple-framebuffer.txt | 13 ++- > drivers/video/fbdev/simplefb.c | 120 ++++++++++++++++++++- > 2 files changed, 128 insertions(+), 5 deletions(-) > Thanks, queued for 4.5. Tomi --ncefJ31MsxRgxs7D4FUpbuCAAmhD2aQfu--