From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuge Subject: Re: Re: [PATCH v2 1/5] ARM: dts: sun8i: Add SID node Date: Wed, 25 Nov 2015 09:22:56 +0800 Message-ID: <56550D70.6060109@gmail.com> References: <20151123124356.GW32142@lukather> <20151124093202.GL32142@lukather> Reply-To: shugelinux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20151124093202.GL32142@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: linux-sunxi , atx-MwjtXicnQwU@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, gpatchesrdh-I1/eAgTnXDYAvxtiuMwx3w@public.gmane.org, mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On Monday, November 23, 2015 at 17:32 UTC+8, Maxime Ripard wrote: > On Mon, Nov 23, 2015 at 10:51:15PM -0800, Sugar Wu wrote: >> On Monday, November 23, 2015 at 8:43:59 PM UTC+8, Maxime Ripard wrote: >>> >>> Hi, >>> >>> On Mon, Nov 23, 2015 at 09:02:48AM +0100, Josef Gajdusek wrote: >>>> Add a node describing the Security ID memory to the >>>> Allwinner H3 .dtsi file. >>>> >>>> Signed-off-by: Josef Gajdusek > >>>> --- >>>> arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi >>> b/arch/arm/boot/dts/sun8i-h3.dtsi >>>> index 0faa38a..58de718 100644 >>>> --- a/arch/arm/boot/dts/sun8i-h3.dtsi >>>> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi >>>> @@ -359,6 +359,13 @@ >>>> #size-cells = <0>; >>>> }; >>>> >>>> + sid: eeprom@01c14000 { >>>> + compatible = "allwinner,sun4i-a10-sid"; >>>> + reg = <0x01c14000 0x400>; >>> >>> The datasheet says it's 256 bytes wide, while the size here is of 1kB, >>> is it intentional? >> >> SID memory map is 0x01c14000 ~ 0x01c143FF, include 2048bits efuse space. >> H3 efuse space is SID_SRAM, its range is 0x01c14200 ~ +0x100. > > Interesting, what is below the 0x200 registers? > Some control register about SID. offset: 0x40 SID Program/Read Control Register offset: 0x50 SID Program Key Value Register offset: 0x60 SID Read Key Value Register offset: 0x70 \ offset: 0x80 SJTAG Attribute 0 Register offset: 0x84 SJTAG Attribute 1 Register offset: 0x88 SJTAG Select Register offset: 0x90 SID Program Ctrol register for burned timing > > Thanks! > Maxime >