devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] arm64: dts: add all hi6220 i2c nodes
@ 2015-11-25  9:49 Xinwei Kong
       [not found] ` <1448444942-5780-1-git-send-email-kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
  2015-11-25 12:24 ` Shawn Guo
  0 siblings, 2 replies; 4+ messages in thread
From: Xinwei Kong @ 2015-11-25  9:49 UTC (permalink / raw)
  To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
	mark.rutland-5wv7dgnIgG8, galak-sgV2jX0FEOL9JmXXK+q4OQ,
	catalin.marinas-5wv7dgnIgG8, will.deacon-5wv7dgnIgG8,
	tyler.baker-QSEj5FYQhm4dnm+yROfE0A, arnd-r2nGTMty4D4,
	bintian.wang-hv44wF8Li93QT0dZR+AlfA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q
  Cc: puck.chen-C8/M+/jPZTeaMJb+Lgu22Q, liguozhu-C8/M+/jPZTeaMJb+Lgu22Q,
	w.f-hv44wF8Li93QT0dZR+AlfA

This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc
use this I2C IP of Synopsys Designware for HiKey board.

Signed-off-by: Xinwei Kong <kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
Signed-off-by: Chen Feng <puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
---
 arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 37 +++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index 82d2488..6b591a9 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -208,5 +208,42 @@
 			clock-names = "uartclk", "apb_pclk";
 			status = "disabled";
 		};
+
+		i2c0: i2c@f7100000 {
+			compatible = "snps,designware-i2c";
+			reg = <0x0 0xf7100000 0x0 0x1000>;
+			interrupts = <0 44 4>;
+			clocks = <&sys_ctrl HI6220_I2C0_CLK>;
+			clock-names = "clk_i2c0";
+			i2c-sda-hold-time-ns = <300>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;
+			status = "ok";
+		};
+
+		i2c1: i2c@f7101000 {
+			compatible = "snps,designware-i2c";
+			reg = <0x0 0xf7101000 0x0 0x1000>;
+			interrupts = <0 45 4>;
+			clocks = <&sys_ctrl HI6220_I2C1_CLK>;
+			clock-names = "clk_i2c1";
+			i2c-sda-hold-time-ns = <300>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&i2c1_pmx_func &i2c1_cfg_func>;
+			status = "ok";
+		};
+
+		i2c2: i2c@f7102000 {
+			compatible = "snps,designware-i2c";
+			reg = <0x0 0xf7102000 0x0 0x1000>;
+			interrupts = <0 46 4>;
+			clocks = <&sys_ctrl HI6220_I2C2_CLK>;
+			clock-names = "clk_i2c2";
+			i2c-sda-hold-time-ns = <300>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&i2c2_pmx_func &i2c2_cfg_func>;
+			status = "ok";
+		};
+
 	};
 };
-- 
1.9.1


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] arm64: dts: add all hi6220 i2c nodes
       [not found] ` <1448444942-5780-1-git-send-email-kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
@ 2015-11-25 10:35   ` Xinwei Kong
  0 siblings, 0 replies; 4+ messages in thread
From: Xinwei Kong @ 2015-11-25 10:35 UTC (permalink / raw)
  To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
	mark.rutland-5wv7dgnIgG8, galak-sgV2jX0FEOL9JmXXK+q4OQ,
	catalin.marinas-5wv7dgnIgG8, will.deacon-5wv7dgnIgG8,
	tyler.baker-QSEj5FYQhm4dnm+yROfE0A, arnd-r2nGTMty4D4,
	bintian.wang-hv44wF8Li93QT0dZR+AlfA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA
  Cc: puck.chen-C8/M+/jPZTeaMJb+Lgu22Q, liguozhu-C8/M+/jPZTeaMJb+Lgu22Q,
	w.f-hv44wF8Li93QT0dZR+AlfA

+to linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

On 2015/11/25 17:49, Xinwei Kong wrote:
> This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc
> use this I2C IP of Synopsys Designware for HiKey board.
> 
> Signed-off-by: Xinwei Kong <kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
> Signed-off-by: Chen Feng <puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 37 +++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 82d2488..6b591a9 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -208,5 +208,42 @@
>  			clock-names = "uartclk", "apb_pclk";
>  			status = "disabled";
>  		};
> +
> +		i2c0: i2c@f7100000 {
> +			compatible = "snps,designware-i2c";
> +			reg = <0x0 0xf7100000 0x0 0x1000>;
> +			interrupts = <0 44 4>;
> +			clocks = <&sys_ctrl HI6220_I2C0_CLK>;
> +			clock-names = "clk_i2c0";
> +			i2c-sda-hold-time-ns = <300>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;
> +			status = "ok";
> +		};
> +
> +		i2c1: i2c@f7101000 {
> +			compatible = "snps,designware-i2c";
> +			reg = <0x0 0xf7101000 0x0 0x1000>;
> +			interrupts = <0 45 4>;
> +			clocks = <&sys_ctrl HI6220_I2C1_CLK>;
> +			clock-names = "clk_i2c1";
> +			i2c-sda-hold-time-ns = <300>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&i2c1_pmx_func &i2c1_cfg_func>;
> +			status = "ok";
> +		};
> +
> +		i2c2: i2c@f7102000 {
> +			compatible = "snps,designware-i2c";
> +			reg = <0x0 0xf7102000 0x0 0x1000>;
> +			interrupts = <0 46 4>;
> +			clocks = <&sys_ctrl HI6220_I2C2_CLK>;
> +			clock-names = "clk_i2c2";
> +			i2c-sda-hold-time-ns = <300>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&i2c2_pmx_func &i2c2_cfg_func>;
> +			status = "ok";
> +		};
> +
>  	};
>  };
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] arm64: dts: add all hi6220 i2c nodes
  2015-11-25  9:49 [PATCH 1/1] arm64: dts: add all hi6220 i2c nodes Xinwei Kong
       [not found] ` <1448444942-5780-1-git-send-email-kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
@ 2015-11-25 12:24 ` Shawn Guo
  2015-11-26  3:16   ` Xinwei Kong
  1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2015-11-25 12:24 UTC (permalink / raw)
  To: Xinwei Kong
  Cc: robh+dt, pawel.moll, mark.rutland, galak, catalin.marinas,
	will.deacon, tyler.baker, arnd, bintian.wang, devicetree,
	linux-arm-kernel, linux-kernel, puck.chen, liguozhu, w.f

On Wed, Nov 25, 2015 at 05:49:02PM +0800, Xinwei Kong wrote:
> This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc
> use this I2C IP of Synopsys Designware for HiKey board.
> 
> Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 37 +++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 82d2488..6b591a9 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -208,5 +208,42 @@
>  			clock-names = "uartclk", "apb_pclk";
>  			status = "disabled";
>  		};
> +
> +		i2c0: i2c@f7100000 {
> +			compatible = "snps,designware-i2c";
> +			reg = <0x0 0xf7100000 0x0 0x1000>;
> +			interrupts = <0 44 4>;
> +			clocks = <&sys_ctrl HI6220_I2C0_CLK>;
> +			clock-names = "clk_i2c0";
> +			i2c-sda-hold-time-ns = <300>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;
> +			status = "ok";

Shouldn't it be set "disabled" in <soc>.dtsi and let <board>.dts enable
it per board design?

Shawn

> +		};
> +
> +		i2c1: i2c@f7101000 {
> +			compatible = "snps,designware-i2c";
> +			reg = <0x0 0xf7101000 0x0 0x1000>;
> +			interrupts = <0 45 4>;
> +			clocks = <&sys_ctrl HI6220_I2C1_CLK>;
> +			clock-names = "clk_i2c1";
> +			i2c-sda-hold-time-ns = <300>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&i2c1_pmx_func &i2c1_cfg_func>;
> +			status = "ok";
> +		};
> +
> +		i2c2: i2c@f7102000 {
> +			compatible = "snps,designware-i2c";
> +			reg = <0x0 0xf7102000 0x0 0x1000>;
> +			interrupts = <0 46 4>;
> +			clocks = <&sys_ctrl HI6220_I2C2_CLK>;
> +			clock-names = "clk_i2c2";
> +			i2c-sda-hold-time-ns = <300>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&i2c2_pmx_func &i2c2_cfg_func>;
> +			status = "ok";
> +		};
> +
>  	};
>  };
> -- 
> 1.9.1
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] arm64: dts: add all hi6220 i2c nodes
  2015-11-25 12:24 ` Shawn Guo
@ 2015-11-26  3:16   ` Xinwei Kong
  0 siblings, 0 replies; 4+ messages in thread
From: Xinwei Kong @ 2015-11-26  3:16 UTC (permalink / raw)
  To: Shawn Guo
  Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
	mark.rutland-5wv7dgnIgG8, galak-sgV2jX0FEOL9JmXXK+q4OQ,
	catalin.marinas-5wv7dgnIgG8, will.deacon-5wv7dgnIgG8,
	tyler.baker-QSEj5FYQhm4dnm+yROfE0A, arnd-r2nGTMty4D4,
	bintian.wang-hv44wF8Li93QT0dZR+AlfA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	puck.chen-C8/M+/jPZTeaMJb+Lgu22Q, liguozhu-C8/M+/jPZTeaMJb+Lgu22Q,
	w.f-hv44wF8Li93QT0dZR+AlfA

hi Shawn,

On 2015/11/25 20:24, Shawn Guo wrote:
> On Wed, Nov 25, 2015 at 05:49:02PM +0800, Xinwei Kong wrote:
>> This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc
>> use this I2C IP of Synopsys Designware for HiKey board.
>>
>> Signed-off-by: Xinwei Kong <kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
>> Signed-off-by: Chen Feng <puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
>> ---
>>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 37 +++++++++++++++++++++++++++++++
>>  1 file changed, 37 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> index 82d2488..6b591a9 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> @@ -208,5 +208,42 @@
>>  			clock-names = "uartclk", "apb_pclk";
>>  			status = "disabled";
>>  		};
>> +
>> +		i2c0: i2c@f7100000 {
>> +			compatible = "snps,designware-i2c";
>> +			reg = <0x0 0xf7100000 0x0 0x1000>;
>> +			interrupts = <0 44 4>;
>> +			clocks = <&sys_ctrl HI6220_I2C0_CLK>;
>> +			clock-names = "clk_i2c0";
>> +			i2c-sda-hold-time-ns = <300>;
>> +			pinctrl-names = "default";
>> +			pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;
>> +			status = "ok";
> 
> Shouldn't it be set "disabled" in <soc>.dtsi and let <board>.dts enable
> it per board design?
> 
> Shawn

get it.

thank you
xinwei
> 
>> +		};
>> +
>> +		i2c1: i2c@f7101000 {
>> +			compatible = "snps,designware-i2c";
>> +			reg = <0x0 0xf7101000 0x0 0x1000>;
>> +			interrupts = <0 45 4>;
>> +			clocks = <&sys_ctrl HI6220_I2C1_CLK>;
>> +			clock-names = "clk_i2c1";
>> +			i2c-sda-hold-time-ns = <300>;
>> +			pinctrl-names = "default";
>> +			pinctrl-0 = <&i2c1_pmx_func &i2c1_cfg_func>;
>> +			status = "ok";
>> +		};
>> +
>> +		i2c2: i2c@f7102000 {
>> +			compatible = "snps,designware-i2c";
>> +			reg = <0x0 0xf7102000 0x0 0x1000>;
>> +			interrupts = <0 46 4>;
>> +			clocks = <&sys_ctrl HI6220_I2C2_CLK>;
>> +			clock-names = "clk_i2c2";
>> +			i2c-sda-hold-time-ns = <300>;
>> +			pinctrl-names = "default";
>> +			pinctrl-0 = <&i2c2_pmx_func &i2c2_cfg_func>;
>> +			status = "ok";
>> +		};
>> +
>>  	};
>>  };
>> -- 
>> 1.9.1
>>
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
> 
> .
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-26  3:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-25  9:49 [PATCH 1/1] arm64: dts: add all hi6220 i2c nodes Xinwei Kong
     [not found] ` <1448444942-5780-1-git-send-email-kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
2015-11-25 10:35   ` Xinwei Kong
2015-11-25 12:24 ` Shawn Guo
2015-11-26  3:16   ` Xinwei Kong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).