From: Salil Mehta <salil.mehta-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Yuval Mintz <Yuval.Mintz-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"pawel.moll-5wv7dgnIgG8@public.gmane.org"
<pawel.moll-5wv7dgnIgG8@public.gmane.org>,
"mark.rutland-5wv7dgnIgG8@public.gmane.org"
<mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org"
<paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>,
"ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org"
<galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"catalin.marinas-5wv7dgnIgG8@public.gmane.org"
<catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
"will.deacon-5wv7dgnIgG8@public.gmane.org"
<will.deacon-5wv7dgnIgG8@public.gmane.org>,
"arnd-r2nGTMty4D4@public.gmane.org"
<arnd-r2nGTMty4D4@public.gmane.org>,
"liguozhu-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org"
<liguozhu-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
"yisen.zhuang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org"
<yisen.zhuang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
"dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org"
<dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
"zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"huangdaode-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org"
<huangdaode-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
"kenneth-lee-2012-H32Fclmsjq1BDgjK7y7TUQ@public.gmane.org"
<kenneth-lee-2012-H32Fclmsjq1BDgjK7y7TUQ@public.gmane.org>,
"mehta.salil.lnk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<mehta.sal>
Subject: Re: [PATCH V3 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver
Date: Thu, 26 Nov 2015 07:31:07 +0000 [thread overview]
Message-ID: <5656B53B.3080205@huawei.com> (raw)
In-Reply-To: <CO2PR11MB0088B852596B9F86F7BDCF6F97180-aWXWhCNu7Z/c7AgKY82GyJPPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
On 11/22/2015 9:30 AM, Yuval Mintz wrote:
>> static void hns_ppe_init_hw(struct hns_ppe_cb *ppe_cb) {
> ...
>> + /* Set default RSS key and indrection table*/
>> + const u32 rss_key[HNS_PPEV2_RSS_KEY_NUM] = {
>> + 0x6d5a56da, 0x255b0ec2,
>> + 0x4167253d, 0x43a38fb0,
>> + 0xd0ca2bcb, 0xae7b30b4,
>> + 0x77cb2da3, 0x8030f20c,
>> + 0x6a42b73b, 0xbeac01fa,
>> + };
>> +
>> + /* set default RSS key and remember it */
>> + for (i = 0; i < HNS_PPEV2_RSS_KEY_NUM; i++)
>> + ppe_cb->rss_key[i] = rss_key[i];
>>
> Is there any reason for the special default key?
> Why not use netdev_rss_key_fill()?
Thanks for pointing out this. I have incorported this change in latest
PATCH V5
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-26 7:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 20:58 [PATCH V3 net-next 0/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem Salil Mehta
[not found] ` <1447966706-16219-1-git-send-email-salil.mehta-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-11-19 20:58 ` [PATCH V3 net-next 1/5] " Salil Mehta
[not found] ` <1447966706-16219-2-git-send-email-salil.mehta-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-11-22 9:19 ` Yuval Mintz
2015-11-22 9:19 ` Yuval Mintz
[not found] ` <CO2PR11MB0088145308CE8BF0C504C9C497180-aWXWhCNu7Z/c7AgKY82GyJPPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2015-11-26 7:44 ` Salil Mehta
2015-11-19 20:58 ` [PATCH V3 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver Salil Mehta
[not found] ` <1447966706-16219-3-git-send-email-salil.mehta-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-11-22 9:30 ` Yuval Mintz
2015-11-22 9:30 ` Yuval Mintz
[not found] ` <CO2PR11MB0088B852596B9F86F7BDCF6F97180-aWXWhCNu7Z/c7AgKY82GyJPPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2015-11-26 7:31 ` Salil Mehta [this message]
2015-11-19 20:58 ` [PATCH V3 net-next 3/5] net:hns: Add Hip06 "TSO(TCP Segment Offload)" support " Salil Mehta
[not found] ` <1447966706-16219-4-git-send-email-salil.mehta-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-11-22 8:49 ` Yuval Mintz
2015-11-22 8:49 ` Yuval Mintz
[not found] ` <CO2PR11MB00885067453FB6462178765497180-aWXWhCNu7Z/c7AgKY82GyJPPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2015-11-26 8:19 ` Salil Mehta
2015-11-26 8:19 ` Salil Mehta
2015-11-19 20:58 ` [PATCH V3 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS Salil Mehta
2015-11-20 14:07 ` Sergei Shtylyov
2015-11-23 12:05 ` Salil Mehta
2015-11-19 20:58 ` [PATCH V3 net-next 5/5] net:hns: Add the init code to disable Hip06 "Hardware VLAN assist" Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5656B53B.3080205@huawei.com \
--to=salil.mehta-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=Yuval.Mintz-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=huangdaode-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=kenneth-lee-2012-H32Fclmsjq1BDgjK7y7TUQ@public.gmane.org \
--cc=liguozhu-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
--cc=yisen.zhuang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).