From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v8 02/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory Date: Fri, 27 Nov 2015 09:20:44 +0800 Message-ID: <5657AFEC.60004@rock-chips.com> References: <1446020143-32645-1-git-send-email-ykk@rock-chips.com> <1446020519-625-1-git-send-email-ykk@rock-chips.com> <1812354.kkj0DGG9mi@diego> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1812354.kkj0DGG9mi@diego> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?Q?Heiko_St=c3=bcbner?= Cc: Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Thierry Reding , Krzysztof Kozlowski , Rob Herring , Mark Yao , Russell King , djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Sean Paul , Kukjin Kim , Kumar Gala , emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , ajaynumb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org, Andy Yan , dri-deve List-Id: devicetree@vger.kernel.org Hi Heiko, Thanks you for feedback, I do see some conflicts in Exynos Make/Kconfig file [02/17] and dtsi file [07/17] when I try to apply this series on=20 4.4-rc1 branch. Hmm... Due to I have update some patches to version 10 already, this series may be become harder to reviewed, should I just send the whole series out that update the version to v10. Thanks - Yakir On 11/27/2015 01:30 AM, Heiko St=FCbner wrote: > Hi Yakir, > > Am Mittwoch, 28. Oktober 2015, 16:21:59 schrieb Yakir Yang: >> Split the dp core driver from exynos directory to bridge directory, >> and rename the core driver to analogix_dp_*, rename the platform >> code to exynos_dp. >> >> Beside the new analogix_dp driver would export four hooks. >> "analogix_dp_bind()" and "analogix_dp_unbind()" >> "analogix_dp_detect()" and "analogix_dp_get_modes()" >> >> The bind/unbind symbols is used for analogix platform driver to conn= ect >> with analogix_dp core driver. And the detect/get_modes is used for a= nalogix >> platform driver to init the connector. >> >> They reason why connector need register in helper driver is rockchip= drm >> haven't implement the atomic API, but Exynos drm have implement it, = so >> there would need two different connector helper functions, that's wh= y we >> leave the connector register in helper driver. >> >> Tested-by: Javier Martinez Canillas >> Signed-off-by: Yakir Yang > [...] > >> diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos= /Kconfig >> index bd1a415..5f74f80 100644 >> --- a/drivers/gpu/drm/exynos/Kconfig >> +++ b/drivers/gpu/drm/exynos/Kconfig >> @@ -55,8 +55,9 @@ config DRM_EXYNOS_DSI >> This enables support for Exynos MIPI-DSI device. >> >> config DRM_EXYNOS_DP >> - bool "EXYNOS DRM DP driver support" >> + bool "EXYNOS specific extensions for Analogix DP driver" >> depends on DRM_EXYNOS && (DRM_EXYNOS_FIMD || DRM_EXYNOS7_DECON) >> + select DRM_ANALOGIX_DP >> default DRM_EXYNOS >> select DRM_PANEL >> help > This doesn't apply anymore to 4.4-rc due to other changes in there. T= he > exynos/Makefile is affected as well. > > > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html