* [PATCH v7 0/2] ARM: dts: Facebook Yosemite 4 platform @ 2023-08-08 8:42 Delphine CC Chiu 2023-08-08 8:42 ` [PATCH v7 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite 4 board Delphine CC Chiu 2023-08-08 8:42 ` [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC Delphine CC Chiu 0 siblings, 2 replies; 8+ messages in thread From: Delphine CC Chiu @ 2023-08-08 8:42 UTC (permalink / raw) To: patrick Cc: Delphine CC Chiu, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Add linux device tree entry related to Yosemite 4 specific devices connected to BMC SoC. Changelog: v7 - Revise changelog format v6 - Change project name from yosemitev4 to yosemite4 v5 - Revise rtc setting - Remove duplicated multi-master setting v4 - Resend with cover letter v3 - Revise the bootargs to stdout-path - Revise i2c devices v2 - Revise the DTS node name v1 - Add binding document Delphine CC Chiu (2): dt-bindings: arm: aspeed: add Facebook Yosemite 4 board ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC .../bindings/arm/aspeed/aspeed.yaml | 1 + arch/arm/boot/dts/aspeed/Makefile | 1 + .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 633 ++++++++++++++++++ 3 files changed, 635 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts -- 2.25.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v7 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite 4 board 2023-08-08 8:42 [PATCH v7 0/2] ARM: dts: Facebook Yosemite 4 platform Delphine CC Chiu @ 2023-08-08 8:42 ` Delphine CC Chiu 2023-08-08 8:53 ` Krzysztof Kozlowski 2023-08-08 8:42 ` [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC Delphine CC Chiu 1 sibling, 1 reply; 8+ messages in thread From: Delphine CC Chiu @ 2023-08-08 8:42 UTC (permalink / raw) To: patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: Delphine CC Chiu, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Document the new compatibles used on Facebook Yosemite 4. Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> --- Changelog: v7 - Revise changelog format v6 - Change project name from yosemitev4 to yosemite4 --- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index e0eff4c05879..23ee325bfed0 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -79,6 +79,7 @@ properties: - facebook,elbert-bmc - facebook,fuji-bmc - facebook,greatlakes-bmc + - facebook,yosemite4-bmc - ibm,everest-bmc - ibm,rainier-bmc - ibm,tacoma-bmc -- 2.25.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v7 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite 4 board 2023-08-08 8:42 ` [PATCH v7 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite 4 board Delphine CC Chiu @ 2023-08-08 8:53 ` Krzysztof Kozlowski 0 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2023-08-08 8:53 UTC (permalink / raw) To: Delphine CC Chiu, patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On 08/08/2023 10:42, Delphine CC Chiu wrote: > Document the new compatibles used on Facebook Yosemite 4. > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC 2023-08-08 8:42 [PATCH v7 0/2] ARM: dts: Facebook Yosemite 4 platform Delphine CC Chiu 2023-08-08 8:42 ` [PATCH v7 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite 4 board Delphine CC Chiu @ 2023-08-08 8:42 ` Delphine CC Chiu 2023-08-08 8:53 ` Krzysztof Kozlowski 2023-08-09 8:05 ` Joel Stanley 1 sibling, 2 replies; 8+ messages in thread From: Delphine CC Chiu @ 2023-08-08 8:42 UTC (permalink / raw) To: patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: Delphine CC Chiu, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Add linux device tree entry related to Yosemite 4 specific devices connected to BMC SoC. Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> --- Changelog: v7 - Revise changelog format v6 - Change project name from yosemitev4 to yosemite4 v5 - Revise rtc setting - Remove duplicated multi-master setting v3 - Revise the bootargs to stdout-path - Revise i2c devices v2 - Revise the DTS node name --- arch/arm/boot/dts/aspeed/Makefile | 1 + .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 633 ++++++++++++++++++ 2 files changed, 634 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile index c68984322a86..5b9264b823f3 100644 --- a/arch/arm/boot/dts/aspeed/Makefile +++ b/arch/arm/boot/dts/aspeed/Makefile @@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-facebook-wedge400.dtb \ aspeed-bmc-facebook-yamp.dtb \ aspeed-bmc-facebook-yosemitev2.dtb \ + aspeed-bmc-facebook-yosemite4.dtb \ aspeed-bmc-ibm-bonnell.dtb \ aspeed-bmc-ibm-everest.dtb \ aspeed-bmc-ibm-rainier.dtb \ diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file mode 100644 index 000000000000..0791dea588b2 --- /dev/null +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts @@ -0,0 +1,633 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +// Copyright 2022 Facebook Inc. + +/dts-v1/; +#include "aspeed-g6.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> +#include <dt-bindings/leds/leds-pca955x.h> +#include <dt-bindings/i2c/i2c.h> + +/ { + model = "Facebook Yosemite 4 BMC"; + compatible = "facebook,yosemite4-bmc", "aspeed,ast2600"; + + aliases { + serial4 = &uart5; + serial5 = &uart6; + serial6 = &uart7; + serial7 = &uart8; + serial8 = &uart9; + }; + + chosen { + stdout-path = "serial4:57600n8"; + }; + + memory@80000000 { + device_type = "memory"; + reg = <0x80000000 0x80000000>; + }; + + iio-hwmon { + compatible = "iio-hwmon"; + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>, + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>, + <&adc1 0>, <&adc1 1>; + }; +}; + +&uart1 { + status = "okay"; +}; + +&uart2 { + status = "okay"; +}; + +&uart3 { + status = "okay"; +}; + +&uart4 { + status = "okay"; +}; + +&uart5 { + status = "okay"; +}; + +&uart6 { + status = "okay"; +}; + +&uart7 { + status = "okay"; +}; + +&uart8 { + status = "okay"; +}; + +&uart9 { + status = "okay"; +}; + +&wdt1 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_wdtrst1_default>; + aspeed,reset-type = "soc"; + aspeed,external-signal; + aspeed,ext-push-pull; + aspeed,ext-active-high; + aspeed,ext-pulse-duration = <256>; +}; + +&mac2 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii3_default>; + no-hw-checksum; + use-ncsi; + mlx,multi-host; + ncsi-ctrl,start-redo-probe; + ncsi-ctrl,no-channel-monitor; + ncsi-package = <1>; + ncsi-channel = <1>; + ncsi-rexmit = <1>; + ncsi-timeout = <2>; +}; + +&mac3 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii4_default>; + no-hw-checksum; + use-ncsi; + mlx,multi-host; + ncsi-ctrl,start-redo-probe; + ncsi-ctrl,no-channel-monitor; + ncsi-package = <1>; + ncsi-channel = <1>; + ncsi-rexmit = <1>; + ncsi-timeout = <2>; +}; + +&fmc { + status = "okay"; + flash@0 { + status = "okay"; + m25p,fast-read; + label = "bmc"; + spi-rx-bus-width = <4>; + spi-max-frequency = <50000000>; +#include "openbmc-flash-layout-64.dtsi" + }; + flash@1 { + status = "okay"; + m25p,fast-read; + label = "bmc2"; + spi-rx-bus-width = <4>; + spi-max-frequency = <50000000>; + }; +}; + +&i2c0 { + status = "okay"; + mctp-controller; + bus-frequency = <400000>; + multi-master; + + mctp@10 { + compatible = "mctp-i2c-controller"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + }; + + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c1 { + status = "okay"; + mctp-controller; + bus-frequency = <400000>; + multi-master; + + mctp@10 { + compatible = "mctp-i2c-controller"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + }; + + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c2 { + status = "okay"; + mctp-controller; + bus-frequency = <400000>; + multi-master; + + mctp@10 { + compatible = "mctp-i2c-controller"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + }; + + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c3 { + status = "okay"; + mctp-controller; + bus-frequency = <400000>; + multi-master; + + mctp@10 { + compatible = "mctp-i2c-controller"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + }; + + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c4 { + status = "okay"; + mctp-controller; + bus-frequency = <400000>; + multi-master; + + mctp@10 { + compatible = "mctp-i2c-controller"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + }; + + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c5 { + status = "okay"; + mctp-controller; + bus-frequency = <400000>; + multi-master; + + mctp@10 { + compatible = "mctp-i2c-controller"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + }; + + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c6 { + status = "okay"; + mctp-controller; + bus-frequency = <400000>; + multi-master; + + mctp@10 { + compatible = "mctp-i2c-controller"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + }; + + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c7 { + status = "okay"; + mctp-controller; + bus-frequency = <400000>; + multi-master; + + mctp@10 { + compatible = "mctp-i2c-controller"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + }; + + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c8 { + status = "okay"; + bus-frequency = <400000>; + i2c-mux@70 { + compatible = "nxp,pca9544"; + idle-state = <0>; + i2c-mux-idle-disconnect; + reg = <0x70>; + }; +}; + +&i2c9 { + status = "okay"; + bus-frequency = <400000>; + i2c-mux@71 { + compatible = "nxp,pca9544"; + idle-state = <0>; + i2c-mux-idle-disconnect; + reg = <0x71>; + }; +}; + +&i2c10 { + status = "okay"; + bus-frequency = <400000>; +}; + +&i2c11 { + status = "okay"; + bus-frequency = <400000>; + power-sensor@10 { + compatible = "adi, adm1272"; + reg = <0x10>; + }; + + power-sensor@12 { + compatible = "adi, adm1272"; + reg = <0x12>; + }; + + gpio@20 { + compatible = "nxp,pca9555"; + reg = <0x20>; + gpio-controller; + #gpio-cells = <2>; + }; + + gpio@21 { + compatible = "nxp,pca9555"; + reg = <0x21>; + gpio-controller; + #gpio-cells = <2>; + }; + + gpio@22 { + compatible = "nxp,pca9555"; + reg = <0x22>; + gpio-controller; + #gpio-cells = <2>; + }; + + gpio@23 { + compatible = "nxp,pca9555"; + reg = <0x23>; + gpio-controller; + #gpio-cells = <2>; + }; + + temperature-sensor@48 { + compatible = "ti,tmp75"; + reg = <0x48>; + }; + + temperature-sensor@49 { + compatible = "ti,tmp75"; + reg = <0x49>; + }; + + temperature-sensor@4a { + compatible = "ti,tmp75"; + reg = <0x4a>; + }; + + temperature-sensor@4b { + compatible = "ti,tmp75"; + reg = <0x4b>; + }; + + eeprom@54 { + compatible = "atmel,24c256"; + reg = <0x54>; + }; +}; + +&i2c12 { + status = "okay"; + bus-frequency = <400000>; + + temperature-sensor@48 { + compatible = "ti,tmp75"; + reg = <0x48>; + }; + + eeprom@50 { + compatible = "atmel,24c128"; + reg = <0x50>; + }; + + rtc@6f { + compatible = "nuvoton,nct3018y"; + reg = <0x6f>; + }; +}; + +&i2c13 { + status = "okay"; + bus-frequency = <400000>; +}; + +&i2c14 { + status = "okay"; + bus-frequency = <400000>; + adc@1d { + compatible = "ti,adc128d818"; + reg = <0x1d>; + ti,mode = /bits/ 8 <2>; + }; + + adc@35 { + compatible = "ti,adc128d818"; + reg = <0x35>; + ti,mode = /bits/ 8 <2>; + }; + + adc@37 { + compatible = "ti,adc128d818"; + reg = <0x37>; + ti,mode = /bits/ 8 <2>; + }; + + power-sensor@40 { + compatible = "ti,ina230"; + reg = <0x40>; + }; + + power-sensor@41 { + compatible = "ti,ina230"; + reg = <0x41>; + }; + + power-sensor@42 { + compatible = "ti,ina230"; + reg = <0x42>; + }; + + power-sensor@41 { + compatible = "ti,ina230"; + reg = <0x43>; + }; + + power-sensor@44 { + compatible = "ti,ina230"; + reg = <0x44>; + }; + + temperature-sensor@4e { + compatible = "ti,tmp75"; + reg = <0x4e>; + }; + + temperature-sensor@4f { + compatible = "ti,tmp75"; + reg = <0x4f>; + }; + + eeprom@51 { + compatible = "atmel,24c128"; + reg = <0x51>; + }; + + i2c-mux@71 { + compatible = "nxp,pca9846"; + idle-state = <0>; + i2c-mux-idle-disconnect; + reg = <0x71>; + + i2c@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + adc@1f { + compatible = "ti,adc128d818"; + reg = <0x1f>; + ti,mode = /bits/ 8 <2>; + }; + + pwm@20{ + compatible = "max31790"; + reg = <0x20>; + #address-cells = <1>; + #size-cells = <0>; + }; + + gpio@22{ + compatible = "ti,tca6424"; + reg = <0x22>; + }; + + pwm@23{ + compatible = "max31790"; + reg = <0x23>; + #address-cells = <1>; + #size-cells = <0>; + }; + + adc@33 { + compatible = "maxim,max11615"; + reg = <0x33>; + }; + + eeprom@52 { + compatible = "atmel,24c128"; + reg = <0x52>; + }; + + gpio@61 { + compatible = "nxp,pca9552"; + reg = <0x61>; + #address-cells = <1>; + #size-cells = <0>; + gpio-controller; + #gpio-cells = <2>; + }; + }; + + i2c@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + adc@1f { + compatible = "ti,adc128d818"; + reg = <0x1f>; + ti,mode = /bits/ 8 <2>; + }; + + pwm@20{ + compatible = "max31790"; + reg = <0x20>; + #address-cells = <1>; + #size-cells = <0>; + }; + + gpio@22{ + compatible = "ti,tca6424"; + reg = <0x22>; + }; + + pwm@23{ + compatible = "max31790"; + reg = <0x23>; + #address-cells = <1>; + #size-cells = <0>; + }; + + adc@33 { + compatible = "maxim,max11615"; + reg = <0x33>; + }; + + eeprom@52 { + compatible = "atmel,24c128"; + reg = <0x52>; + }; + + gpio@61 { + compatible = "nxp,pca9552"; + reg = <0x61>; + #address-cells = <1>; + #size-cells = <0>; + gpio-controller; + #gpio-cells = <2>; + }; + }; + }; + + i2c-mux@73 { + compatible = "nxp,pca9544"; + idle-state = <0>; + i2c-mux-idle-disconnect; + reg = <0x73>; + + i2c@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + adc@35 { + compatible = "maxim,max11617"; + reg = <0x35>; + }; + }; + + i2c@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + adc@35 { + compatible = "maxim,max11617"; + reg = <0x35>; + }; + }; + }; +}; + +&i2c15 { + status = "okay"; + mctp-controller; + multi-master; + bus-frequency = <400000>; + + mctp@10 { + compatible = "mctp-i2c-controller"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + }; + + i2c-mux@72 { + compatible = "nxp,pca9544"; + idle-state = <0>; + i2c-mux-idle-disconnect; + reg = <0x72>; + }; +}; + +&adc0 { + ref_voltage = <2500>; + status = "okay"; + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default + &pinctrl_adc2_default &pinctrl_adc3_default + &pinctrl_adc4_default &pinctrl_adc5_default + &pinctrl_adc6_default &pinctrl_adc7_default>; +}; + +&adc1 { + ref_voltage = <2500>; + status = "okay"; + pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default>; +}; + + +&ehci0 { + status = "okay"; +}; + +&ehci1 { + status = "okay"; +}; + +&uhci { + status = "okay"; +}; -- 2.25.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC 2023-08-08 8:42 ` [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC Delphine CC Chiu @ 2023-08-08 8:53 ` Krzysztof Kozlowski 2023-08-09 8:05 ` Joel Stanley 1 sibling, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2023-08-08 8:53 UTC (permalink / raw) To: Delphine CC Chiu, patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On 08/08/2023 10:42, Delphine CC Chiu wrote: > Add linux device tree entry related to > Yosemite 4 specific devices connected to BMC SoC. > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC 2023-08-08 8:42 ` [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC Delphine CC Chiu 2023-08-08 8:53 ` Krzysztof Kozlowski @ 2023-08-09 8:05 ` Joel Stanley 2023-08-09 8:12 ` Joel Stanley 1 sibling, 1 reply; 8+ messages in thread From: Joel Stanley @ 2023-08-09 8:05 UTC (permalink / raw) To: Delphine CC Chiu Cc: patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On Tue, 8 Aug 2023 at 08:43, Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> wrote: > > Add linux device tree entry related to > Yosemite 4 specific devices connected to BMC SoC. Convention is to mention what kind of machine this is, to give us some context for review. "This is an x86 server" or similar. Take a look at existing aspeed device tree commits for inspiration. > +&mac2 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_rmii3_default>; > + no-hw-checksum; > + use-ncsi; > + mlx,multi-host; > + ncsi-ctrl,start-redo-probe; > + ncsi-ctrl,no-channel-monitor; > + ncsi-package = <1>; > + ncsi-channel = <1>; > + ncsi-rexmit = <1>; > + ncsi-timeout = <2>; None of these are properties that mainline Linux supports. Do you plan on sending patches for these? > +}; > + > +&mac3 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_rmii4_default>; > + no-hw-checksum; > + use-ncsi; > + mlx,multi-host; > + ncsi-ctrl,start-redo-probe; > + ncsi-ctrl,no-channel-monitor; > + ncsi-package = <1>; > + ncsi-channel = <1>; > + ncsi-rexmit = <1>; > + ncsi-timeout = <2>; > +}; ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC 2023-08-09 8:05 ` Joel Stanley @ 2023-08-09 8:12 ` Joel Stanley 2023-08-09 8:15 ` Joel Stanley 0 siblings, 1 reply; 8+ messages in thread From: Joel Stanley @ 2023-08-09 8:12 UTC (permalink / raw) To: Delphine CC Chiu Cc: patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On Wed, 9 Aug 2023 at 08:05, Joel Stanley <joel@jms.id.au> wrote: > > On Tue, 8 Aug 2023 at 08:43, Delphine CC Chiu > <Delphine_CC_Chiu@wiwynn.com> wrote: > > > > Add linux device tree entry related to > > Yosemite 4 specific devices connected to BMC SoC. There were also some of these annoying warnings. Please try to fix them up in your next version: ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:460.4-14: Warning (reg_format): /ahb/apb/bus@1e78a000/i2c-bus@780/i2c-mux@71/i2c@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:510.4-14: Warning (reg_format): /ahb/apb/bus@1e78a000/i2c-bus@780/i2c-mux@71/i2c@1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:567.4-14: Warning (reg_format): /ahb/apb/bus@1e78a000/i2c-bus@780/i2c-mux@73/i2c@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:578.4-14: Warning (reg_format): /ahb/apb/bus@1e78a000/i2c-bus@780/i2c-mux@73/i2c@1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:457.9-505.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@780/i2c-mux@71/i2c@0: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:457.9-505.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@780/i2c-mux@71/i2c@0: Relying on default #size-cells value ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:507.9-555.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@780/i2c-mux@71/i2c@1: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:507.9-555.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@780/i2c-mux@71/i2c@1: Relying on default #size-cells value ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:564.9-573.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@780/i2c-mux@73/i2c@0: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:564.9-573.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@780/i2c-mux@73/i2c@0: Relying on default #size-cells value ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:575.9-584.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@780/i2c-mux@73/i2c@1: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:575.9-584.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@780/i2c-mux@73/i2c@1: Relying on default #size-cells value ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC 2023-08-09 8:12 ` Joel Stanley @ 2023-08-09 8:15 ` Joel Stanley 0 siblings, 0 replies; 8+ messages in thread From: Joel Stanley @ 2023-08-09 8:15 UTC (permalink / raw) To: Delphine CC Chiu Cc: patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On Wed, 9 Aug 2023 at 08:12, Joel Stanley <joel@jms.id.au> wrote: > > On Wed, 9 Aug 2023 at 08:05, Joel Stanley <joel@jms.id.au> wrote: > > > > On Tue, 8 Aug 2023 at 08:43, Delphine CC Chiu > > <Delphine_CC_Chiu@wiwynn.com> wrote: > > > > > > Add linux device tree entry related to > > > Yosemite 4 specific devices connected to BMC SoC. > > There were also some of these annoying warnings. Please try to fix > them up in your next version: > > ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:460.4-14: > Warning (reg_format): > /ahb/apb/bus@1e78a000/i2c-bus@780/i2c-mux@71/i2c@0:reg: property has > invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)@@ -450,6 +450,9 @@ eeprom@51 { This silenced most of them: i2c-mux@71 { compatible = "nxp,pca9846"; + #address-cells = <1>; + #size-cells = <0>; + idle-state = <0>; i2c-mux-idle-disconnect; reg = <0x71>; @@ -557,6 +560,9 @@ gpio@61 { i2c-mux@73 { compatible = "nxp,pca9544"; + #address-cells = <1>; + #size-cells = <0>; + idle-state = <0>; i2c-mux-idle-disconnect; reg = <0x73>; And then this fixed the remaining one: @@ -423,7 +423,7 @@ power-sensor@42 { reg = <0x42>; }; - power-sensor@41 { + power-sensor@43 { compatible = "ti,ina230"; reg = <0x43>; }; Please fold in these changes in your next version. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-08-09 8:16 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-08-08 8:42 [PATCH v7 0/2] ARM: dts: Facebook Yosemite 4 platform Delphine CC Chiu 2023-08-08 8:42 ` [PATCH v7 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite 4 board Delphine CC Chiu 2023-08-08 8:53 ` Krzysztof Kozlowski 2023-08-08 8:42 ` [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC Delphine CC Chiu 2023-08-08 8:53 ` Krzysztof Kozlowski 2023-08-09 8:05 ` Joel Stanley 2023-08-09 8:12 ` Joel Stanley 2023-08-09 8:15 ` Joel Stanley
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).