From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B29DC4332F for ; Fri, 8 Apr 2022 07:22:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229817AbiDHHYJ (ORCPT ); Fri, 8 Apr 2022 03:24:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbiDHHYI (ORCPT ); Fri, 8 Apr 2022 03:24:08 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CD242AEE35 for ; Fri, 8 Apr 2022 00:22:05 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id 123-20020a1c1981000000b0038b3616a71aso4945974wmz.4 for ; Fri, 08 Apr 2022 00:22:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:organization:in-reply-to:content-transfer-encoding; bh=HwBqnOa1E0VlKqSq871tPPYQ3FcLKgr7WO5uW7Uw2Eo=; b=qPq7Ttkmagr0EKp8wlqfUPgVgLcoiaYn151NPeEAixOI0CRtf6dSduscBxufr4uM3v KH6eA4pvw+dWR78LOfdNN3ZtNEJvK9JgmWh+P3Id3JnSiC8VHbS2bobN47ktnZqN4erm gkjunFOKEuN8yf5oKbBjkvN05FLNImEXRVs+M3d9bSHAS0o6sw8eOUHHsYH4ib2rYcox U2WB+xTfDCb08r5MdnH5hAOrC9iKJ0kiGkUPozet3TWbUZ/lcY89Ljhj06OuvuhzHjkg wRCx7lS1XnZj1hc7nQ1OUw0t7TR8l+wWoGeOpAOib2Cw8qHXfPhiWeORgGFqh/nCNT7j b65Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=HwBqnOa1E0VlKqSq871tPPYQ3FcLKgr7WO5uW7Uw2Eo=; b=68bTykPKRYq1vcsbOUyPpkp0/ngSBZBvgJy8Wuy26fnrThf4om+91D/Cg1s79U31SL FtQcyv35+s30ibtw/yaJhqFJXKVtR/goH9mJ9wWZ2QBnLrzKGIcwztmcVJCEWVnRY4Qu qJa2aumxDB/amVVuhTY+G8KTQznSpyhm7w8nAHxzy3KcTQPncqEhCfXoBsBZsu2lBIJ+ HN3Pg+chm/qzTxFp+NYc5eBdCcvZmk98H0GLpxpHOAkRIf7TMzM23vyioGhKJr9D2sKS 8dgP5i5ROP5d6/EFaeyFGfFuTUnhBNSNlQLlMs1C1eJdHVxyhF847Gxa7cFHSyM/J3Jy EO+Q== X-Gm-Message-State: AOAM530X0NlZwBEXkxibCyt8TTKT6rC9OrEyhl+cFmEGMz6LIH6FCdrN Ry/5gqDsClYo3xfBxSRljnWaTQ== X-Google-Smtp-Source: ABdhPJww8AuspZpWbFyeaKBTt1PnhZvYHHposZmg6lmxyzorxCgMnc8+vMSOdc3trfi2NWE+I3bmpA== X-Received: by 2002:a05:600c:3b8c:b0:38c:b365:7220 with SMTP id n12-20020a05600c3b8c00b0038cb3657220mr15632000wms.120.1649402523902; Fri, 08 Apr 2022 00:22:03 -0700 (PDT) Received: from ?IPV6:2001:861:44c0:66c0:eacd:ce6:e294:acd1? ([2001:861:44c0:66c0:eacd:ce6:e294:acd1]) by smtp.gmail.com with ESMTPSA id az19-20020a05600c601300b0038cadf3aa69sm14084506wmb.36.2022.04.08.00.22.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Apr 2022 00:22:03 -0700 (PDT) Message-ID: <56595ef2-a0fa-a92f-596b-511828295229@baylibre.com> Date: Fri, 8 Apr 2022 09:22:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 2/2] arm64: dts: meson: align SPI NOR node name with dtschema Content-Language: en-US To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220407142159.293836-1-krzysztof.kozlowski@linaro.org> <20220407142159.293836-2-krzysztof.kozlowski@linaro.org> From: Neil Armstrong Organization: Baylibre In-Reply-To: <20220407142159.293836-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/04/2022 16:21, Krzysztof Kozlowski wrote: > The node names should be generic and SPI NOR dtschema expects "flash". > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/amlogic/meson-gx-libretech-pc.dtsi | 2 +- > arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dts | 2 +- > arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dts | 2 +- > arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 +- > arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 2 +- > arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gx-libretech-pc.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx-libretech-pc.dtsi > index 2d7032f41e4b..bcdf55f48a83 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gx-libretech-pc.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gx-libretech-pc.dtsi > @@ -416,7 +416,7 @@ &spifc { > pinctrl-names = "default"; > status = "okay"; > > - gd25lq128: spi-flash@0 { > + gd25lq128: flash@0 { > compatible = "jedec,spi-nor"; > #address-cells = <1>; > #size-cells = <1>; > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dts > index 2d769203f671..213a0705ebdc 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dts > @@ -298,7 +298,7 @@ &spifc { > pinctrl-0 = <&nor_pins>; > pinctrl-names = "default"; > > - w25q32: spi-flash@0 { > + w25q32: flash@0 { > #address-cells = <1>; > #size-cells = <1>; > compatible = "jedec,spi-nor"; > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dts > index 93d8f8aff70d..874f91c348ec 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dts > @@ -284,7 +284,7 @@ &spifc { > pinctrl-0 = <&nor_pins>; > pinctrl-names = "default"; > > - nor_4u1: spi-flash@0 { > + nor_4u1: flash@0 { > #address-cells = <1>; > #size-cells = <1>; > compatible = "jedec,spi-nor"; > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts > index 86bdc0baf032..f43c45daf7eb 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts > @@ -374,7 +374,7 @@ &spifc { > pinctrl-0 = <&nor_pins>; > pinctrl-names = "default"; > > - w25q32: spi-flash@0 { > + w25q32: flash@0 { > #address-cells = <1>; > #size-cells = <1>; > compatible = "winbond,w25q16", "jedec,spi-nor"; > diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi > index 3cf4ecb6d52e..c9705941e4ab 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi > @@ -458,7 +458,7 @@ &spifc { > pinctrl-0 = <&nor_pins>; > pinctrl-names = "default"; > > - w25q128: spi-flash@0 { > + w25q128: flash@0 { > #address-cells = <1>; > #size-cells = <1>; > compatible = "winbond,w25q128fw", "jedec,spi-nor"; > diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts > index f3f953225bf5..e3486f60645a 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts > @@ -121,7 +121,7 @@ &spifc { > pinctrl-0 = <&nor_pins>; > pinctrl-names = "default"; > > - spi-flash@0 { > + flash@0 { > #address-cells = <1>; > #size-cells = <1>; > compatible = "jedec,spi-nor"; Reviewed-by: Neil Armstrong