From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 440DE2D191C for ; Thu, 24 Jul 2025 12:24:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753359858; cv=none; b=X+7qINAqrCqVE/t3hC9sevMXbx6c/KPPw/1vkEj2z5EGzMhEyXKIkJzxYkxDFDFoYYb63JRKgM4m3A8DESEVagI8S6rl9MGfZm+H/7hWzxf4nYCr6kArfanPC5+oXZVAVy54j9RVUvqLS4jLhy4K1qfxgMXCOtVRS7QU9z3gDPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753359858; c=relaxed/simple; bh=Wj8k+LZ9ypk7cshOxTezUe0f1uo0ed1ov6Dko5eZRLM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M/PVpFsAPmAh1Vf5rSvMYn+cAV2Sp5iHTCdhdNCODlIoguJyF1iqr/I4b6NfOCeoNmspmz7fGYHMUDamd+NbpCCRrcY89ubmeF0aCUeHuofMsF9jLFLrHoC92Wnje9kiIMi8Mw7eiUeHCY7EC9NzufZcvIldH4k5kjv1+SmheUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XQKAa7pQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XQKAa7pQ" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56O9fC5p028528 for ; Thu, 24 Jul 2025 12:24:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= V1dVQ7o60lfQaW1OhD1N9qDwz1+DHJ+n9It7+EueNOQ=; b=XQKAa7pQDBQe7jY+ bNCv2CUsz+XKQvB4s/WVjY55X/H4ygN3BuwyGNl4ggGVzbkDNp0vTOh/9B9NHSja 4pNhbHGPOhSJOEv46cacMMe0uLN7zO8bOVHYO9GALll5VaYcBEcCNi4/r5tE2+BW 3kRdZcE6uvdY8BVP61RcJcf51jK54Dv0hZFgT83VQGhQ5ls1UMwE3yhFbDSd5N6/ bmOUwNaznG12++IoRgvRxEJYQpgAv9it+7p9eMo4bXz4NpBF3oHzqTJvA781wIuo 1p634aemIf08jzR1L9bixaQojoyP8cwt3LDOjd9V7s61y7p59PSohtPUJYxhmbje tuNwEg== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4826t1g0py-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 24 Jul 2025 12:24:14 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b3bde4d4d5cso765801a12.2 for ; Thu, 24 Jul 2025 05:24:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753359853; x=1753964653; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V1dVQ7o60lfQaW1OhD1N9qDwz1+DHJ+n9It7+EueNOQ=; b=ubhzuXUO1UBQ4+MBFyjr/x90Hgex9d2Oq752ycfD6V3hwMC8qWsRf1WV+s23lISl4S 5Gfl1TFpkR21ckqdGbupVJzL20d09C6Sx/mx4KxU6RkWCFs3QK7A0xFvTNnYteTgq9Nw r0fbNI1LUq/JkZsLJd8qc6r7aQZMSthZBR04e3EhbqHGOvwB9dHWMtB0P4NXjeQqjebk xjfc3pjHmgwTBfKOrxeLgbmB8knrpbFMIACmlZH3tTdCPJnDqi6eY4T75AHzZmP4cP2n 3ggKLrVyWzCSkaBR45u0StYgheWQUoVPEWGbCjskiso5z7l6n2EVhYdpz7Nle21g2i5Q ER7Q== X-Forwarded-Encrypted: i=1; AJvYcCV75DWNKRGV9zx8BtbaXGza0npqvi/LkA4WIK0oto5YDItKkQyzQeLlKjXOd0gzcrR3C2Xo+LTpR3n2@vger.kernel.org X-Gm-Message-State: AOJu0YyL0p+iglDfm2UF77qPi0zPvnekRpSbbm7v73XV/azN+5uyB0zR F/wLj0gCJUpzydzAF1mdolvMFVUldOR8OUB1ARUbsEGWF8uKFl5ffVJm3hBYXyB5Be5YMTnQdqq vBFP5OXq3GZ87ECt4fbE5gqEBu8dfqKxJFhhMmrznD46FVbK5/Xks2F6/Nk1Hvc4F X-Gm-Gg: ASbGnctTpURVr8jmfl9VSvfuwRNuDddlF6e5LMMQjT/5uDiTPhN1Hl/7D5OC6K19GCr 9IoFyboLK4zYukELpf4Wgq0zGzxEiVy1o4g1mbdHBQT7Wr1LdoPede0bpFPYrhiqyajZ7pcije/ ZurxiEPmqlyn1mvhM8+SM7NGQ8Z3n+ZgZb9WTWc5KFRpbgEEGyOBkyeK7VGFhxxhQjzvEumdvui uQR4iWUu+qmJ8QBJVucwlXCk7KO4F6pJfzeEoV499teTuaCysXI32rv7ZU9pbgkMZ4SFpOz4Hxw XpmZHwsZHtFRhqy8WoqfhNFJdPtxH8wbR/aKhKOTocJUPj4hBkuQl3ZvrAIuyvHLe8/UEETutA= = X-Received: by 2002:a17:903:240f:b0:234:d7b2:2ab9 with SMTP id d9443c01a7336-23f9814af72mr109485945ad.12.1753359853245; Thu, 24 Jul 2025 05:24:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1FdMA0poljbqQuKYh8fiEQSr0OOY0KXJdzE/FuO1KdXgKFoFLZXlo3+g/2LdSYkgJes+jag== X-Received: by 2002:a17:903:240f:b0:234:d7b2:2ab9 with SMTP id d9443c01a7336-23f9814af72mr109485125ad.12.1753359852692; Thu, 24 Jul 2025 05:24:12 -0700 (PDT) Received: from [10.219.57.35] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23fa475f3d3sm14862155ad.40.2025.07.24.05.24.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jul 2025 05:24:12 -0700 (PDT) Message-ID: <56599da9-0200-72b5-012e-942a1fc954b2@oss.qualcomm.com> Date: Thu, 24 Jul 2025 17:54:04 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v12 0/8] Implement vendor resets for PSCI SYSTEM_RESET2 To: Florian Fainelli , Bartosz Golaszewski , Bjorn Andersson , Sebastian Reichel , Rob Herring , Sudeep Holla , Souvik Chakravarty , Krzysztof Kozlowski , Conor Dooley , Andy Yan , Mark Rutland , Lorenzo Pieralisi , Arnd Bergmann , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, Vinod Koul , Catalin Marinas , Will Deacon Cc: Dmitry Baryshkov , Mukesh Ojha , Stephen Boyd , Andre Draszik , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Elliot Berman , Srinivas Kandagatla , Elliot Berman , Konrad Dybcio References: <20250721-arm-psci-system_reset2-vendor-reboots-v12-0-87bac3ec422e@oss.qualcomm.com> Content-Language: en-US From: Shivendra Pratap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: SWtSapy_pMkDxGhRaLTmx7tGmjRwehXA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzI0MDA5MyBTYWx0ZWRfX95JLy5j74bFD uXgUfrUNwULrKThFKXQaCDVHc97JmHJ6JBtsu/yYi/hWLTC2fSjUsIKu2qbhAfDzbLRMZ4DEo13 4TaP+HONrbgmqUfpe2VN4KDyrgS75/RJQag3bwHF8u28NkRf1fG6SIHsk8pGnmJaPvElpgO9gVy wv6VM4fRI8yJQ9apg3/8sNvWdyyXE+dz9G+qApdFTfpNg2k8CtRSVS09q++ZEJ3z3JeTJQ2nQsd 3y67TwVW0P21cj59gWDfE6CBKhPkIUndlLFDEXrjns7KRSixvydfhh6IbKv6BF8dmSgV6pcTGW2 ruqQn8Y96dNCRKToR7C96DJAIWI+pjx9jMe7+9HrXhcP8rblSuFHD4aTPfJbtmuXsHlzHZIPNmD TD/6sSiQCxB2Dvk+Jr7ofHot8STEyFoc4iCxzvZn/RMEUCE0U+lXVAuQzkAnv6kETmf5GddG X-Authority-Analysis: v=2.4 cv=E8/Npbdl c=1 sm=1 tr=0 ts=688225ee cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=Q-fNiiVtAAAA:8 a=TK8Ma2dr1QVmNkQoTrMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: SWtSapy_pMkDxGhRaLTmx7tGmjRwehXA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-24_02,2025-07-24_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 mlxlogscore=999 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507240093 On 7/24/2025 5:46 AM, Florian Fainelli wrote: > On 7/21/25 11:28, Shivendra Pratap wrote: >> The PSCI SYSTEM_RESET2 call allows vendor firmware to define >> additional reset types which could be mapped to the reboot >> argument. >> >> User-space should be able to reboot a device into different >> operational boot-states supported by underlying bootloader and >> firmware. Generally, some HW registers need to be written, based >> on which the bootloader and firmware decide the next boot state >> of device, after the reset. For example, a requirement on >> Qualcomm platforms may state that reboot with "bootloader" >> command, should reboot the device into bootloader flashing mode >> and reboot with “edl” command, should reboot the device into an >> Emergency flashing mode.  Setting up such reboots on Qualcomm >> devices can be inconsistent across SoC platforms and may require >> setting different HW registers, where some of these registers may >> not be accessible to HLOS. These knobs evolve over product >> generations and require more drivers.  PSCI defines a >> vendor-specific reset in SYSTEM_RESET2 spec, which enables the >> firmware to take care of underlying setting for any such >> supported vendor-specific reboot. Qualcomm firmwares are >> beginning to support and expose PSCI SYSTEM_RESET2 >> vendor-specific reset types to simplify driver requirements from >> Linux. With such support added in the firmware, we now need a >> Linux interface which can make use of the firmware calls for PSCI >> vendor-specific resets. This will align such reboot requirement >> across platforms and vendors. >> >> The current psci driver supports two types of resets – >> SYSTEM_RESET2 Arch warm-reset and SYSTEM_RESET cold-reset. The >> patchset introduces the PSCI SYSTEM_RESET2 vendor-specific reset >> into the reset path of the psci driver and aligns it to work with >> reboot system call - LINUX_REBOOT_CMD_RESTART2, when used along >> with a supported string-based command in “*arg”. >> >> The patchset uses reboot-mode based commands, to define the >> supported vendor reset-types commands in psci device tree node >> and registers these commands with the reboot-mode framework. >> >> The PSCI vendor-specific reset takes two arguments, being, >> reset_type and cookie as defined by the spec. To accommodate this >> requirement, enhance the reboot-mode framework to support two >> 32-bit arguments by switching to 64-bit magic values. >> >> Along this line, the patchset also extends the reboot-mode >> framework to add a non-device-based registration function, which >> will allow drivers to register using device tree node, while >> keeping backward compatibility for existing users of reboot-mode. >> This will enable psci driver to register for reboot-mode and >> implement a write function, which will save the magic and then >> use it in psci reset path to make a vendor-specific reset call >> into the firmware. In addition, the patchset will expose a sysfs >> entry interface within reboot-mode which can be used by userspace >> to view the supported reboot-mode commands. >> >> The list of vendor-specific reset commands remains open due to >> divergent requirements across vendors, but this can be >> streamlined and standardized through dedicated device tree >> bindings. >> >> Currently three drivers register with reboot-mode framework - >> syscon-reboot-mode, nvmem-reboot-mode and qcom-pon. Consolidated >> list of commands currently added across various vendor DTs: >>   mode-loader >>   mode-normal >>   mode-bootloader >>   mode-charge >>   mode-fastboot >>   mode-reboot-ab-update >>   mode-recovery >>   mode-rescue >>   mode-shutdown-thermal >>   mode-shutdown-thermal-battery >> >> Detailed list of commands being used by syscon-reboot-mode: >>      arm64/boot/dts/exynos/exynosautov9.dtsi: >>     mode-bootloader = ; >>     mode-fastboot = ; >>     mode-recovery = ; >> >>      arm64/boot/dts/exynos/google/gs101.dtsi: >>          mode-bootloader = <0xfc>; >>          mode-charge = <0x0a>; >>          mode-fastboot = <0xfa>; >>          mode-reboot-ab-update = <0x52>; >>          mode-recovery = <0xff>; >>          mode-rescue = <0xf9>; >>          mode-shutdown-thermal = <0x51>; >>          mode-shutdown-thermal-battery = <0x51>; >> >>      arm64/boot/dts/hisilicon/hi3660-hikey960.dts: >>          mode-normal = <0x77665501>; >>          mode-bootloader = <0x77665500>; >>          mode-recovery = <0x77665502>; >> >>      arm64/boot/dts/hisilicon/hi6220-hikey.dts: >>          mode-normal = <0x77665501>; >>          mode-bootloader = <0x77665500>; >>          mode-recovery = <0x77665502>; >> >>      arm64/boot/dts/rockchip/px30.dtsi: >>          mode-bootloader = ; >>          mode-fastboot = ; >>          mode-loader = ; >>          mode-normal = ; >>          mode-recovery = ; >> >>      arm64/boot/dts/rockchip/rk3308.dtsi: >>          mode-bootloader = ; >>          mode-loader = ; >>          mode-normal = ; >>          mode-recovery = ; >>          mode-fastboot = ; >> >>      arm64/boot/dts/rockchip/rk3566-lckfb-tspi.dts: >>          mode-normal = ; >>          mode-loader = ; >>             mode-recovery = ; >>             mode-bootloader = ; >> >> Detailed list of commands being used by nvmem-reboot-mode: >>      arm64/boot/dts/qcom/pmXXXX.dtsi:(multiple qcom DTs) >>             mode-recovery = <0x01>; >>             mode-bootloader = <0x02>; >> >> Previous discussions around SYSTEM_RESET2: >> - https://lore.kernel.org/lkml/20230724223057.1208122-2-quic_eberman@quicinc.com/T/ >> - https://lore.kernel.org/all/4a679542-b48d-7e11-f33a-63535a5c68cb@quicinc.com/ >> >> Signed-off-by: Elliot Berman >> Signed-off-by: Shivendra Pratap > > On ARCH_BRCMSTB: > > Tested-by: Florian Fainelli > > For the sysfs bits, should not we be seeing "psci" instead of "reboot-mode" twice in this path: > > # cat /sys/class/reboot-mode/reboot-mode/reboot_modes > powercycle As per current patch, we create a class named - "reboot-mode". /sys/class/reboot-mode Then comes the DT node name of the registering driver. /sys/class/reboot-mode/
/ Then the name of the sysfs which is set to "reboot_modes". For case of vendor reset, psci is parent and node name is reboot-mode, so its generalized to: /sys/class/reboot-mode/reboot-mode/reboot_modes -- We can discuss, how to keep it generalized and get some other name in sysfs. suggestions? > > ?