devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Ludovic Desroches <ludovic.desroches@atmel.com>,
	wsa@the-dreams.de, alexandre.belloni@free-electrons.com
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	plagnioj@jcrosoft.com, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 4/4] ARM: at91/dt: sama5d2 Xplained: pmic needs a specific sda hold time
Date: Thu, 3 Dec 2015 11:34:08 +0100	[thread overview]
Message-ID: <56601AA0.5020201@atmel.com> (raw)
In-Reply-To: <1449136434-27619-6-git-send-email-ludovic.desroches@atmel.com>

Le 03/12/2015 10:53, Ludovic Desroches a écrit :
> Data have to be held longer for the PMIC device. The ACT8945A
> datasheet claims that minimum SDA data hold time is about 300 ns.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>

Same here, we'll take this one with at91 material in at91-4.5-dt branch
soon.

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thanks, bye.

> ---
>  arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index ad6de73..9bced00 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -129,6 +129,7 @@
>  				dmas = <0>, <0>;
>  				pinctrl-names = "default";
>  				pinctrl-0 = <&pinctrl_i2c0_default>;
> +				i2c-sda-hold-time-ns = <350>;
>  				status = "okay";
>  
>  				pmic: act8865@5b {
> 


-- 
Nicolas Ferre

      reply	other threads:[~2015-12-03 10:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03  9:53 [PATCH v2 0/4] i2c: at91: add support for SDA HOLD Ludovic Desroches
     [not found] ` <1449136434-27619-1-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-12-03  9:53   ` [PATCH v2 1/4] i2c: at91: add support for the HOLD field Ludovic Desroches
     [not found]     ` <1449136434-27619-2-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-12-03 10:30       ` Nicolas Ferre
2015-12-03  9:53 ` [PATCH v2 1/4] i2c: at91: add upport " Ludovic Desroches
2015-12-03 10:08   ` Ludovic Desroches
2015-12-03  9:53 ` [PATCH v2 2/4] i2c: at91: update bindings documention Ludovic Desroches
2015-12-03 10:32   ` Nicolas Ferre
2015-12-03  9:53 ` [PATCH v2 3/4] ARM: at91/dt: sama5d4: update i2c compatible string Ludovic Desroches
2015-12-03 10:33   ` Nicolas Ferre
2015-12-03 20:45     ` Wolfram Sang
2015-12-03  9:53 ` [PATCH v2 4/4] ARM: at91/dt: sama5d2 Xplained: pmic needs a specific sda hold time Ludovic Desroches
2015-12-03 10:34   ` Nicolas Ferre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56601AA0.5020201@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).