From: "Yankejian (Hackim Yim)" <yankejian@huawei.com>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: mark.rutland@arm.com, wangkefeng.wang@huawei.com,
catalin.marinas@arm.com, will.deacon@arm.com,
linuxarm@huawei.com, haojian.zhuang@linaro.org,
haifeng.wei@huawei.com, xuwei5@hisilicon.com,
galak@codeaurora.org, dingtianhong@huawei.com,
Yisen.Zhuang@huawei.com, devicetree@vger.kernel.org,
bintian.wang@huawei.com, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, leo.yan@linaro.org,
robh+dt@kernel.org, liguozhu@huawei.com, netdev@vger.kernel.org,
sboyd@codeaurora.org, linux-kernel@vger.kernel.org,
wangzhou1@hisilicon.com, long.wanglong@huawei.com,
davem@davemloft.net
Subject: Re: [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio
Date: Mon, 7 Dec 2015 09:30:56 +0800 [thread overview]
Message-ID: <5664E150.4020402@huawei.com> (raw)
In-Reply-To: <5330584.WSWh7F8G32@wuerfel>
On 2015/12/6 6:15, Arnd Bergmann wrote:
> On Saturday 05 December 2015 15:56:57 yankejian wrote:
>> #size-cells = <0>;
>> compatible = "hisilicon,hns-mdio";
>> - reg = <0x0 0x803c0000 0x0 0x10000
>> - 0x0 0x80000000 0x0 0x10000>;
>> + reg = <0x0 0x803c0000 0x0 0x10000>;
>> + subctrl_vbase = <&peri_c_subctrl>;
>>
>> soc0_phy0: ethernet-phy@0 {
>> reg = <0x0>;
> I don't see the subctrl_vbase property documented in the binding. Please
> modify the binding as well.
>
> Also, please use the normal naming conventions using '-' instead of '_'
> inside of property names.
>
> Arnd
>
> .
Hi, Arnd
Thanks for your suggestions. i will fixes it later.
next prev parent reply other threads:[~2015-12-07 1:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-05 7:56 [PATCH RESEND net-next 0/3] dts: hisi: fixes can't find eth for hip05-D02 yankejian
2015-12-05 7:56 ` [PATCH RESEND net-next 1/3] dts: hisi: enables the ethX for D02 board yankejian
2015-12-05 12:53 ` kbuild test robot
2015-12-05 7:56 ` [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio yankejian
[not found] ` <1449302218-54374-3-git-send-email-yankejian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-12-05 22:15 ` Arnd Bergmann
2015-12-07 1:30 ` Yankejian (Hackim Yim) [this message]
2015-12-05 7:56 ` [PATCH RESEND net-next 3/3] arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board yankejian
[not found] ` <1449302218-54374-4-git-send-email-yankejian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-12-05 22:13 ` Arnd Bergmann
2015-12-07 1:29 ` Yankejian (Hackim Yim)
-- strict thread matches above, loose matches on Subject: below --
2015-12-05 7:54 [PATCH RESEND net-next 0/3] dts: hisi: fixes can't find eth for hip05-D02 yankejian
2015-12-05 7:54 ` [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio yankejian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5664E150.4020402@huawei.com \
--to=yankejian@huawei.com \
--cc=Yisen.Zhuang@huawei.com \
--cc=arnd@arndb.de \
--cc=bintian.wang@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dingtianhong@huawei.com \
--cc=galak@codeaurora.org \
--cc=haifeng.wei@huawei.com \
--cc=haojian.zhuang@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=leo.yan@linaro.org \
--cc=liguozhu@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=long.wanglong@huawei.com \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=wangkefeng.wang@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).