Re: [PATCH 09/16] ASoC: dt-bindings: add OpenPandora Sound Card

[Krzysztof Kozlowski <krzk@kernel.org>]

On 13/07/2026 10:27, H. Nikolaus Schaller wrote:
> Hi Krzysztof,
> 
> Thank you for the feedback.
> 
>> Am 13.07.2026 um 09:37 schrieb Krzysztof Kozlowski <krzk@kernel.org>:
>>
>> On Sat, Jul 11, 2026 at 08:01:56AM +0200, H. Nikolaus Schaller wrote:
>>> The OpenPandora audio subsystem describes the routing links between the
>>> OMAP3 McBSP interface, the external PCM1773 DAC, and the TWL4030 audio
>>> codec, alongside amplifiers and power supplies.
>>>
>>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>>> ---
>>> .../sound/openpandora,omap3pandora-sound.yaml | 94 +++++++++++++++++++
>>> 1 file changed, 94 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/sound/openpandora,omap3pandora-sound.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/sound/openpandora,omap3pandora-sound.yaml b/Documentation/devicetree/bindings/sound/openpandora,omap3pandora-sound.yaml
>>> new file mode 100644
>>> index 0000000000000..d3c747e5c58d6
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/sound/openpandora,omap3pandora-sound.yaml
>>> @@ -0,0 +1,94 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org
>>> +$schema: http://devicetree.org
>>
>> This wasn't ever tested. Why?
> 
> It does not emit any C compiler issues or runtime problems so it remained unnoticed.

I do not believe.

There is a clear warning from Rob's bot.

You just did not follow the process of building the code (compiler has
nothing to do here). Read submitting patches in DT dir and then writing
schema for further instructions. This is ABSOLUTE MINIMUM. We are not
your build test service.

> 
> It was notified by the sahiko-bot and will be fixed in v2.

Sashiko has nothing to do with that.

You DID NOT BUILD the code.

Best regards,
Krzysztof