From: Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>
To: Andre Przywara <andre.przywara-5wv7dgnIgG8@public.gmane.org>,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org
Cc: catalin.marinas-5wv7dgnIgG8@public.gmane.org,
will.deacon-5wv7dgnIgG8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
drjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 2/4] arm64: dts: Foundation model: increate GICC region to allow EOImode=1
Date: Wed, 09 Dec 2015 15:09:09 +0000 [thread overview]
Message-ID: <56684415.40806@arm.com> (raw)
In-Reply-To: <1444729069-27922-3-git-send-email-andre.przywara-5wv7dgnIgG8@public.gmane.org>
Hey Andre,
On 13/10/15 10:37, Andre Przywara wrote:
> Recent commits made the GIC driver use EOImode=1 for all GICs
> that advertise the proper GICC region size.
> To let the model benefit from the blessings of that mode, increase
> the GICC region to its actual size of 8K.
>
> Signed-off-by: Andre Przywara <andre.przywara-5wv7dgnIgG8@public.gmane.org>
The patch looks good, but the commit log is slightly confusing. Apart
from the typo in the title ("increate"), it would be better to say
something like:
"The Foundation model GIC mapping is wrong, as the GICC region should be
8kB instead of 4kB (the model implements the GICv2 architecture). This
defect prevents the driver from switching to EOImode==1."
Or something similar.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-09 15:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 9:37 [PATCH 0/4] add support for GICv3 on the Foundation model Andre Przywara
2015-10-13 9:37 ` [PATCH 1/4] arm64: dts: prepare foundation-v8.dts to cope with GICv3 Andre Przywara
2015-12-09 15:10 ` Marc Zyngier
[not found] ` <1444729069-27922-1-git-send-email-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2015-10-13 9:37 ` [PATCH 2/4] arm64: dts: Foundation model: increate GICC region to allow EOImode=1 Andre Przywara
[not found] ` <1444729069-27922-3-git-send-email-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2015-10-13 10:42 ` Marc Zyngier
2015-12-09 15:09 ` Marc Zyngier [this message]
2015-10-13 9:37 ` [PATCH 3/4] arm64: dts: split Foundation model dts to put the GIC separately Andre Przywara
2015-12-09 15:11 ` Marc Zyngier
2015-10-13 9:37 ` [PATCH 4/4] arm64: dts: add .dts for GICv3 Foundation model Andre Przywara
[not found] ` <1444729069-27922-5-git-send-email-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2015-10-13 10:44 ` Marc Zyngier
[not found] ` <561CE098.2030906-5wv7dgnIgG8@public.gmane.org>
2015-10-13 19:04 ` Andre Przywara
2015-12-09 15:12 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56684415.40806@arm.com \
--to=marc.zyngier-5wv7dgnigg8@public.gmane.org \
--cc=andre.przywara-5wv7dgnIgG8@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=drjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).