From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2] extcon: add Maxim MAX3355 driver Date: Tue, 15 Dec 2015 01:29:19 +0300 Message-ID: <566F42BF.30109@cogentembedded.com> References: <5045536.UEVncNCOZE@wasted.cogentembedded.com> <20151214012400.GA9506@rob-hp-laptop> <566EFE0A.4000104@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , MyungJoo Ham , Chanwoo Choi , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , SH-Linux , Linux USB List List-Id: devicetree@vger.kernel.org Hello. On 12/15/2015 01:21 AM, Rob Herring wrote: >>>> Maxim Integrated MAX3355E chip integrates a charge pump and comparators >>>> to >>>> enable a system with an integrated USB OTG dual-role transceiver to >>>> function >>>> as an USB OTG dual-role device. In addition to sensing/controlling >>>> Vbus, >>>> the chip also passes thru the ID signal from the USB OTG connector. >>>> On some Renesas boards, this signal is just fed into the SoC thru a >>>> GPIO >>>> pin -- there's no real OTG controller, only host and gadget USB >>>> controllers >>>> sharing the same USB bus; however, we'd like to allow host or gadget >>>> drivers >>>> to be loaded depending on the cable type, hence the need for the MAX3355 >>>> extcon driver. The Vbus status signals are also wired to GPIOs (however, >>>> we >>>> aren't currently interested in them), the OFFVBUS# signal is controlled >>>> by >>>> the host controllers, there's also the SHDN# signal wired to a GPIO, it >>>> should be driven high for the normal operation. >>> >>> >>> As multiple people have said, fix the spacing here. >> >> >> You are the first to complain abou _this_ patch. If you don't have other >> issues with this driver in which case you should have trimmed the reply at >> this point), I'd like to keep my spacing as is. Thank you. > > Your previous version was not "extcon-usb-gpio: add enable pin > support"[1] which has now been re-written to be max3355 specific? No, the MAX3355 driver pre-dates that version. First there was a driver, then I tried to re-use the existing stuff (there was no extcon-usb-gpio at the time of writing my driver), then had to return to the separate driver idea... > "So > what" and "I'd like to keep my spacing as is" aren't valid reasons. > Fix it, then I'll look at the rest again. I'll consider doing that if you care to explain what's the problem with my spacing. TIA. > Rob MBR, Sergei