From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Murzin Subject: Re: [PATCH v1 02/10] clockevents/drivers: add MPS2 Timer driver Date: Tue, 15 Dec 2015 12:47:59 +0000 Message-ID: <56700BFF.90001@arm.com> References: <1449048790-25859-1-git-send-email-vladimir.murzin@arm.com> <1449048790-25859-3-git-send-email-vladimir.murzin@arm.com> <566EC5D2.9050005@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <566EC5D2.9050005-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Daniel Lezcano , arnd-r2nGTMty4D4@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, afaerber-l3A5Bk7waGM@public.gmane.org, mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: Mark.Rutland-5wv7dgnIgG8@public.gmane.org, Pawel.Moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, jslaby-AlSwsSmVLrQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 14/12/15 13:36, Daniel Lezcano wrote: > On 12/02/2015 10:33 AM, Vladimir Murzin wrote: >> MPS2 platform has simple 32 bits general purpose countdown timers. >> >> The driver uses the first detected timer as a clocksource and the rest >> of the timers as a clockevent >> >> Signed-off-by: Vladimir Murzin >> --- > > [ ... ] > >> +static void clockevent_mps2_writel(u32 val, struct clock_event_device >> *c, u32 offset) >> +{ >> + writel(val, to_mps2_clkevt(c)->reg + offset); >> +} > > Is it possible to use writel_relaxed here ? I think it is possible. I'll update that part. > > [ ... ] > >> +static int mps2_timer_set_periodic(struct clock_event_device *ce) >> +{ >> + u32 clock_count_per_tick = to_mps2_clkevt(ce)->clock_count_per_tick; >> + >> + clockevent_mps2_writel(clock_count_per_tick, ce, TIMER_RELOAD); >> + clockevent_mps2_writel(clock_count_per_tick, ce, TIMER_VALUE); >> + clockevent_mps2_writel(TIMER_CTRL_IE | TIMER_CTRL_ENABLE, ce, >> TIMER_CTRL); >> + >> + return 0; >> +} >> + >> +static irqreturn_t mps2_timer_interrupt(int irq, void *dev_id) >> +{ >> + struct clockevent_mps2 *ce = dev_id; >> + u32 status = readl(ce->reg + TIMER_INT); >> + >> + if (!status) { >> + pr_warn("spuirous interrupt\n"); > > typo: 'spurious' > > [ ... ] > >> + ce = kzalloc(sizeof(struct clockevent_mps2), GFP_KERNEL); >> + if (!ce) { >> + ret = -ENOMEM; >> + pr_err("failed to allocate clockevent: %d\n", ret); > > There is already a stack trace in the kernel when an allocation fails. > > With the above fixed: > > Acked-by: Daniel Lezcano > > All above fixed locally. Thanks Vladimir -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html