From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: Re: [PATCH 0/5] ARM: dts: sunxi: Add backlight node to q8 tablets Date: Mon, 21 Dec 2015 13:59:59 +0100 Message-ID: <5677F7CF.3050308@redhat.com> References: <1442752251-20744-1-git-send-email-hdegoede@redhat.com> Reply-To: hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Return-path: In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Silvio Pellicano <8001010-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-sunxi Cc: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On 21-12-15 11:56, Silvio Pellicano wrote: > > >> Here is a slightly updated version of Chen-Yu's backlight >> patches, also adding support for the backlight found on A13 >> based q8 tablets. >> > > If i compile your dtsi with (obviously) pwm support enable , backlight > switch off after kernel start, > if i disable pwm in menuconfig,it stay on, all seem correct (pwm on PB2 in > original script.bin), > but there is somewhere a bug in pwm or dtsi description of backlight. No there is not, if you enable the pwm driver you must also enable the backlight-pwm driver / add CONFIG_BACKLIGHT_PWM=y to your .config (and make sure it stays that way after a "make oldconfig"). Regards, Hans