From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Roland Stigge <stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/3] arm: dts: phy3250: add SD fixed regulator
Date: Mon, 21 Dec 2015 20:04:03 +0300 [thread overview]
Message-ID: <56783103.3070008@cogentembedded.com> (raw)
In-Reply-To: <56782FCA.2050504-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
On 12/21/2015 07:58 PM, Vladimir Zapolskiy wrote:
>>> The change adds fixed voltage regulator for SD controller, ARM MMCI
>>> controller driver uses it to control card power management.
>>>
>>> Signed-off-by: Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
>>> ---
>>> arch/arm/boot/dts/phy3250.dts | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/phy3250.dts b/arch/arm/boot/dts/phy3250.dts
>>> index 34e15fd..5465b9e 100644
>>> --- a/arch/arm/boot/dts/phy3250.dts
>>> +++ b/arch/arm/boot/dts/phy3250.dts
>>> @@ -45,6 +45,15 @@
>>> enable-active-high;
>>> regulator-boot-on;
>>> };
>>> +
>>> + sd_reg: fixed-regulator@2 {
>>
>> Please just "regulator@2", to comply with the ePAPR standard.
>
> thanks for review, just for my information, do I understand correctly
> that you reference to "Generic Names Recommendation" ?
Sure, AKA 2.2.2. :-)
> I have no objection to generalize device tree node name as you
> suggested, will do it.
TIA.
> With best wishes,
> Vladimir
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-21 17:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 23:32 [PATCH 0/3] arm: lpc32xx: remove direct control of GPIOs from shared mach file Vladimir Zapolskiy
[not found] ` <1450567932-22994-1-git-send-email-vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
2015-12-19 23:32 ` [PATCH 1/3] arm: dts: phy3250: add lcd and backlight fixed regulators Vladimir Zapolskiy
2015-12-19 23:32 ` [PATCH 2/3] arm: dts: phy3250: add SD fixed regulator Vladimir Zapolskiy
[not found] ` <1450567932-22994-3-git-send-email-vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
2015-12-19 23:48 ` Russell King - ARM Linux
[not found] ` <20151219234848.GT8644-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-12-20 2:14 ` Vladimir Zapolskiy
2015-12-20 2:22 ` [PATCH v2 " Vladimir Zapolskiy
2015-12-21 12:43 ` [PATCH " Sergei Shtylyov
[not found] ` <5677F3DC.6070402-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2015-12-21 16:58 ` Vladimir Zapolskiy
[not found] ` <56782FCA.2050504-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
2015-12-21 17:04 ` Sergei Shtylyov [this message]
2015-12-19 23:32 ` [PATCH 3/3] arm: lpc32xx: remove direct control of GPIOs from shared mach file Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56783103.3070008@cogentembedded.com \
--to=sergei.shtylyov-m4dtvfq/zs1mrggop+s0pdbpr1lh4cv8@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org \
--cc=vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).