From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v5] extcon: add Maxim MAX3355 driver Date: Mon, 21 Dec 2015 22:38:22 +0300 Message-ID: <5678552E.3010709@cogentembedded.com> References: <5948633.my3nAG6hRz@wasted.cogentembedded.com> <5676E214.2040009@cogentembedded.com> <5677662C.6060409@samsung.com> <5677DC21.3040509@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5677DC21.3040509@cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org To: Chanwoo Choi Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "myungjoo.ham@samsung.com" , devicetree , linux-kernel , linux-sh@vger.kernel.org, linux-usb@vger.kernel.org List-Id: devicetree@vger.kernel.org Hello. On 12/21/2015 02:01 PM, Sergei Shtylyov wrote: >>>> This patch depend on GPIOLIB configuration as following: >>>> I modified it with following diff and applied it. >>>> >>>> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig >>>> index ba4db7d..3d89e60 100644 >>>> --- a/drivers/extcon/Kconfig >>>> +++ b/drivers/extcon/Kconfig >>>> @@ -54,6 +54,7 @@ config EXTCON_MAX14577 >>>> >>>> config EXTCON_MAX3355 >>>> tristate "Maxim MAX3355 USB OTG EXTCON Support" >>>> + depends on GPIOLIB || COMPILE_TEST >>> >>> If it won't compile w/o gpiolib, what's the use of COMIPLE_TEST? >>> And no, it shouldn't depend on gpiolib. It has empty stubs for the case >>> of CONFIG_GPIOLIB=n. Obviously something is wrong with the GPIO headers, >>> I'll look into it. >> >> Yes. When GPIOLIB is disabled, the build issue don't happen. > > What? It surely does happen! > >> because include/linux/gpio/consumer.h implement the dummy function >> for all gpio functions if CONFIG_GPIOLIB is disabled. > > Linus W. advised to #include this header explicitly -- I'll try and post. I see you already #include'd it, thanks. But in that case, doesn't seem necessary. >> Thanks, >> Chanwoo Choi MBR, Sergei