From mboxrd@z Thu Jan 1 00:00:00 1970 From: Milo Kim Subject: Re: [PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO Date: Mon, 28 Dec 2015 10:05:27 +0900 Message-ID: <56808AD7.9080305@ti.com> References: <1450868319-20513-1-git-send-email-contact@paulk.fr> <1450868319-20513-3-git-send-email-contact@paulk.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1450868319-20513-3-git-send-email-contact@paulk.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Paul Kocialkowski Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , Tony Lindgren , Mark Brown , linux-kernel@vger.kernel.org, Liam Girdwood , Rob Herring , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Kumar Gala , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 23/12/15 19:58, Paul Kocialkowski wrote: > The lp872x structure holds a reference to the DVS GPIO, but it is never actually > used anywhere, since a first reference exists from the lp872x_dvs structure. > > Signed-off-by: Paul Kocialkowski Acked-by: Milo Kim > --- > drivers/regulator/lp872x.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/regulator/lp872x.c b/drivers/regulator/lp872x.c > index 9412353..19d7584 100644 > --- a/drivers/regulator/lp872x.c > +++ b/drivers/regulator/lp872x.c > @@ -108,7 +108,6 @@ struct lp872x { > struct lp872x_platform_data *pdata; > int num_regulators; > enum lp872x_dvs_state dvs_pin; > - int dvs_gpio; > }; > > /* LP8720/LP8725 shared voltage table for LDOs */ > @@ -752,7 +751,6 @@ static int lp872x_init_dvs(struct lp872x *lp) > } > > lp->dvs_pin = pinstate; > - lp->dvs_gpio = gpio; > > return 0; > >