From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH 4/4] soc: mediatek: Add MT2701/MT7623 scpsys driver Date: Fri, 8 Jan 2016 12:26:29 +0100 Message-ID: <568F9CE5.7040601@gmail.com> References: <1451457706-14798-1-git-send-email-jamesjj.liao@mediatek.com> <1451457706-14798-5-git-send-email-jamesjj.liao@mediatek.com> <1451470692.22426.11.camel@mtksdaap41> <5684192B.4020806@gmail.com> <1451971439.19026.3.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1451971439.19026.3.camel@mtksdaap41> Sender: linux-kernel-owner@vger.kernel.org To: James Liao Cc: Daniel Kurtz , "open list:OPEN FIRMWARE AND..." , srv_heupstream , Kevin Hilman , "linux-kernel@vger.kernel.org" , "moderated list:ARM/Mediatek SoC support" , Shunli Wang , Sascha Hauer , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On 05/01/16 06:23, James Liao wrote: > Hi Matthias, > On Wed, 2015-12-30 at 18:49 +0100, Matthias Brugger wrote: >>> On Wed, 2015-12-30 at 17:01 +0800, Daniel Kurtz wrote: >>>> On Wed, Dec 30, 2015 at 2:41 PM, James Liao wrote: >>>>> >>>>> From: Shunli Wang >>>>> >>>>> Add scpsys driver for MT2701 and MT7623. >>>>> >>>>> Signed-off-by: Shunli Wang >>>>> Signed-off-by: James Liao >>>>> --- >>>>> drivers/soc/mediatek/Kconfig | 11 +++ >>>>> drivers/soc/mediatek/Makefile | 1 + >>>>> drivers/soc/mediatek/mtk-scpsys-mt2701.c | 161 +++++++++++++++++++++++++++++++ >>>>> 3 files changed, 173 insertions(+) >>>>> create mode 100644 drivers/soc/mediatek/mtk-scpsys-mt2701.c >>>>> >>>>> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig >>>>> index eca6fb7..92cf838 100644 >>>>> --- a/drivers/soc/mediatek/Kconfig >>>>> +++ b/drivers/soc/mediatek/Kconfig >>>>> @@ -39,3 +39,14 @@ config MTK_SCPSYS_MT8173 >>>>> driver. >>>>> The System Control Processor System (SCPSYS) has several power >>>>> management related tasks in the system. >>>>> + >>>>> +config MTK_SCPSYS_MT2701 >>>>> + bool "SCPSYS Support MediaTek MT2701 and MT7623" >>>>> + depends on ARCH_MEDIATEK || COMPILE_TEST >>>>> + select MTK_SCPSYS >>>>> + default ARCH_MEDIATEK >>>>> + help >>>>> + Say yes here to add support for the MT2701/MT7623 SCPSYS power >>>>> + domain driver. >>>>> + The System Control Processor System (SCPSYS) has several power >>>>> + management related tasks in the system. >>>> >>>> I don't think we really want different drivers and Kconfig options. >>>> >>>> Can we just use different compatibles to select the appropriate scp_domain_data? >>> >>> Yes, we can. All scpsys drivers are built-in by default, and they will >>> be activate by specific compatible string. >>> >>> But some projects don't want to build unused drivers into kernel to save >>> code size. Use different Kconfig options for each SoC so that these >>> projects can disable unused drivers. >>> >> >> Scpsys is a bool right now, you can disable it if you don't need it for >> your project. >> >> I don't think the impact of adding scp_domain_data justifies adding SoC >> specific scpsys drivers and bloat the drivers/soc/mediatek folder. > > So you prefer to enable MT8173 and MT2701 scpsys drivers at the same > time if MTK_SCPSYS is true? Well the driver gets enabled by the compatible string from the DT binding passed to the system. But yes, I prefer to have the code shared and just add the necessary data structures. > > BTW, this patchset is based on 4.4-rc7, which lacks two patches from > your v4.4-next/soc. Should I rebase to v4.4-next/soc when I send v2 > patch? > That would be a nice to have. Thanks, Matthias