From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Taniya Das <quic_tdas@quicinc.com>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/5] bindings: clock: qcom: Add "qcom,adsp-skip-pll" property
Date: Thu, 8 Feb 2024 09:15:44 +0100 [thread overview]
Message-ID: <568c26db-45c4-4a62-9504-738d78007802@linaro.org> (raw)
In-Reply-To: <20240208062836.19767-2-quic_tdas@quicinc.com>
On 08/02/2024 07:28, Taniya Das wrote:
> When remoteproc is used to boot the LPASS the ADSP PLL should not be
> configured from the high level OS. Thus add support for property to
> avoid configuring the LPASS PLL.
>
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
You nicely bypassed all my filters.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
Anyway, I don't understand point of this commit. Aren't you now
duplicating qcom,adsp-pil-mode?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-08 8:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 6:28 [PATCH 0/5] Add updates for clock controllers to support QCM6490 Taniya Das
2024-02-08 6:28 ` [PATCH 1/5] bindings: clock: qcom: Add "qcom,adsp-skip-pll" property Taniya Das
2024-02-08 6:59 ` Dmitry Baryshkov
2024-03-06 6:54 ` Taniya Das
2024-02-08 8:15 ` Krzysztof Kozlowski [this message]
2024-03-06 6:53 ` Taniya Das
2024-03-07 7:52 ` Krzysztof Kozlowski
2024-02-08 6:28 ` [PATCH 2/5] clk: qcom: lpassaudiocc-sc7280: Add support to skip PLL configuration Taniya Das
2024-02-08 7:02 ` Dmitry Baryshkov
2024-03-06 6:55 ` Taniya Das
2024-03-06 7:53 ` Dmitry Baryshkov
2024-04-23 12:35 ` Konrad Dybcio
2024-02-08 6:28 ` [PATCH 3/5] clk: qcom: sc7280: Update the transition delay for GDSC Taniya Das
2024-02-08 7:03 ` Dmitry Baryshkov
2024-03-06 6:54 ` Taniya Das
2024-02-08 6:28 ` [PATCH 4/5] clk: qcom: camcc-sc7280: Add parent dependency to all camera GDSCs Taniya Das
2024-02-08 7:04 ` Dmitry Baryshkov
2024-02-08 6:28 ` [PATCH 5/5] arm64: dts: qcom: Update protected clocks list for qcm6490 variants Taniya Das
2024-02-08 7:14 ` Dmitry Baryshkov
2024-03-06 6:54 ` Taniya Das
2024-03-06 7:54 ` Dmitry Baryshkov
2024-02-09 16:37 ` Bjorn Andersson
2024-03-06 6:54 ` Taniya Das
2024-02-09 16:46 ` Konrad Dybcio
2024-03-06 6:54 ` Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568c26db-45c4-4a62-9504-738d78007802@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).