From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH] rtc: max77xxx: fix of_table.cocci warnings Date: Tue, 12 Jan 2016 16:50:58 +0530 Message-ID: <5694E19A.2050107@nvidia.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Julia Lawall Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, k.kozlowski@samsung.com List-Id: devicetree@vger.kernel.org Hi Julia, Thanks for pointing this issue. What script do you run to get this error? I tried to run script/coccicheck and it did not showed this issue. When I run make with coccicheck per Documentation, it did not show specific to this error. Although, there was lots of output. I want to get this type of error by running script. Any command for this? Thanks, Laxman On Tuesday 12 January 2016 04:57 PM, Julia Lawall wrote: > Make sure (of/i2c/platform)_device_id tables are NULL terminated > > Generated by: scripts/coccinelle/misc/of_table.cocci > > CC: Laxman Dewangan > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall > --- > > Please take the patch only if it's a positive warning. Thanks! > > rtc-max77xxx.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/rtc/rtc-max77xxx.c > +++ b/drivers/rtc/rtc-max77xxx.c > @@ -480,6 +480,7 @@ static const struct platform_device_id m > { .name = "max77xxx-rtc", }, > { .name = "max77620-rtc", }, > { .name = "max20024-rtc", }, > + {}, > }; > > static struct platform_driver max77xxx_rtc_driver = {