From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: andy.gross@linaro.org, linux-arm-msm@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] arm64: dts: apq8016-sbc: add regulators support
Date: Tue, 12 Jan 2016 14:30:34 +0000 [thread overview]
Message-ID: <56950E0A.2000005@linaro.org> (raw)
In-Reply-To: <7998607.BblzgPxGPW@wuerfel>
On 12/01/16 13:59, Arnd Bergmann wrote:
> On Tuesday 12 January 2016 13:46:32 Srinivas Kandagatla wrote:
>> };
>>
>> + smd {
>> + rpm {
>> + rpm-requests {
>> + pm8916-regulators {
>> +
>> + vdd_l1_l2_l3-supply = <&pm8916_s3>;
>> + vdd_l5-supply = <&pm8916_s3>;
>> + vdd_l4_l5_l6-supply = <&pm8916_s4>;
>> + vdd_l7-supply = <&pm8916_s4>;
>> +
>>
>
> If you're nested this deeply, you should consider using labels, e.g.
>
Labels are good and works for me.
Stephen/Andy are you ok to use labels for such deeply nested nodes in
board dts?
> / {
> ...
>
> smd {
> rpm {
> rpm-requests {
> regulators: pm8916-regulators {
>
> };
> };
> };
> };
>
> ...
> };
>
>
> ®ulators {
> vdd_l1_l2_l3-supply = <&pm8916_s3>;
> vdd_l5-supply = <&pm8916_s3>;
> vdd_l4_l5_l6-supply = <&pm8916_s4>;
> vdd_l7-supply = <&pm8916_s4>;
>
> s1 {
> regulator-min-microvolt = <375000>;
> regulator-max-microvolt = <1562000>;
> };
>
> s3 {
> regulator-min-microvolt = <375000>;
> regulator-max-microvolt = <1562000>;
> };
>
> ...
> };
>
> btw, it seems odd to me that all those nodes under 'smd'
> have names but no addresses.
These regulators are identified by the node names, and have no addresses
associated with it as control goes over SMD based IPC to the rpm.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.txt?id=refs/tags/next-20160112
--srini
>
> Arnd
>
next prev parent reply other threads:[~2016-01-12 14:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 13:45 [PATCH 0/5] arm64: dts: apq8016-sbc dt patches Srinivas Kandagatla
2016-01-12 13:46 ` [PATCH 1/5] arm64: dts: apq8016-sbc: add regulators support Srinivas Kandagatla
2016-01-12 13:59 ` Arnd Bergmann
2016-01-12 14:30 ` Srinivas Kandagatla [this message]
2016-01-12 22:22 ` Andy Gross
2016-01-12 13:46 ` [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node Srinivas Kandagatla
2016-01-12 14:00 ` Arnd Bergmann
2016-01-12 14:18 ` Srinivas Kandagatla
2016-01-12 14:49 ` Arnd Bergmann
[not found] ` <56950B4D.3030707-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-01-12 22:25 ` Andy Gross
2016-01-12 13:47 ` [PATCH 3/5] arm64: dts: remove s2 regulator from smd regulators Srinivas Kandagatla
2016-01-12 13:47 ` [PATCH 4/5] arm64: dts: apq8016-sbc: make 1.8v available on LS expansion Srinivas Kandagatla
2016-01-12 13:47 ` [PATCH 5/5] arm64: dts: apq8016-sbc: Add real regulators and pinctrl for sdhc Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56950E0A.2000005@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=andy.gross@linaro.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).