* [PATCH 1/2] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes
@ 2023-05-16 15:33 Tim Harvey
2023-05-16 15:33 ` [PATCH 2/2] arm64: dts: imx8mm-venice-gw700x Tim Harvey
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tim Harvey @ 2023-05-16 15:33 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Li Yang,
devicetree, linux-kernel, Tim Harvey
Remove the unnecessary #address-cells and #size-cells nodes from
the fan-controller.
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
.../devicetree/bindings/mfd/gateworks-gsc.yaml | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
index acb9c54942d9..dc379f3ebf24 100644
--- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
+++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
@@ -122,12 +122,6 @@ patternProperties:
compatible:
const: gw,gsc-fan
- "#address-cells":
- const: 1
-
- "#size-cells":
- const: 0
-
reg:
description: The fan controller base address
maxItems: 1
@@ -135,8 +129,6 @@ patternProperties:
required:
- compatible
- reg
- - "#address-cells"
- - "#size-cells"
required:
- compatible
@@ -194,8 +186,6 @@ examples:
};
fan-controller@2c {
- #address-cells = <1>;
- #size-cells = <0>;
compatible = "gw,gsc-fan";
reg = <0x2c>;
};
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] arm64: dts: imx8mm-venice-gw700x
2023-05-16 15:33 [PATCH 1/2] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes Tim Harvey
@ 2023-05-16 15:33 ` Tim Harvey
2023-05-16 21:20 ` [PATCH 1/2] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes Conor Dooley
2023-05-17 8:42 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Tim Harvey @ 2023-05-16 15:33 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Li Yang,
devicetree, linux-kernel, Tim Harvey
Remove the unnecessary #address-cells and #size-cells nodes from
the fan-controller.
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
index 9e7d38872157..72cf250d9b4f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
@@ -234,8 +234,6 @@ channel@a2 {
};
fan-controller@0 {
- #address-cells = <1>;
- #size-cells = <0>;
compatible = "gw,gsc-fan";
reg = <0x0a>;
};
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes
2023-05-16 15:33 [PATCH 1/2] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes Tim Harvey
2023-05-16 15:33 ` [PATCH 2/2] arm64: dts: imx8mm-venice-gw700x Tim Harvey
@ 2023-05-16 21:20 ` Conor Dooley
2023-05-17 8:42 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2023-05-16 21:20 UTC (permalink / raw)
To: Tim Harvey
Cc: linux-arm-kernel, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Li Yang, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1613 bytes --]
Hey Tim,
On Tue, May 16, 2023 at 08:33:13AM -0700, Tim Harvey wrote:
> Remove the unnecessary #address-cells and #size-cells nodes from
> the fan-controller.
It'd be nice to mentioned _why_ they are redundant, since the diff
doesn't contain that context.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> .../devicetree/bindings/mfd/gateworks-gsc.yaml | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> index acb9c54942d9..dc379f3ebf24 100644
> --- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> +++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> @@ -122,12 +122,6 @@ patternProperties:
> compatible:
> const: gw,gsc-fan
>
> - "#address-cells":
> - const: 1
> -
> - "#size-cells":
> - const: 0
> -
> reg:
> description: The fan controller base address
> maxItems: 1
> @@ -135,8 +129,6 @@ patternProperties:
> required:
> - compatible
> - reg
> - - "#address-cells"
> - - "#size-cells"
>
> required:
> - compatible
> @@ -194,8 +186,6 @@ examples:
> };
>
> fan-controller@2c {
> - #address-cells = <1>;
> - #size-cells = <0>;
> compatible = "gw,gsc-fan";
> reg = <0x2c>;
> };
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes
2023-05-16 15:33 [PATCH 1/2] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes Tim Harvey
2023-05-16 15:33 ` [PATCH 2/2] arm64: dts: imx8mm-venice-gw700x Tim Harvey
2023-05-16 21:20 ` [PATCH 1/2] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes Conor Dooley
@ 2023-05-17 8:42 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-17 8:42 UTC (permalink / raw)
To: Tim Harvey, linux-arm-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Li Yang,
devicetree, linux-kernel
On 16/05/2023 17:33, Tim Harvey wrote:
> Remove the unnecessary #address-cells and #size-cells nodes from
> the fan-controller.
Say why they are unnecessary (e.g. does not have any children).
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-17 8:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-16 15:33 [PATCH 1/2] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes Tim Harvey
2023-05-16 15:33 ` [PATCH 2/2] arm64: dts: imx8mm-venice-gw700x Tim Harvey
2023-05-16 21:20 ` [PATCH 1/2] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes Conor Dooley
2023-05-17 8:42 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).