devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rongrong Zou <zourongrong@gmail.com>
To: liviu.dudau@arm.com, Arnd Bergmann <arnd@arndb.de>
Cc: Rongrong Zou <zourongrong@huawei.com>,
	devicetree@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Corey Minyard <minyard@acm.org>,
	gregkh@linuxfoundation.org, Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org, linuxarm@huawei.com,
	benh@kernel.crashing.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 3/3] ARM64 LPC: update binding doc
Date: Wed, 13 Jan 2016 19:06:42 +0800	[thread overview]
Message-ID: <56962FC2.1070101@gmail.com> (raw)
In-Reply-To: <20160113100911.GU13633@e106497-lin.cambridge.arm.com>

On 2016/1/13 18:09, liviu.dudau@arm.com wrote:
> On Tue, Jan 12, 2016 at 11:54:59PM +0100, Arnd Bergmann wrote:
>> On Tuesday 12 January 2016 10:14:18 liviu.dudau@arm.com wrote:
>>>
>>> OK, looking at of_translate_one() comments it looks like a missing "ranges" property is
>>> only accepted on PowerPC. I suggest you have an empty "ranges" property in your isa
>>> parent node, that will signal to the OF parsing code that the mapping is 1:1. Then have
>>> the IPMI node use the reg = <0x0 0xe4 4>; property values instead of reg = <0x1 0xe4 4>;
>>>
>>>
>>
>> A missing ranges property means that there is no translation, while an
>> empty ranges means a 1:1 translation to the parent bus.
>>
>> We really want the former here, as I/O port addresses are not mapped into
>> the MMIO space of the parent bus.
>
> Agree. However of_translate_one()'s behaviour doesn't match our expectations and I have no
> useful suggestions on what the right behaviour should be.
>

I had tried to modify the drivers/of/address.c to address this problem, but it looks
not so general. I'm not sure you have seen this: https://lkml.org/lkml/2016/1/10/89 .

Regards,
Rongrong

  parent reply	other threads:[~2016-01-13 11:06 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1451396032-23708-1-git-send-email-zourongrong@gmail.com>
     [not found] ` <1451396032-23708-4-git-send-email-zourongrong@gmail.com>
     [not found]   ` <1899302.RWIn6Bg3Dr@wuerfel>
2015-12-31 14:12     ` [PATCH v1 3/3] ARM64 LPC: update binding doc Rongrong Zou
2015-12-31 14:40       ` Arnd Bergmann
     [not found]         ` <CABTftiT1+AmrNjiAie-T6on-oWA4Zz73+Tj2pQrixMT3o475uw@mail.gmail.com>
     [not found]           ` <CABTftiT1+AmrNjiAie-T6on-oWA4Zz73+Tj2pQrixMT3o475uw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-03 12:24             ` Rongrong Zou
     [not found]               ` <568912EE.9030009-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-01-04 11:13                 ` Arnd Bergmann
2016-01-04 16:04                   ` Rongrong Zou
     [not found]                     ` <568A9803.6050108-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-04 16:34                       ` Arnd Bergmann
2016-01-05 11:59                         ` Rongrong Zou
2016-01-05 12:19                           ` Arnd Bergmann
2016-01-06 13:36                             ` Rongrong Zou
     [not found]                               ` <568D1861.1070201-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-01-07  3:37                                 ` Rongrong Zou
2016-01-10  9:29                             ` Rolland Chau
     [not found]                               ` <56922496.3080402-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-10 13:38                                 ` Rongrong Zou
2016-01-11 16:14                   ` liviu.dudau-5wv7dgnIgG8
2016-01-12  2:39                     ` Rongrong Zou
2016-01-12  9:07                       ` liviu.dudau
2016-01-12  9:25                         ` Rongrong Zou
2016-01-12 10:14                           ` liviu.dudau
2016-01-12 11:05                             ` Rongrong Zou
     [not found]                               ` <5694DDF9.1050902-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-01-12 11:27                                 ` liviu.dudau-5wv7dgnIgG8
2016-01-12 11:56                                   ` Rongrong Zou
     [not found]                                     ` <5694E9FF.6030904-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-01-12 15:13                                       ` liviu.dudau-5wv7dgnIgG8
2016-01-12 22:52                                         ` Arnd Bergmann
2016-01-13  5:53                                           ` Benjamin Herrenschmidt
     [not found]                                             ` <1452664413.2403.20.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2016-01-13  6:34                                               ` Rongrong Zou
     [not found]                                                 ` <5695F007.3070005-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-13  9:26                                                   ` Arnd Bergmann
2016-01-13 10:10                                           ` liviu.dudau-5wv7dgnIgG8
2016-01-13 10:18                                             ` Arnd Bergmann
2016-01-13 10:32                                               ` liviu.dudau-5wv7dgnIgG8
2016-01-12 22:54                             ` Arnd Bergmann
2016-01-13 10:09                               ` liviu.dudau-5wv7dgnIgG8
     [not found]                                 ` <20160113100911.GU13633-2JSQmVVBSi7ZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2016-01-13 10:29                                   ` Arnd Bergmann
2016-01-13 11:06                                 ` Rongrong Zou [this message]
2016-01-13 11:25                                   ` liviu.dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56962FC2.1070101@gmail.com \
    --to=zourongrong@gmail.com \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=liviu.dudau@arm.com \
    --cc=minyard@acm.org \
    --cc=will.deacon@arm.com \
    --cc=zourongrong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).