From: Sinan Kaya <okaya@codeaurora.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org,
devicetree@vger.kernel.org, cov@codeaurora.org,
vinod.koul@intel.com, jcm@redhat.com, agross@codeaurora.org,
arnd@arndb.de, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V12 2/7] dma: hidma: Add Device Tree support
Date: Fri, 15 Jan 2016 12:05:19 -0500 [thread overview]
Message-ID: <569926CF.6030205@codeaurora.org> (raw)
In-Reply-To: <20160115153054.GL3262@leverpostej>
On 1/15/2016 10:30 AM, Mark Rutland wrote:
> Further to my reply below, I'm generally uncomfortable with some
> properties (max-* need a better description if they are a HW
> requirement, and probably should not be present otherwise).
I'll add more description.
> I'm also
> concerned that information necessary for the advertised use-case of the
> device (e.g. IOMMUs) is missing [1], and we're missing parts of the
> story necessary to review this for correctness.
OK. Let me work on this. I tried to capture as much documentation as possible
into the series before. One reviewer said I should add it. Another reviewer said I should
remove it.
Where would be the best place to document the use case?
- In the source file?
- In the commit message?
- In the device-tree documentation?
I'll try to write up something based on your and Mark Zyngier's questions for the
next release.
>
> Until that's settled, I don't think this is ready yet, and I don't think
> this should be picked up.
>
> I'm sorry to say that at this stage, as I realise that may sound
> obstructive. That's not my intention, and I hope we can figure out those
> details quickly.
I hope so too. I'm going towards V20 with small nitpicks rather than the good
feedback like yours.
--
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-01-15 17:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 14:45 [PATCH v12 0/7] dma: add Qualcomm Technologies HIDMA driver Sinan Kaya
2016-01-11 14:45 ` [PATCH V12 1/7] dma: qcom_bam_dma: move to qcom directory Sinan Kaya
2016-01-11 14:45 ` [PATCH V12 2/7] dma: hidma: Add Device Tree support Sinan Kaya
2016-01-15 15:16 ` Mark Rutland
2016-01-15 15:30 ` Mark Rutland
2016-01-15 17:05 ` Sinan Kaya [this message]
2016-01-18 11:39 ` Mark Rutland
2016-01-15 16:49 ` Sinan Kaya
[not found] ` <5699232E.60809-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-01-18 11:49 ` Mark Rutland
2016-01-18 14:04 ` Sinan Kaya
2016-01-11 14:45 ` [PATCH V12 3/7] dma: add Qualcomm Technologies HIDMA management driver Sinan Kaya
2016-01-15 14:56 ` Mark Rutland
2016-01-15 15:12 ` Sinan Kaya
2016-01-15 15:22 ` Mark Rutland
2016-01-15 17:16 ` Sinan Kaya
[not found] ` <56992987.5080603-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-01-15 17:32 ` Marc Zyngier
2016-01-15 22:47 ` Sinan Kaya
2016-01-18 9:06 ` Marc Zyngier
2016-01-22 18:38 ` Sinan Kaya
2016-01-15 15:14 ` Marc Zyngier
2016-01-15 15:36 ` Mark Rutland
2016-01-15 16:01 ` Sinan Kaya
2016-01-20 22:18 ` Sinan Kaya
2016-01-15 15:40 ` Sinan Kaya
[not found] ` <569912F3.9040507-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-01-15 17:28 ` Marc Zyngier
2016-01-15 17:44 ` Sinan Kaya
2016-01-15 18:08 ` Marc Zyngier
2016-01-11 14:45 ` [PATCH V12 4/7] dma: add Qualcomm Technologies HIDMA channel driver Sinan Kaya
2016-01-11 14:45 ` [PATCH V12 5/7] dma: qcom_hidma: implement lower level hardware interface Sinan Kaya
2016-01-11 14:45 ` [PATCH V12 6/7] dma: qcom_hidma: add debugfs hooks Sinan Kaya
2016-01-11 14:45 ` [PATCH V12 7/7] dma: qcom_hidma: add support for object hierarchy Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569926CF.6030205@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=arnd@arndb.de \
--cc=cov@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=timur@codeaurora.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).