From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH V4 5/5] regulator: max77620: add regulator driver for max77620/max20024 Date: Wed, 20 Jan 2016 14:25:59 +0900 Message-ID: <569F1A67.8080902@samsung.com> References: <1453198783-28383-1-git-send-email-ldewangan@nvidia.com> <1453198783-28383-6-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1453198783-28383-6-git-send-email-ldewangan@nvidia.com> Sender: linux-gpio-owner@vger.kernel.org To: Laxman Dewangan , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com Cc: lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, vreddytalla@nvidia.com, Mallikarjun Kasoju List-Id: devicetree@vger.kernel.org On 19.01.2016 19:19, Laxman Dewangan wrote: > MAXIM Semiconductor's PMIC, MAX77620 and MAX20024 have the > multiple DCDC and LDOs. This supplies the power to different > components of the system. > Also these rails has configuration for ramp time, flexible > power sequence, slew rate etc. > > Add regulator driver to access these rails via regulator APIs. > > Signed-off-by: Laxman Dewangan > Signed-off-by: Mallikarjun Kasoju > --- > Changes from V1: > - Cleanup code based on comment received on mfd/rtc. > - Avoid duplication on error message. > > Changes form V2: > - Run coccicheck and checkpatch in strict mode for the alignment. > - Refactor Regulator driver to use core API for DT parsing. > - Update based on API changes. > > Changes from V3: > - Change all sys initcall to module driver. > - change the max77620_read argument to unisgned int from u8. > > drivers/regulator/Kconfig | 9 + > drivers/regulator/Makefile | 1 + > drivers/regulator/max77620-regulator.c | 883 +++++++++++++++++++++++++++++++++ > 3 files changed, 893 insertions(+) > create mode 100644 drivers/regulator/max77620-regulator.c Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof