From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 764CEC0015E for ; Fri, 28 Jul 2023 10:47:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235157AbjG1KrD (ORCPT ); Fri, 28 Jul 2023 06:47:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233660AbjG1KrC (ORCPT ); Fri, 28 Jul 2023 06:47:02 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6EBFC0; Fri, 28 Jul 2023 03:47:01 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 764225C0101; Fri, 28 Jul 2023 06:46:59 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 28 Jul 2023 06:46:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1690541219; x=1690627619; bh=zE uCJaOzZh+kBMJcn4jBJfpUMI5wNH9AosgDceJjJKc=; b=MTuWCUeFiHnLM2pwyo zxp7ZCSmgM5/ugQQxma3Fu8kFrD8gVNAvaeI1F+n4ZQ9+QIN/r9bNQ8rDTH5u4mX oMUSp3YvTKphMsBOfe/yEqOyPOKZlK1eldq6fVlU3vIxG5B0ixRomK5Qa/DZhdMk 0sRxHDL3VaXX2lxI16n/jmP9SIjkz8Jrg8oF7wdTUGeqp4wt1cJkvZBPbRkpw5zk f6V8wBTwuCQtQHXwrUuDcOTJqgNTWnqj/hTi1pOj5G66x5UGX0w+dp5RM76MRW9b 7WoPEXugDvpMIVay2TFPSLMYZ+Emv8Ykib2mZ3byADE6Mqpj0sSV+aJljddvptan bLLA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1690541219; x=1690627619; bh=zEuCJaOzZh+kB MJcn4jBJfpUMI5wNH9AosgDceJjJKc=; b=2ujtNkF3iobFUBQyjYpHbbTVpTvJU 9oSuSnziGy+Bo073zVeiCXjQqqwmuS12JnK1xOL4EG72nmAbYjV23Cwv1sY5kR5V QgGcwRAAT4Hdiy4+zOODXp6AD4bDozYEZkbkKQYbMe144L014OYZrL2TPqTA9wri g6lDD5R77Mm2SxtFDXmwDHd5/KyCE+P8scwM9ndL/ZzK1JLFwsiGQUVUrPmpuhEv j+g2XRVJA8MfCqddOmxlHWiSgkWiFxxdib3eHwB1vFSSiogcY1Ow/Elb+eIYjE64 6BVmk+QFMO0gaCDIY+zD+VW2huel7ydKXiR40M/OcUXuBsxayp7AoP89g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieeigdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1563CB60089; Fri, 28 Jul 2023 06:46:57 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-592-ga9d4a09b4b-fm-defalarms-20230725.001-ga9d4a09b Mime-Version: 1.0 Message-Id: <569a1c8e-234a-442f-9b9e-956f5bac26dc@app.fastmail.com> In-Reply-To: <20230728074944.26746-3-zhuyinbo@loongson.cn> References: <20230728074944.26746-1-zhuyinbo@loongson.cn> <20230728074944.26746-3-zhuyinbo@loongson.cn> Date: Fri, 28 Jul 2023 12:46:37 +0200 From: "Arnd Bergmann" To: "Yinbo Zhu" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "Ulf Hansson" Cc: "Jianmin Lv" , wanghongliang@loongson.cn, "Liu Peibao" , loongson-kernel@lists.loongnix.cn, "Liu Yun" Subject: Re: [PATCH v5 2/2] soc: loongson2_pm: add power management support Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jul 28, 2023, at 09:49, Yinbo Zhu wrote: > The Loongson-2's power management controller was ACPI, supports ACPI > S2Idle (Suspend To Idle), ACPI S3 (Suspend To RAM), ACPI S4 (Suspend To > Disk), ACPI S5 (Soft Shutdown) and supports multiple wake-up methods > (USB, GMAC, PWRBTN, etc.). This driver was to add power management > controller support that base on dts for Loongson-2 series SoCs. > > Co-developed-by: Liu Yun > Signed-off-by: Liu Yun > Co-developed-by: Liu Peibao > Signed-off-by: Liu Peibao > Signed-off-by: Yinbo Zhu Adding Ulf Hansson to Cc Ulf has recently split out the "genpd" framework and split out drivers/genpd from drivers/soc since I'm generally not that involved in the pwoer management side. Can you have a look at whether this driver should also be part of drivers/genpd rather than drivers/soc, and/or converted to use the genpd infrastructure? Thanks, Arnd